fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
Subsystems (2)
PATCH 1/1 fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
If both CONFIG_PM_SLEEP and CONFIG_PM_RUNTIME are not set:
drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend? defined but not used drivers/video/sh_mobile_meram.c:597: warning: ?sh_mobile_meram_resume? defined but not used
---
v2: Both functions are used if CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME,
as pointed out by Laurent
drivers/video/sh_mobile_meram.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/video/sh_mobile_meram.c +2 -0
@@ -569,6 +569,7 @@ EXPORT_SYMBOL_GPL(sh_mobile_meram_cache_update);* Power management */ +#if defined(CONFIG_PM_SLEEP ) || defined(CONFIG_PM_RUNTIME )static int sh_mobile_meram_suspend (struct device *dev) {struct platform_device *pdev =to_platform_device (dev);
@@ -611,6 +612,7 @@ static int sh_mobile_meram_resume(struct device *dev)meram_write_reg (priv->base, common_regs[i], priv->regs[i]);return 0 ; } +#endif /* CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME */ static UNIVERSAL_DEV_PM_OPS(sh_mobile_meram_dev_pm_ops, sh_mobile_meram_suspend,
Signature · 1 line
1.7.9.5
PATCH 1/1 fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
Hi Geert,
Thank you for the patch.
Quoted 7 lines · On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
If both
CONFIG_PM_SLEEPandCONFIG_PM_RUNTIMEare not set:
drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend? defined but not useddrivers/video/sh_mobile_meram.c:597: warning:
?sh_mobile_meram_resume? defined but not usedSigned-off-by Geert Uytterhoeven <[email protected]>
and applied to my tree.
Quoted 27 lines
---
v2: Both functions are used ifCONFIG_PM_SLEEP||CONFIG_PM_RUNTIME,
as pointed out by Laurentdrivers/video/sh_mobile_meram.c | 2 ++ 1 file changed, 2 insertions(+)(quoted diff) +0
-0
b/drivers/video/sh_mobile_meram.cindexe0f098562a74..a297de5cc859100644drivers/video/sh_mobile_meram.c +2
-0@@ -569,6 +569,7 @@ EXPORT_SYMBOL_GPL(sh_mobile_meram_cache_update);* Power management */ +#if defined(CONFIG_PM_SLEEP ) || defined(CONFIG_PM_RUNTIME )static int sh_mobile_meram_suspend (struct device *dev) {struct platform_device *pdev =to_platform_device (dev);@@ -611,6 +612,7 @@ static int sh_mobile_meram_resume(struct device *dev)meram_write_reg (priv->base, common_regs[i], priv->regs[i]);return 0 ; } +#endif /* CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME */ static UNIVERSAL_DEV_PM_OPS(sh_mobile_meram_dev_pm_ops, sh_mobile_meram_suspend,
Signature · 3 lines
Regards, Laurent Pinchart
PATCH 1/1 fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
Hi Laurent,
Quoted 11 lines · Laurent Pinchart
Hi Geert,
Thank you for the patch.
Quoted 6 lines · On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
If both
CONFIG_PM_SLEEPandCONFIG_PM_RUNTIMEare not set:
drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend? defined but not useddrivers/video/sh_mobile_meram.c:597: warning:
?sh_mobile_meram_resume? defined but not used
Quoted 5 lines
Quoted 1 line
Signed-off-by Geert Uytterhoeven <[email protected]>Acked-by Laurent Pinchart <[email protected]>and applied to my tree.
What does that mean? Are you collecting sh_mobile video patches?
Or to rephrase, shall I apply this to fbdev fixes tree?
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131126/32fe24be/attachment.sig>
PATCH 1/1 fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
Hi Tomi,
Quoted 10 lines · On Tuesday 26 November 2013 16:44:09 Tomi Valkeinen wrote:
Quoted 9 lines · Laurent Pinchart
Quoted 7 lines · On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
If both
CONFIG_PM_SLEEPandCONFIG_PM_RUNTIMEare not set:
drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend? defined but not useddrivers/video/sh_mobile_meram.c:597: warning:
?sh_mobile_meram_resume? defined but not usedSigned-off-by Geert Uytterhoeven <[email protected]>
Quoted 7 lines
Quoted 3 lines
Acked-by Laurent Pinchart <[email protected]>and applied to my tree.
What does that mean? Are you collecting
sh_mobilevideo patches?Or to rephrase, shall I apply this to fbdev fixes tree?
I was planning to send you a pull request for that, but if you can pick it up that's even easier, thanks.
Signature · 10 lines
Regards, Laurent Pinchart -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 490 bytes Desc: This is a digitally signed message part. URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131126/9a4a3971/attachment.sig>
PATCH 1/1 fbdev: sh_mobile_meram: Fix defined but not used compiler warnings
Quoted 15 lines · Laurent Pinchart
Hi Tomi,
Quoted 12 lines · On Tuesday 26 November 2013 16:44:09 Tomi Valkeinen wrote:
Quoted 11 lines · Laurent Pinchart
Quoted 7 lines · On Wednesday 06 November 2013 09:57:27 Geert Uytterhoeven wrote:
If both
CONFIG_PM_SLEEPandCONFIG_PM_RUNTIMEare not set:
drivers/video/sh_mobile_meram.c:573: warning: ?sh_mobile_meram_suspend? defined but not useddrivers/video/sh_mobile_meram.c:597: warning:
?sh_mobile_meram_resume? defined but not usedSigned-off-by Geert Uytterhoeven <[email protected]>Acked-by Laurent Pinchart <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
and applied to my tree.
What does that mean? Are you collecting
sh_mobilevideo patches?Or to rephrase, shall I apply this to fbdev fixes tree?
I was planning to send you a pull request for that, but if you can pick it up that's even easier, thanks.
Ok. Applied, then, to fbdev =).
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131126/89bb7bcc/attachment.sig>