Patch "test: firmware_class: report errors properly on failure" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
test: firmware_class: report errors properly on failure
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
test-firmware_class-report-errors-properly-on-failure.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
47e0bbb7fa985a0f1b5794a8653fae4f8f49de77Mon Sep 17 00:00:00 2001
From: Brian Norris <[email protected]>
Date: Wed, 9 Dec 2015 14:50:25 -0800
Subject: test: firmware_class: report errors properly on failure
From: Brian Norris <[email protected]>
commit 47e0bbb7fa985a0f1b5794a8653fae4f8f49de77 upstream.
request_firmware() failures currently won't get reported at all (the error code is discarded). What's more, we get confusing messages, like:
# echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request
[ 8280.311856] test_firmware: loading 'notafile'
[ 8280.317042] test_firmware: load of 'notafile' failed: -2
[ 8280.322445] test_firmware: loaded: 0
# echo $?
0Report the failures via write() errors, and don't say we "loaded" anything.
--- lib/test_firmware.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
lib/test_firmware.c +8 -3
@@ -65,14 +65,19 @@ static ssize_t trigger_request_store(strrelease_firmware (test_firmware); test_firmware =NULL ; rc =request_firmware (&test_firmware, name, dev); -if (rc) +if (rc) {pr_info ("load of '%s' failed: %d\n" , name, rc); -pr_info ("loaded: %zu\n" , test_firmware ? test_firmware->size :0 ); + goto out; + } +pr_info ("loaded: %zu\n" , test_firmware->size); + rc = count; + +out:mutex_unlock (&test_fw_mutex);kfree (name); -return count; +return rc; }static DEVICE_ATTR_WO (trigger_request);
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/selftests-firmware-add-empty-string-and-async-tests.patch queue-4.4/test-firmware_class-report-errors-properly-on-failure.patch