Skip to contentSkip to conversation

Patch "PKCS#7: fix unitialized boolean 'want'" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Nov 13, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

PKCS#7: fix unitialized boolean 'want'

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
pkcs-7-fix-unitialized-boolean-want.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 06aae592425701851e02bb850cb9f4997f0ae163 Mon Sep 17 00:00:00 2001

From: Colin Ian King <[email protected]>
Date: Sat, 27 Feb 2016 12:45:26 +0000
Subject: PKCS#7: fix unitialized boolean 'want'

From: Colin Ian King <[email protected]>

commit 06aae592425701851e02bb850cb9f4997f0ae163 upstream.

The boolean want is not initialized and hence garbage. The default should be false (later it is only set to true on tne sinfo->authattrs check).

Found with static analysis using CoverityScan

---
 crypto/asymmetric_keys/pkcs7_parser.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
crypto/asymmetric_keys/pkcs7_parser.c +1 -1
@@ -87,7 +87,7 @@ EXPORT_SYMBOL_GPL(pkcs7_free_message);
 static int pkcs7_check_authattrs(struct pkcs7_message *msg)
 {
 	struct pkcs7_signed_info *sinfo;
-	bool want;
+	bool want = false;
 
 	sinfo = msg->signed_infos;
 	if (!sinfo)

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/pkcs-7-fix-unitialized-boolean-want.patch