module names in request_module()
Hi all, I've noticed a problem:
if I depmod a module that needs cfi and cfi_probe is not loaded, request_module fails, because it is looking for the module named "cfi" not "cfi_probe".
should we fix this?
Signature · 4 lines
Tim Hockin Systems Software Engineer Sun Microsystems, Cobalt Server Appliances [email protected]
Quoted 3 lines · [email protected] said:
if I depmod a module that needs cfi and
cfi_probeis not loaded,request_modulefails, because it is looking for the module named "cfi" not "cfi_probe".
Does v1.9 of chipreg.c fix it correctly?
--
dwmw2
Quoted 7 lines · David Woodhouse
Quoted 3 lines · [email protected] said:
if I depmod a module that needs cfi and
cfi_probeis not loaded,request_modulefails, because it is looking for the module named "cfi" not "cfi_probe".Does v1.9 of
chipreg.cfix it correctly?
only for cfi
the problem is that the module name is not predictable from the "probe" name.
cfi -> cfi_probe.o
jedec -> jedec.o
ram -> map_ram.o
rom -> map_rom.oamd_flash -> amd_flash.o
there is no way to have that knowledge a priori with modules.
So we have three options:
1) rename files to match their probe names
2) rename probe names to match module names
3) use modules.conf to give external fixes for internal flaws
I'm leaning towards #2. Comments?
Signature · 4 lines
Tim Hockin Systems Software Engineer Sun Microsystems, Cobalt Server Appliances [email protected]
Quoted 5 lines · [email protected] said:
So we have three options:
1) rename files to match their probe names
2) rename probe names to match module names
3) use modules.conf to give external fixes for internal flaws
I'm leaning towards #2. Comments?
Fine.
--
dwmw2
Quoted 9 lines · David Woodhouse
Quoted 5 lines · [email protected] said:
So we have three options:
1) rename files to match their probe names
2) rename probe names to match module names
3) use modules.conf to give external fixes for internal flaws
I'm leaning towards #2. Comments?Fine.
in CVS now. Will this be propogated to 2.4.7 or should I send it to Linus also?
Signature · 4 lines
Tim Hockin Systems Software Engineer Sun Microsystems, Cobalt Server Appliances [email protected]