kvm-unit-tests: Bump version

PATCH New Cyril Bur 3 participants 5 messages Nov 20, 2017

Share & tools

Cyril Bur

author

2017-11-20 05:48 UTC #0 lore raw

PATCH 1/1 kvm-unit-tests: Bump version

Since binutils commit 1a9ccd70f9a7 ("Fix the linker so that it will not silently generate ELF binaries with invalid program headers. Fix readelf to report such invalid binaries.") the behaviour has changed and binutils tries to create a program header segment for which there is no space. Thanks to Nicholas Piggin and his patch to Linux:
https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next&id=ff45000fcb56b5b0f

Cedric fixed this in kvm-unit-tests commit 95062c20790d ("powerpc: add -n to LDFLAGS") so bump to that version.

Fixes:
http://autobuild.buildroot.net/results/80825b492abf61313637b109d6a0944b38d5f739

Signed-off-by Cyril Bur <[email protected]>

---
 package/kvm-unit-tests/kvm-unit-tests.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/kvm-unit-tests/kvm-unit-tests.mk +1 -1

index 0ddb017802..767e855d26 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-KVM_UNIT_TESTS_VERSION = 5731572b2ac23eb410732110b93425b5bb7f27dd
+KVM_UNIT_TESTS_VERSION = 95062c20790d82713bfa7475b61a4adef3f3645a
 KVM_UNIT_TESTS_SITE = $(BR2_KERNEL_MIRROR)/scm/virt/kvm/kvm-unit-tests.git
 KVM_UNIT_TESTS_SITE_METHOD = git
 KVM_UNIT_TESTS_LICENSE = LGPLv2

Signature · 1 line

2.15.0

Baruch Siach

2017-11-20 08:06 UTC #1 lore raw

PATCH 1/1 kvm-unit-tests: Bump version

Hi Cyril,

Quoted 22 lines · Cyril Bur

Since binutils commit 1a9ccd70f9a7 ("Fix the linker so that it will not silently generate ELF binaries with invalid program headers. Fix readelf to report such invalid binaries.") the behaviour has changed and binutils tries to create a program header segment for which there is no space. Thanks to Nicholas Piggin and his patch to Linux:
https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next&id=ff45000fcb56b5b0f
Cedric fixed this in kvm-unit-tests commit 95062c20790d ("powerpc: add -n to LDFLAGS") so bump to that version.
Fixes:
http://autobuild.buildroot.net/results/80825b492abf61313637b109d6a0944b38d5f739
Signed-off-by Cyril Bur <[email protected]>
---
 package/kvm-unit-tests/kvm-unit-tests.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/kvm-unit-tests/kvm-unit-tests.mk +0 -0
index 0ddb017802..767e855d26 100644

package/kvm-unit-tests/kvm-unit-tests.mk line 10

Quoted 8 lines

package/kvm-unit-tests/kvm-unit-tests.mk +1 -1

@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-KVM_UNIT_TESTS_VERSION = 5731572b2ac23eb410732110b93425b5bb7f27dd
+KVM_UNIT_TESTS_VERSION = 95062c20790d82713bfa7475b61a4adef3f3645a
 KVM_UNIT_TESTS_SITE = $(BR2_KERNEL_MIRROR)/scm/virt/kvm/kvm-unit-tests.git
 KVM_UNIT_TESTS_SITE_METHOD = git
 KVM_UNIT_TESTS_LICENSE = LGPLv2

This context line is not in current master branch. Please rebase on current master.

baruch

Signature · 3 lines

     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Thomas Petazzoni

2017-11-20 21:14 UTC #2 lore raw

PATCH 1/1 kvm-unit-tests: Bump version

In reply to Cyril Bur

Hello,

Quoted 10 lines · Cyril Bur

Since binutils commit 1a9ccd70f9a7 ("Fix the linker so that it will not silently generate ELF binaries with invalid program headers. Fix readelf to report such invalid binaries.") the behaviour has changed and binutils tries to create a program header segment for which there is no space. Thanks to Nicholas Piggin and his patch to Linux:
https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next&id=ff45000fcb56b5b0f
Cedric fixed this in kvm-unit-tests commit 95062c20790d ("powerpc: add -n to LDFLAGS") so bump to that version.

Quoted 6 lines

Fixes:
http://autobuild.buildroot.net/results/80825b492abf61313637b109d6a0944b38d5f739
Signed-off-by Cyril Bur <[email protected]>
---
 package/kvm-unit-tests/kvm-unit-tests.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I'm not sure how you tested this patch. The change to the hash file was missing, and one of the patches in package/kvm-unit-tests/ was not applying anymore.

I've fixed up those issues and applied your patch to the master branch, but it'd be nice to have a patch tested a bit better next time :-)

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Cyril Bur

author

2017-11-20 23:27 UTC #3 lore raw

PATCH 1/1 kvm-unit-tests: Bump version

Quoted 20 lines · Thomas Petazzoni

Hello,
Quoted 10 lines · Cyril Bur
Since binutils commit 1a9ccd70f9a7 ("Fix the linker so that it will not silently generate ELF binaries with invalid program headers. Fix readelf to report such invalid binaries.") the behaviour has changed and binutils tries to create a program header segment for which there is no space. Thanks to Nicholas Piggin and his patch to Linux:
https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next&id=ff45000fcb56b5b0f
Cedric fixed this in kvm-unit-tests commit 95062c20790d ("powerpc: add -n to LDFLAGS") so bump to that version.
Quoted 6 lines
Fixes:
http://autobuild.buildroot.net/results/80825b492abf61313637b109d6a0944b38d5f739
Signed-off-by Cyril Bur <[email protected]>
---
 package/kvm-unit-tests/kvm-unit-tests.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 9 lines

I'm not sure how you tested this patch. The change to the hash file was missing, and one of the patches in package/kvm-unit-tests/ was not applying anymore.
I've fixed up those issues and applied your patch to the master branch, but it'd be nice to have a patch tested a bit better next time :-)
Thanks!

Yeah sorry, I think I had a really old tree, I use buildroot for so much I think there was a fail on my part to check the tree. Sorry!

Quoted 1 line

Thomas

Cyril Bur

author

2017-11-20 23:25 UTC #4 lore raw

PATCH 1/1 kvm-unit-tests: Bump version

In reply to Cyril Bur

Quoted 7 lines · Cyril Bur

Since binutils commit 1a9ccd70f9a7 ("Fix the linker so that it will not silently generate ELF binaries with invalid program headers. Fix readelf to report such invalid binaries.") the behaviour has changed and binutils tries to create a program header segment for which there is no space. Thanks to Nicholas Piggin and his patch to Linux:
https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?h=next&id=ff45000fcb56b5b0f

Quoted 6 lines

Cedric fixed this in kvm-unit-tests commit 95062c20790d ("powerpc: add -n to LDFLAGS") so bump to that version.
Fixes:
http://autobuild.buildroot.net/results/80825b492abf61313637b109d6a0944b38d5f739
Signed-off-by Cyril Bur <[email protected]>

Thanks for the fixups Thomas!

Quoted 17 lines

---
 package/kvm-unit-tests/kvm-unit-tests.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

package/kvm-unit-tests/kvm-unit-tests.mk +1 -1

index 0ddb017802..767e855d26 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-KVM_UNIT_TESTS_VERSION = 5731572b2ac23eb410732110b93425b5bb7f27dd
+KVM_UNIT_TESTS_VERSION = 95062c20790d82713bfa7475b61a4adef3f3645a
 KVM_UNIT_TESTS_SITE = $(BR2_KERNEL_MIRROR)/scm/virt/kvm/kvm-unit-tests.git
 KVM_UNIT_TESTS_SITE_METHOD = git
 KVM_UNIT_TESTS_LICENSE = LGPLv2