Enabling of the new testimage class for sanity tests
cover Enabling of the new testimage class for sanity tests
Hi Beth,
The first two patches enable the new testimage class that has just been merged in master, and it needs a real AB shakedown ;).
On my local AB one of the problems I've had were timeouts
for qemu booting (when the machine was really loaded), and I've sent a patch to increase the timeout, but
this might need a little more tweaking for the Yocto AB. Also, one more setup issue could be DISPLAY / vnc server. I've had some trouble with DISPLAY=localhost:1 that's why you'll notice
I've used DISPLAY=:1, that fixed the problem out on my machine. It has something to do with how the new class starts the runqemu script and the enviroment.
The last patch has nothing to do with enabling, I just thought that we should run the sanity tests for the sdk images too given that the new class has a gcc test. It adds a few minutes to the builds, keep this one out if that's problem.
Cheers,
Stefan
The following changes since commit b26b257e16fddb7730d3b2a0c55c4b43a48ae54c:
Revert "buildset-config: build core-image-sato SDK" (2013-07-02 17:10:05 -0700)
are available in the git repository at:
git://mirror.rb.intel.com/git.yoctoproject.org/poky-contrib stefans/yab-newsanity3
for you to fetch changes up to e15d6185251e4c6f163577c7263239936d76e5b3:
buildsets: run sanity tests for core-image-sato-sdk images (2013-07-10 19:07:27 +0300)
----------------------------------------------------------------
Stefan Stanacar (3):
RunSanityTests: add support for the new testimage class nightly-multilib,qa-systemd.conf: enable specific tests with the new class
buildsets: run sanity tests for core-image-sato-sdk images
buildset-config/nightly-arm.conf | 2 +- buildset-config/nightly-mips.conf | 2 +- buildset-config/nightly-multilib.conf | 8 +++---- buildset-config/nightly-ppc.conf | 2 +- buildset-config/nightly-qa-systemd.conf | 4 ++-- buildset-config/nightly-x86-64.conf | 2 +- buildset-config/nightly-x86.conf | 2 +- .../autobuilder/buildsteps/RunSanityTests.py | 27 ++++++++++++++++------ 8 files changed, 31 insertions(+), 18 deletions(-)
Stefan Stanacar (3):
RunSanityTests: add support for the new testimage class nightly-multilib,qa-systemd.conf: enable specific tests with the new
class
buildsets: run sanity tests for core-image-sato-sdk images
buildset-config/nightly-arm.conf | 2 +- buildset-config/nightly-mips.conf | 2 +- buildset-config/nightly-multilib.conf | 8 +++---- buildset-config/nightly-ppc.conf | 2 +- buildset-config/nightly-qa-systemd.conf | 4 ++-- buildset-config/nightly-x86-64.conf | 2 +- buildset-config/nightly-x86.conf | 2 +- .../autobuilder/buildsteps/RunSanityTests.py | 27 ++++++++++++++++------ 8 files changed, 31 insertions(+), 18 deletions(-)
Signature · 1 line
1.8.1.4
PATCH 1/3 RunSanityTests: add support for the new testimage class
Now that the new qemu testimage class has been merged in master, we should use it instead of the old one.
We use "suites" keyword to overwrite the default tests (which are defined in the class) and "suitesappend" to append to the default list for special cases (like systemd images)
[YOCTO #4838]
--- .../autobuilder/buildsteps/RunSanityTests.py | 27 ++++++++++++++++------ 1 file changed, 20 insertions(+), 7 deletions(-)
lib/python2.7/site-packages/autobuilder/buildsteps/RunSanityTests.py +20 -7
@@ -24,23 +24,36 @@ class RunSanityTests(ShellCommand): self.factory = factory self.images="" self.scene=None + self.suites=None + self.suitesappend=None # the default of 1200 seconds is enough for running sanity tests in most cases self.timeout = 1200 for k, v in argdict.iteritems(): setattr(self, k, v) self.description = "Running Sanity Tests" + kwargs['timeout']=self.timeout + ShellCommand.__init__(self, **kwargs) + + def start(self): + branch = self.getProperty("branch_poky") command = "" command = command + ". ./oe-init-build-env; " command = command + "(echo > /dev/tcp/localhost/5901) 2> /dev/null;" command = command + 'if [ $? -ne 0 ]; then echo "Starting a VNC server on :1"; vncserver :1; else echo "Will use a VNC server already running on :1"; fi;' - command = command + "echo 'IMAGETEST = \"qemu\"' >> ./conf/auto.conf;" - if self.scene: - command = command + "echo 'TEST_SCEN = \"" + self.scene + "\"'" + " >> ./conf/auto.conf;" - command = command + "DISPLAY=localhost:1 bitbake " + self.images + " -c qemuimagetest_standalone" - # Timeout needs to be passed to LoggingBuildStep as a kwarg - kwargs['timeout']=self.timeout + if "danny" not in branch and "dylan" not in branch: + command = command + "echo 'INHERIT += \"testimage\"' >> ./conf/auto.conf;" + if self.suites: + command = command + "echo 'TEST_SUITES = \"" + self.suites + "\"'" + " >> ./conf/auto.conf;" + if self.suitesappend: + command = command + "echo 'TEST_SUITES_append = \" " + self.suitesappend + "\"'" + " >> ./conf/auto.conf;" + command = command + "DISPLAY=:1 bitbake " + self.images + " -c testimage" + else: + command = command + "echo 'IMAGETEST = \"qemu\"' >> ./conf/auto.conf;" + if self.scene: + command = command + "echo 'TEST_SCEN = \"" + self.scene + "\"'" + " >> ./conf/auto.conf;" + command = command + "DISPLAY=localhost:1 bitbake " + self.images + " -c qemuimagetest_standalone" self.command = command - ShellCommand.__init__(self, **kwargs) + ShellCommand.start(self) def describe(self, done=False): description = ShellCommand.describe(self,done)
Signature · 1 line
1.8.1.4
PATCH 2/3 nightly-multilib, qa-systemd.conf: enable specific tests with the new class
In reply to Stefan StanacarEnable specific tests for some builds (like systemd and multilib which aren't by default enabled in the testimage class)
Also because one of the multilib builds is an ipk build and the default suite contains rpm and smart we need to overwrite the suite.
[YOCTO #4838]
--- buildset-config/nightly-multilib.conf | 8 ++++---- buildset-config/nightly-qa-systemd.conf | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-)
buildset-config/nightly-multilib.conf +4 -4
@@ -15,15 +15,15 @@ steps: [{'SetDest':{}}, {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'x86_64', 'multilib': True, 'distro': 'poky'}}, {'CreateBBLayersConf': {'buildprovider' : 'yocto'}}, {'BuildImages': {'images': 'lib32-core-image-minimal'}}, - {'RunSanityTests': {'images': 'lib32-core-image-minimal', 'scene' : 'sanity:boot'}}, + {'RunSanityTests': {'images': 'lib32-core-image-minimal', 'scene' : 'sanity:boot', 'suites' : 'ping'}}, {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'x86_64', 'multilib': True, 'distro': 'poky', 'packages' : 'ipk'}}, {'BuildImages': {'images': 'lib32-core-image-minimal'}}, - {'RunSanityTests': {'images': 'lib32-core-image-minimal', 'scene' : 'sanity:boot'}}, + {'RunSanityTests': {'images': 'lib32-core-image-minimal', 'scene' : 'sanity:boot', 'suites' : 'ping'}}, {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'x86_64', 'multilib': 'lib32', 'distro': 'poky', 'atextappend' : '\nIMAGE_INSTALL_append = " lib32-connman-gnome"\n'}}, {'BuildImages': {'images': 'core-image-sato'}}, - {'RunSanityTests': {'images': 'core-image-sato'}}, + {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'multilib'}}, {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'x86_64', 'multilib': 'lib32', 'distro': 'poky', 'packages' : 'ipk', 'atextappend' : '\nIMAGE_INSTALL_append = " lib32-connman-gnome"\n'}}, {'BuildImages': {'images': 'core-image-sato'}}, - {'RunSanityTests': {'images': 'core-image-sato'}}, + {'RunSanityTests': {'images': 'core-image-sato', 'suites' : 'ping ssh connman xorg multilib dmesg auto'}}, {'CreateAutoConf': {'machine': 'qemux86', 'SDKMACHINE' : 'i686', 'multilib': 'lib64', 'distro': 'poky'}}, {'BuildImages': {'images': 'lib64-core-image-sato lib64-core-image-sato-sdk lib64-core-image-lsb-sdk'}}]
buildset-config/nightly-qa-systemd.conf +2 -2
@@ -11,10 +11,10 @@ steps: [{'SetDest':{}}, {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'initmgr' : 'systemd sysvinit'}}, {'CreateBBLayersConf': {'buildprovider' : 'yocto'}}, {'BuildImages': {'images': 'core-image-sato'}}, - {'RunSanityTests': {'images': 'core-image-sato'}}, + {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'systemd'}}, {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'initmgr' : 'sysvinit systemd'}}, {'BuildImages': {'images': 'core-image-sato'}}, {'RunSanityTests': {'images': 'core-image-sato'}}, {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'initmgr' : 'systemd'}}, {'BuildImages': {'images': 'core-image-sato'}}, - {'RunSanityTests': {'images': 'core-image-sato'}}] + {'RunSanityTests': {'images': 'core-image-sato', 'suitesappend' : 'systemd'}}]
Signature · 1 line
1.8.1.4
PATCH 3/3 buildsets: run sanity tests for core-image-sato-sdk images
In reply to Stefan StanacarWe build sato-sdk images in these nightly targets
(and now we have a gcc test in the new testimage class), so for a few more minutes added we should test these images too.
--- buildset-config/nightly-arm.conf | 2 +- buildset-config/nightly-mips.conf | 2 +- buildset-config/nightly-ppc.conf | 2 +- buildset-config/nightly-x86-64.conf | 2 +- buildset-config/nightly-x86.conf | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
buildset-config/nightly-arm.conf +1 -1
@@ -16,7 +16,7 @@ steps: [{'SetDest':{}}, {'CreateBBLayersConf': {'buildprovider' : 'yocto'}}, {'SyncPersistDB' : {'distro' : 'poky'}}, {'BuildImages': {'images': 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}}, - {'RunSanityTests': {'images': 'core-image-minimal core-image-sato'}}, + {'RunSanityTests': {'images': 'core-image-minimal core-image-sato core-image-sato-sdk'}}, {'CreateAutoConf': {'machine': 'beagleboard', 'SDKMACHINE' : 'i686', 'distro': 'poky'}}, {'BuildImages': {'images': 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}}, {'CreateAutoConf': {'machine': 'qemuarm', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'buildhistory' : False}},
buildset-config/nightly-mips.conf +1 -1
@@ -16,7 +16,7 @@ steps: [{'SetDest':{}}, {'CreateBBLayersConf': {'buildprovider' : 'yocto'}}, {'SyncPersistDB' : {'distro' : 'poky'}}, {'BuildImages': {'images': 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}}, - {'RunSanityTests': {'images': 'core-image-minimal core-image-sato'}}, + {'RunSanityTests': {'images': 'core-image-minimal core-image-sato core-image-sato-sdk'}}, {'CreateAutoConf': {'machine': 'routerstationpro', 'SDKMACHINE' : 'i686', 'distro': 'poky'}}, {'BuildImages': {'images': 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}}, {'CreateAutoConf': {'machine': 'qemumips', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'buildhistory' : False}},
buildset-config/nightly-ppc.conf +1 -1
@@ -16,7 +16,7 @@ steps: [{'SetDest':{}}, {'CreateBBLayersConf': {'buildprovider' : 'yocto'}}, {'SyncPersistDB' : {'distro' : 'poky'}}, {'BuildImages': {'images': 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}}, - {'RunSanityTests': {'images': 'core-image-minimal core-image-sato'}}, + {'RunSanityTests': {'images': 'core-image-minimal core-image-sato core-image-sato-sdk'}}, {'CreateAutoConf': {'machine': 'mpc8315e-rdb', 'SDKMACHINE' : 'i686', 'distro': 'poky'}}, {'BuildImages': {'images': 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}}, {'CreateAutoConf': {'machine': 'qemuppc', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'buildhistory' : False}},
buildset-config/nightly-x86-64.conf +1 -1
@@ -16,7 +16,7 @@ steps: [{'SetDest':{}}, {'CreateBBLayersConf': {'buildprovider' : 'yocto'}}, {'SyncPersistDB' : {'distro' : 'poky'}}, {'BuildImages': {'images': 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}}, - {'RunSanityTests': {'images': 'core-image-minimal core-image-sato'}}, + {'RunSanityTests': {'images': 'core-image-minimal core-image-sato core-image-sato-sdk'}}, {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'buildhistory' : False}}, {'BuildImages': {'images': 'meta-toolchain-gmae'}}, {'CreateAutoConf': {'machine': 'qemux86-64', 'SDKMACHINE' : 'x86-64', 'distro': 'poky', 'buildhistory' : False}},
buildset-config/nightly-x86.conf +1 -1
@@ -16,7 +16,7 @@ steps: [{'SetDest':{}}, {'CreateBBLayersConf': {'buildprovider' : 'yocto'}}, {'SyncPersistDB' : {'distro' : 'poky'}}, {'BuildImages': {'images': 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}}, - {'RunSanityTests': {'images': 'core-image-minimal core-image-sato'}}, + {'RunSanityTests': {'images': 'core-image-minimal core-image-sato core-image-sato-sdk'}}, {'CreateAutoConf': {'machine': 'atom-pc', 'SDKMACHINE' : 'i686', 'distro': 'poky'}}, {'BuildImages': {'images': 'core-image-sato core-image-sato-dev core-image-sato-sdk core-image-minimal core-image-minimal-dev'}}, {'CreateAutoConf': {'machine': 'qemux86', 'SDKMACHINE' : 'i686', 'distro': 'poky', 'buildhistory' : False}},
Signature · 1 line
1.8.1.4
Flanagan, Elizabeth
AppliedMerged into master and production. Thanks.
-b
Quoted 67 lines · Stefan Stanacar
Hi Beth,
The first two patches enable the new testimage class that has just been merged in master, and it needs a real AB shakedown ;).
On my local AB one of the problems I've had were timeouts
for qemu booting (when the machine was really loaded), and I've sent a patch to increase the timeout, but
this might need a little more tweaking for the Yocto AB. Also, one more setup issue could be DISPLAY / vnc server. I've had some trouble with DISPLAY=localhost:1 that's why you'll notice
I've used DISPLAY=:1, that fixed the problem out on my machine. It has something to do with how the new class starts the runqemu script and the enviroment.The last patch has nothing to do with enabling, I just thought that we should run the sanity tests for the sdk images too given that the new class has a gcc test. It adds a few minutes to the builds, keep this one out if that's problem.
Cheers,
StefanThe following changes since commit
b26b257e16fddb7730d3b2a0c55c4b43a48ae54c:Revert "buildset-config: build core-image-sato SDK" (2013-07-02 17:10:05 -0700)
are available in the git repository at:
git://mirror.rb.intel.com/git.yoctoproject.org/poky-contribstefans/yab-newsanity3for you to fetch changes up to
e15d6185251e4c6f163577c7263239936d76e5b3:buildsets: run sanity tests for core-image-sato-sdk images (2013-07-10 19:07:27 +0300)
----------------------------------------------------------------
Stefan Stanacar (3):
RunSanityTests: add support for the new testimage class nightly-multilib,qa-systemd.conf: enable specific tests with the new class
buildsets: run sanity tests for core-image-sato-sdk imagesbuildset-config/nightly-arm.conf | 2 +- buildset-config/nightly-mips.conf | 2 +- buildset-config/nightly-multilib.conf | 8 +++---- buildset-config/nightly-ppc.conf | 2 +- buildset-config/nightly-qa-systemd.conf | 4 ++-- buildset-config/nightly-x86-64.conf | 2 +- buildset-config/nightly-x86.conf | 2 +- .../autobuilder/buildsteps/RunSanityTests.py | 27 ++++++++++++++++------ 8 files changed, 31 insertions(+), 18 deletions(-)Stefan Stanacar (3):
RunSanityTests: add support for the new testimage class nightly-multilib,qa-systemd.conf: enable specific tests with the new
class
buildsets: run sanity tests for core-image-sato-sdk imagesbuildset-config/nightly-arm.conf | 2 +- buildset-config/nightly-mips.conf | 2 +- buildset-config/nightly-multilib.conf | 8 +++---- buildset-config/nightly-ppc.conf | 2 +- buildset-config/nightly-qa-systemd.conf | 4 ++-- buildset-config/nightly-x86-64.conf | 2 +- buildset-config/nightly-x86.conf | 2 +- .../autobuilder/buildsteps/RunSanityTests.py | 27 ++++++++++++++++------ 8 files changed, 31 insertions(+), 18 deletions(-)--
1.8.1.4
Signature · 3 lines
Elizabeth Flanagan Yocto Project Build and Release
Quoted 2 lines · Elizabeth
Merged into master and production. Thanks.
Turns out the buildtools-tarball does not have all the python modules needed, I am working this issue right now.
Sau!
Quoted 74 lines
-b
Quoted 67 lines · Stefan Stanacar
Hi Beth,
The first two patches enable the new testimage class that has just been merged in master, and it needs a real AB shakedown ;).
On my local AB one of the problems I've had were timeouts
for qemu booting (when the machine was really loaded), and I've sent a patch to increase the timeout, but
this might need a little more tweaking for the Yocto AB. Also, one more setup issue could be DISPLAY / vnc server. I've had some trouble with DISPLAY=localhost:1 that's why you'll notice
I've used DISPLAY=:1, that fixed the problem out on my machine. It has something to do with how the new class starts the runqemu script and the enviroment.The last patch has nothing to do with enabling, I just thought that we should run the sanity tests for the sdk images too given that the new class has a gcc test. It adds a few minutes to the builds, keep this one out if that's problem.
Cheers,
StefanThe following changes since commit
b26b257e16fddb7730d3b2a0c55c4b43a48ae54c:Revert "buildset-config: build core-image-sato SDK" (2013-07-02 17:10:05 -0700)are available in the git repository at:
git://mirror.rb.intel.com/git.yoctoproject.org/poky-contribstefans/yab-newsanity3for you to fetch changes up to
e15d6185251e4c6f163577c7263239936d76e5b3:buildsets: run sanity tests for core-image-sato-sdk images (2013-07-10 19:07:27 +0300)
----------------------------------------------------------------
Stefan Stanacar (3):
RunSanityTests: add support for the new testimage class nightly-multilib,qa-systemd.conf: enable specific tests with the new class
buildsets: run sanity tests for core-image-sato-sdk imagesbuildset-config/nightly-arm.conf | 2 +- buildset-config/nightly-mips.conf | 2 +- buildset-config/nightly-multilib.conf | 8 +++---- buildset-config/nightly-ppc.conf | 2 +- buildset-config/nightly-qa-systemd.conf | 4 ++-- buildset-config/nightly-x86-64.conf | 2 +- buildset-config/nightly-x86.conf | 2 +- .../autobuilder/buildsteps/RunSanityTests.py | 27 ++++++++++++++++------ 8 files changed, 31 insertions(+), 18 deletions(-)Stefan Stanacar (3):
RunSanityTests: add support for the new testimage class nightly-multilib,qa-systemd.conf: enable specific tests with the new
class
buildsets: run sanity tests for core-image-sato-sdk imagesbuildset-config/nightly-arm.conf | 2 +- buildset-config/nightly-mips.conf | 2 +- buildset-config/nightly-multilib.conf | 8 +++---- buildset-config/nightly-ppc.conf | 2 +- buildset-config/nightly-qa-systemd.conf | 4 ++-- buildset-config/nightly-x86-64.conf | 2 +- buildset-config/nightly-x86.conf | 2 +- .../autobuilder/buildsteps/RunSanityTests.py | 27 ++++++++++++++++------ 8 files changed, 31 insertions(+), 18 deletions(-)--
1.8.1.4
So, after the oe-core failure last night that was due to how we determine when to use the new testimage, this has kind of bumped up the need for the autobuilder to start using LAYERVERSION_* as a means of determinating major functionality changes.
In this example, we've essentially broken backwards compatibility for oe-core builds on the autobuilder. I put in a quick and dirty patch last night just to get it so oe-core sanity will run using the old sanity testing framework. I'm working on getting a GetLayerVersion buildstep working so we can utilize it both for the new test framework as well as to differentiate the toolchain image builds (prior to 2 we build meta-toolchain-gmae, post core-image-sato-sdk).
I should have this implemented today. I'll need some time tonight to get it on the AB and give it a bit more of a shakedown.
-b
Quoted 67 lines · Stefan Stanacar
Hi Beth,
The first two patches enable the new testimage class that has just been merged in master, and it needs a real AB shakedown ;).
On my local AB one of the problems I've had were timeouts
for qemu booting (when the machine was really loaded), and I've sent a patch to increase the timeout, but
this might need a little more tweaking for the Yocto AB. Also, one more setup issue could be DISPLAY / vnc server. I've had some trouble with DISPLAY=localhost:1 that's why you'll notice
I've used DISPLAY=:1, that fixed the problem out on my machine. It has something to do with how the new class starts the runqemu script and the enviroment.The last patch has nothing to do with enabling, I just thought that we should run the sanity tests for the sdk images too given that the new class has a gcc test. It adds a few minutes to the builds, keep this one out if that's problem.
Cheers,
StefanThe following changes since commit
b26b257e16fddb7730d3b2a0c55c4b43a48ae54c:Revert "buildset-config: build core-image-sato SDK" (2013-07-02 17:10:05 -0700)
are available in the git repository at:
git://mirror.rb.intel.com/git.yoctoproject.org/poky-contribstefans/yab-newsanity3for you to fetch changes up to
e15d6185251e4c6f163577c7263239936d76e5b3:buildsets: run sanity tests for core-image-sato-sdk images (2013-07-10 19:07:27 +0300)
----------------------------------------------------------------
Stefan Stanacar (3):
RunSanityTests: add support for the new testimage class nightly-multilib,qa-systemd.conf: enable specific tests with the new class
buildsets: run sanity tests for core-image-sato-sdk imagesbuildset-config/nightly-arm.conf | 2 +- buildset-config/nightly-mips.conf | 2 +- buildset-config/nightly-multilib.conf | 8 +++---- buildset-config/nightly-ppc.conf | 2 +- buildset-config/nightly-qa-systemd.conf | 4 ++-- buildset-config/nightly-x86-64.conf | 2 +- buildset-config/nightly-x86.conf | 2 +- .../autobuilder/buildsteps/RunSanityTests.py | 27 ++++++++++++++++------ 8 files changed, 31 insertions(+), 18 deletions(-)Stefan Stanacar (3):
RunSanityTests: add support for the new testimage class nightly-multilib,qa-systemd.conf: enable specific tests with the new
class
buildsets: run sanity tests for core-image-sato-sdk imagesbuildset-config/nightly-arm.conf | 2 +- buildset-config/nightly-mips.conf | 2 +- buildset-config/nightly-multilib.conf | 8 +++---- buildset-config/nightly-ppc.conf | 2 +- buildset-config/nightly-qa-systemd.conf | 4 ++-- buildset-config/nightly-x86-64.conf | 2 +- buildset-config/nightly-x86.conf | 2 +- .../autobuilder/buildsteps/RunSanityTests.py | 27 ++++++++++++++++------ 8 files changed, 31 insertions(+), 18 deletions(-)--
1.8.1.4
Signature · 3 lines
Elizabeth Flanagan Yocto Project Build and Release
Hi Beth,
Quoted 5 lines · Elizabeth
So, after the oe-core failure last night that was due to how we determine when to use the new testimage, this has kind of bumped up the need for the autobuilder to start using LAYERVERSION_* as a means of determinating major functionality changes.
Quoted 7 lines
In this example, we've essentially broken backwards compatibility for oe-core builds on the autobuilder. I put in a quick and dirty patch last night just to get it so oe-core sanity will run using the old sanity testing framework. I'm working on getting a GetLayerVersion buildstep working so we can utilize it both for the new test framework as well as to differentiate the toolchain image builds (prior to 2 we build meta-toolchain-gmae, post core-image-sato-sdk).
Wouldn't the simplest thing be to just check for the presence of meta/classes/testimage.bbclass?
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre
Quoted 16 lines · Paul Eggleton
Hi Beth,
Quoted 5 lines · Elizabeth
So, after the oe-core failure last night that was due to how we determine when to use the new testimage, this has kind of bumped up the need for the autobuilder to start using LAYERVERSION_* as a means of determinating major functionality changes.
Quoted 7 lines
In this example, we've essentially broken backwards compatibility for oe-core builds on the autobuilder. I put in a quick and dirty patch last night just to get it so oe-core sanity will run using the old sanity testing framework. I'm working on getting a GetLayerVersion buildstep working so we can utilize it both for the new test framework as well as to differentiate the toolchain image builds (prior to 2 we build meta-toolchain-gmae, post core-image-sato-sdk).
Quoted 2 lines
Wouldn't the simplest thing be to just check for the presence of meta/classes/testimage.bbclass?
Actually, no. What I would need to do here in buildbot land is either script out the conditional in the bash that executes (ick, kind of a pain to debug) or make an entirely new buildstep to check for the existence of that one file, set a property and then check for that property in RunSanityTesting. And that's just for sanity testing. For meta-toolchain-gmae, I'd have to have yet another way of doing it.
It's so much easier to just have a GetLayerVersion step for each layer and then:
layerversion = self.getProperty("layerversion_core") if layerversion and int(layerversion) > 1:
#do one thing
else:
#do something else.
Quoted 8 lines
Cheers,
Paul--
Paul Eggleton
Intel Open Source Technology Centre
Signature · 3 lines
Elizabeth Flanagan Yocto Project Build and Release
Quoted 26 lines · Elizabeth
Quoted 14 lines · Paul Eggleton
Quoted 5 lines · Elizabeth
So, after the oe-core failure last night that was due to how we determine when to use the new testimage, this has kind of bumped up the need for the autobuilder to start using LAYERVERSION_* as a means of determinating major functionality changes.
Quoted 7 lines
In this example, we've essentially broken backwards compatibility for oe-core builds on the autobuilder. I put in a quick and dirty patch last night just to get it so oe-core sanity will run using the old sanity testing framework. I'm working on getting a GetLayerVersion buildstep working so we can utilize it both for the new test framework as well as to differentiate the toolchain image builds (prior to 2 we build meta-toolchain-gmae, post core-image-sato-sdk).
Quoted 2 lines
Wouldn't the simplest thing be to just check for the presence of meta/classes/testimage.bbclass?
Actually, no. What I would need to do here in buildbot land is either script out the conditional in the bash that executes (ick, kind of a pain to debug) or make an entirely new buildstep to check for the existence of that one file, set a property and then check for that property in RunSanityTesting. And that's just for sanity testing. For meta-toolchain-gmae, I'd have to have yet another way of doing it.
Quoted 8 lines
It's so much easier to just have a GetLayerVersion step for each layer and then:
layerversion =
self.getProperty("layerversion_core")if layerversion and int(layerversion) > 1:
#do one thing
else:
#do something else.
OK, I can see that being easier assuming you can't just do the path check in the python code itself (and it's not clear to me if you have the path to the metadata or not at that point, based on the variable printout from a recent build). I'm still a little bit concerned about changing the meaning of LAYERVERSION, but I'm willing to admit defeat at this point in the absence of another acceptable solution.
Cheers,
Paul
Signature · 2 lines
Paul Eggleton Intel Open Source Technology Centre