Skip to contentSkip to conversation

spi: pxa2xx-pci: fix ACPI-based enumeration of SPI devices

PATCH New Jan Kiszka 2 participants 2 messages Nov 16, 2017 – Nov 22, 2017

Subsystems (3)
SPI PXA2xx/PXA3xx support Intel LPSS (Low Power SubSystem) drivers
lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH 1/1 spi: pxa2xx-pci: fix ACPI-based enumeration of SPI devices

From: Andy Shevchenko <[email protected]>

commit b70cd2de0ea85f5ab51a1d01893cba6415011b9d upstream.

Slave devices are not enumerated by ACPI data because the ACPI handle for the core driver is NULL if it was enumerated by PCI.

Propagate firmware node handle of the PCI device to the platform device.

Suggested-by Mika Westerberg <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
Signed-off-by Mark Brown <[email protected]>
Signed-off-by Jan Kiszka <[email protected]>

---

Required for our IOT2000 devices to work properly.

 drivers/spi/spi-pxa2xx-pci.c | 1 +
 1 file changed, 1 insertion(+)
drivers/spi/spi-pxa2xx-pci.c +1 -0
index d19d7f28aecb..ac0658ead1b9 100644
@@ -167,6 +167,7 @@ static int pxa2xx_spi_pci_probe(struct pci_dev *dev,
 		return PTR_ERR(ssp->clk);
 
 	memset(&pi, 0, sizeof(pi));
+	pi.fwnode = dev->dev.fwnode;
 	pi.parent = &dev->dev;
 	pi.name = "pxa2xx-spi";
 	pi.id = ssp->port_id;
Applied
#1 lore raw

PATCH 1/1 spi: pxa2xx-pci: fix ACPI-based enumeration of SPI devices

Quoted 9 lines · Jan Kiszka

From: Andy Shevchenko <[email protected]>

commit b70cd2de0ea85f5ab51a1d01893cba6415011b9d upstream.

Slave devices are not enumerated by ACPI data because the ACPI handle for the core driver is NULL if it was enumerated by PCI.

Propagate firmware node handle of the PCI device to the platform device.

Quoted 7 lines
Suggested-by Mika Westerberg <[email protected]>
Signed-off-by Andy Shevchenko <[email protected]>
Signed-off-by Mark Brown <[email protected]>
Signed-off-by Jan Kiszka <[email protected]>

---

Required for our IOT2000 devices to work properly.

[...]

Applied, thanks.

Ben.

Signature · 2 lines
Ben Hutchings
Software Developer, Codethink Ltd.