Skip to contentSkip to conversation

drm/i915/guc: Update header guard name of intel_guc_submission.h

PATCH In review Sagar Arun Kamble 5 participants 9 messages Nov 24, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/guc: Update header guard name of intel_guc_submission.h

While renaming i915_guc_submission.h to intel_guc_submission.h, update of header guard name to _INTEL_GUC_SUBMISSION_H_ was missed.

Fixes a269574489d4 (drm/i915/guc: Rename i915_guc_submission.c|h to intel_guc_submission.c|h)
Cc Joonas Lahtinen <[email protected]>
---
 drivers/gpu/drm/i915/intel_guc_submission.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_guc_submission.h +2 -2
index e901192..021fe85 100644
@@ -22,8 +22,8 @@
  *
  */
 
-#ifndef _I915_GUC_SUBMISSION_H_
-#define _I915_GUC_SUBMISSION_H_
+#ifndef _INTEL_GUC_SUBMISSION_H_
+#define _INTEL_GUC_SUBMISSION_H_
 
 #include <linux/spinlock.h>
 
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for series starting with [1/1] drm/i915/guc: Update header guard name of intel_guc_submission.h

== Series Details ==

== Series Details ==

Series: series starting with [1/1] drm/i915/guc: Update header guard name of intel_guc_submission.h
URL : https://patchwork.freedesktop.org/series/34343/
State : success

== Summary ==

Series 34343v1 series starting with [1/1] drm/i915/guc: Update header guard name of intel_guc_submission.h
https://patchwork.freedesktop.org/api/1.0/series/34343/revisions/1/mbox/

Test kms_pipe_crc_basic:

        Subgroup suspend-read-crc-pipe-c:
                incomplete -> PASS       (fi-cfl-s2) k.org#197971

k.org#197971 https://bugzilla.kernel.org/show_bug.cgi?id=197971

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:447s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:454s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:389s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:540s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:279s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:506s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:500s
fi-byt-j1900     total:289  pass:254  dwarn:0   dfail:0   fail:0   skip:35  time:501s
fi-byt-n2820     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:489s
fi-cfl-s2        total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:608s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:435s
fi-gdg-551       total:289  pass:178  dwarn:1   dfail:0   fail:1   skip:109 time:264s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:537s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:433s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:441s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:428s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:486s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:464s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:483s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:535s
fi-kbl-7567u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:479s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:531s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:582s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:474s
fi-skl-6600u     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:535s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:567s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:527s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:495s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:461s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:568s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:422s

Blacklisted hosts:
fi-glk-dsi total:289 pass:257 dwarn:0 dfail:0 fail:2 skip:30 time:505s

b407e5f38397c0c22b5056a1664753287993b152 drm-tip: 2017y-11m-23d-16h-14m-59s UTC integration manifest 86330d77a072 drm/i915/guc: Update header guard name of intel_guc_submission.h

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7273/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#2 lore raw
In reply to Sagar Arun Kamble
Quoted 4 lines · Sagar Arun Kamble

While renaming i915_guc_submission.h to intel_guc_submission.h, update of header guard name to _INTEL_GUC_SUBMISSION_H_ was missed.

Fixes a269574489d4 (drm/i915/guc: Rename i915_guc_submission.c|h to intel_guc_submission.c|h)

I guess use of "Fixes" tag here is too much as we don't fix anything real ;) Better just refer that patch in the main commit message above.

Quoted 3 lines

---

Quoted 8 lines
 drivers/gpu/drm/i915/intel_guc_submission.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_guc_submission.h +0 -0
index e901192..021fe85 100644

drivers/gpu/drm/i915/intel_guc_submission.h line 26

Quoted 7 lines
drivers/gpu/drm/i915/intel_guc_submission.h +2 -2
@@ -22,8 +22,8 @@
  *
  */
-#ifndef _I915_GUC_SUBMISSION_H_
-#define _I915_GUC_SUBMISSION_H_
+#ifndef _INTEL_GUC_SUBMISSION_H_
+#define _INTEL_GUC_SUBMISSION_H_
 #include <linux/spinlock.h>

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

Quoting Michal Wajdeczko (2017-11-24 09:32:58)

Quoted 6 lines
Quoted 3 lines · Sagar Arun Kamble

While renaming i915_guc_submission.h to intel_guc_submission.h, update of header guard name to _INTEL_GUC_SUBMISSION_H_ was missed.

Quoted 6 lines
Quoted 2 lines
Fixes a269574489d4 (drm/i915/guc: Rename i915_guc_submission.c|h to

intel_guc_submission.c|h)

I guess use of "Fixes" tag here is too much as we don't fix anything real ;)
Better just refer that patch in the main commit message above.

We came to the agreement to avoid using Fixes for patches we don't need backporting, and just s/Fixes/References/ instead.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 7 lines · Chris Wilson

Quoting Michal Wajdeczko (2017-11-24 09:32:58)

Quoted 6 lines
Quoted 3 lines · Sagar Arun Kamble

While renaming i915_guc_submission.h to intel_guc_submission.h, update of header guard name to _INTEL_GUC_SUBMISSION_H_ was missed.

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines
Fixes a269574489d4 (drm/i915/guc: Rename i915_guc_submission.c|h to

intel_guc_submission.c|h)

I guess use of "Fixes" tag here is too much as we don't fix anything real ;)
Better just refer that patch in the main commit message above.

We came to the agreement to avoid using Fixes for patches we don't need backporting, and just s/Fixes/References/ instead.

Thanks for clarification, review & merge.

Quoted 1 line

-Chris

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915/guc: Update header guard name of intel_guc_submission.h

In reply to Sagar Arun Kamble
== Series Details ==

== Series Details ==

Series: series starting with [1/1] drm/i915/guc: Update header guard name of intel_guc_submission.h
URL : https://patchwork.freedesktop.org/series/34343/
State : success

== Summary ==

Test drv_module_reload:

        Subgroup basic-no-display:
                pass       -> DMESG-WARN (shard-hsw) fdo#102707
Test drv_selftest:
        Subgroup mock_sanitycheck:
                pass       -> DMESG-WARN (shard-snb) fdo#103717
Test kms_frontbuffer_tracking:
        Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
                pass       -> FAIL       (shard-snb) fdo#101623
Test perf:
        Subgroup polling:
                fail       -> PASS       (shard-hsw) fdo#102252
Test kms_flip:
        Subgroup plain-flip-ts-check-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#100368

fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#103717 https://bugs.freedesktop.org/show_bug.cgi?id=103717
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368

shard-hsw        total:2667 pass:1533 dwarn:2   dfail:0   fail:11  skip:1121 time:9523s
shard-snb        total:2667 pass:1311 dwarn:2   dfail:0   fail:13  skip:1341 time:8079s
Blacklisted hosts:
shard-apl        total:2667 pass:1688 dwarn:1   dfail:0   fail:24  skip:954 time:13619s
shard-kbl        total:2597 pass:1714 dwarn:24  dfail:0   fail:24  skip:834 time:10333s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7273/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: ✓ Fi.CI.IGT: success for series starting with [1/1] drm/i915/guc: Update header guard name of intel_guc_submission.h

Quoting Patchwork (2017-11-24 10:18:40)

Quoted 5 lines

== Series Details ==

Series: series starting with [1/1] drm/i915/guc: Update header guard name of intel_guc_submission.h
URL : https://patchwork.freedesktop.org/series/34343/
State : success

And pushed, thanks for the fixup and review,
-Chris
(apologies if I reply twice)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#7 lore raw
In reply to Sagar Arun Kamble
Quoted 4 lines · Sagar Arun Kamble

While renaming i915_guc_submission.h to intel_guc_submission.h, update of header guard name to _INTEL_GUC_SUBMISSION_H_ was missed.

Fixes a269574489d4 (drm/i915/guc: Rename i915_guc_submission.c|h to intel_guc_submission.c|h)

+ Jani

There was lately a request from Jani to not to include "Fixes:" for purely stylistical fixes. So if there's no actual functional impact, no "Fixes:".

I'm still unsure if we have alternative markup agreed upon?

Regards, Joonas

Quoted 21 lines
---
 drivers/gpu/drm/i915/intel_guc_submission.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_guc_submission.h +2 -2
index e901192..021fe85 100644
@@ -22,8 +22,8 @@
  *
  */
 
-#ifndef _I915_GUC_SUBMISSION_H_
-#define _I915_GUC_SUBMISSION_H_
+#ifndef _INTEL_GUC_SUBMISSION_H_
+#define _INTEL_GUC_SUBMISSION_H_
 
 #include <linux/spinlock.h>
 
Signature · 7 lines
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw
Quoted 4 lines · Joonas Lahtinen
Quoted 3 lines · Sagar Arun Kamble

While renaming i915_guc_submission.h to intel_guc_submission.h, update of header guard name to _INTEL_GUC_SUBMISSION_H_ was missed.

Quoted 8 lines
Quoted 1 line
Fixes a269574489d4 (drm/i915/guc: Rename i915_guc_submission.c|h to intel_guc_submission.c|h)

+ Jani

There was lately a request from Jani to not to include "Fixes:" for purely stylistical fixes. So if there's no actual functional impact, no "Fixes:".

I'm still unsure if we have alternative markup agreed upon?

Chris suggested use of "References" here.

Quoted 17 lines

Regards, Joonas

Quoted 14 lines
---
  drivers/gpu/drm/i915/intel_guc_submission.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_guc_submission.h +0 -0
index e901192..021fe85 100644
@@ -22,8 +22,8 @@
   *
   */
 
Quoted 7 lines

drivers/gpu/drm/i915/intel_guc_submission.h line 29

Quoted 7 lines
drivers/gpu/drm/i915/intel_guc_submission.h +2 -2
-#ifndef _I915_GUC_SUBMISSION_H_
-#define _I915_GUC_SUBMISSION_H_
+#ifndef _INTEL_GUC_SUBMISSION_H_
+#define _INTEL_GUC_SUBMISSION_H_
 
  #include <linux/spinlock.h>
 

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx