Skip to contentSkip to conversation

Patch "NFC: fix device-allocation error return" has been added to the 3.18-stable tree

PATCH [email protected] 1 participant 1 message Nov 27, 2017

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

NFC: fix device-allocation error return

to the 3.18-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
nfc-fix-device-allocation-error-return.patch
and it can be found in the queue-3.18 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From c45e3e4c5b134b081e8af362109905427967eb19 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Sun, 9 Jul 2017 13:08:58 +0200
Subject: NFC: fix device-allocation error return

From: Johan Hovold <[email protected]>

commit c45e3e4c5b134b081e8af362109905427967eb19 upstream.

A recent change fixing NFC device allocation itself introduced an error-handling bug by returning an error pointer in case device-id allocation failed. This is clearly broken as the callers still expected NULL to be returned on errors as detected by Dan's static checker.

Fix this up by returning NULL in the event that we've run out of memory when allocating a new device id.

Note that the offending commit is marked for stable (3.8) so this fix needs to be backported along with it.

Fixes 20777bc57c34 ("NFC: fix broken device allocation")
---
 net/nfc/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/nfc/core.c +1 -1
@@ -1074,7 +1074,7 @@ struct nfc_dev *nfc_allocate_device(stru
 err_free_dev:
 	kfree(dev);
 
-	return ERR_PTR(rc);
+	return NULL;
 }
 EXPORT_SYMBOL(nfc_allocate_device);
 

Patches currently in stable-queue which might be from [email protected] are

queue-3.18/clk-ti-dra7-atl-clock-fix-child-node-lookups.patch queue-3.18/nfc-fix-device-allocation-error-return.patch