Patch "ASoC: rsnd: don't double free kctrl" has been added to the 4.9-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
ASoC: rsnd: don't double free kctrl
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
asoc-rsnd-don-t-double-free-kctrl.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Nov 28 10:49:28 CET 2017
From: Colin Ian King <[email protected]>
Date: Thu, 8 Dec 2016 13:05:43 +0000
Subject: ASoC: rsnd: don't double free kctrl
From: Colin Ian King <[email protected]>
[ Upstream commit 0ea617a298dcdc2251b4e10f83ac3f3e627b66e3 ]
On an error, snd_ctl_add already free's kctrl, so calling snd_ctl_free_one to free it again leads to a double free error. Fix this by removing the extraneous snd_ctl_free_one call.
Issue found using static analysis with CoverityScan, CID 1372908
--- sound/soc/sh/rcar/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
sound/soc/sh/rcar/core.c +1 -3
@@ -978,10 +978,8 @@ static int __rsnd_kctrl_new(struct rsnd_return -ENOMEM ; ret =snd_ctl_add (card, kctrl); -if (ret <0 ) { -snd_ctl_free_one (kctrl); +if (ret <0 )return ret; - } cfg->update = update; cfg->card = card;
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/asoc-rsnd-don-t-double-free-kctrl.patch