Skip to contentSkip to conversation

DCA: Use PTR_ERR_OR_ZERO()

PATCH New Vasyl Gomonovych 1 participant 1 message Nov 28, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DCA: Use PTR_ERR_OR_ZERO()

Fix ptr_ret.cocci warnings:
drivers/dca/dca-sysfs.c:43:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

---
 drivers/dca/dca-sysfs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/dca/dca-sysfs.c +1 -3
index 126cf295b198..b2f8be048089 100644
@@ -40,9 +40,7 @@ int dca_sysfs_add_req(struct dca_provider *dca, struct device *dev, int slot)
 
 	cd = device_create(dca_class, dca->cd, MKDEV(0, slot + 1), NULL,
 			   "requester%d", req_count++);
-	if (IS_ERR(cd))
-		return PTR_ERR(cd);
-	return 0;
+	return PTR_ERR_OR_ZERO(cd);
 }
 
 void dca_sysfs_remove_req(struct dca_provider *dca, int slot)
Signature · 1 line
1.9.1