firmware: Use PTR_ERR_OR_ZERO()
PATCH 1/1 firmware: Use PTR_ERR_OR_ZERO()
Fix ptr_ret.cocci warnings:
drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Signed-off-by Vasyl Gomonovych <[email protected]>
--- drivers/firmware/qemu_fw_cfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/firmware/qemu_fw_cfg.c +1 -3
@@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const struct kernel_param *kp)*/ fw_cfg_cmdline_dev =platform_device_register_simple ("fw_cfg" ,PLATFORM_DEVID_NONE , res, processed); -if (IS_ERR (fw_cfg_cmdline_dev)) -return PTR_ERR (fw_cfg_cmdline_dev); -return 0 ; +return PTR_ERR_OR_ZERO (fw_cfg_cmdline_dev); }static int fw_cfg_cmdline_get (char *buf,const struct kernel_param *kp)
Signature · 1 line
1.9.1
Acked-by Gabriel Somlo <[email protected]>
Quoted 31 lines · Vasyl Gomonovych
Fix
ptr_ret.cocciwarnings:
drivers/firmware/efi/efi.c:610:8-14: WARNING:PTR_ERR_OR_ZEROcan be usedUse
PTR_ERR_OR_ZEROrather than if(IS_ERR(...)) +PTR_ERRGenerated by:
scripts/coccinelle/api/ptr_ret.cocciSigned-off-by Vasyl Gomonovych <[email protected]>--- drivers/firmware/qemu_fw_cfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/firmware/qemu_fw_cfg.c +1
-3@@ -693,10 +693,8 @@ static int fw_cfg_cmdline_set(const char *arg, const struct kernel_param *kp)*/ fw_cfg_cmdline_dev =platform_device_register_simple ("fw_cfg" ,PLATFORM_DEVID_NONE , res, processed); -if (IS_ERR (fw_cfg_cmdline_dev)) -return PTR_ERR (fw_cfg_cmdline_dev); -return 0 ; +return PTR_ERR_OR_ZERO (fw_cfg_cmdline_dev); }static int fw_cfg_cmdline_get (char *buf,const struct kernel_param *kp)Signature · 1 line
1.9.1
Quoted 11 lines · Vasyl Gomonovych
Fix
ptr_ret.cocciwarnings:
drivers/firmware/efi/efi.c:610:8-14: WARNING:PTR_ERR_OR_ZEROcan be usedUse
PTR_ERR_OR_ZEROrather than if(IS_ERR(...)) +PTR_ERRGenerated by:
scripts/coccinelle/api/ptr_ret.cocciSigned-off-by Vasyl Gomonovych <[email protected]>--- drivers/firmware/qemu_fw_cfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by Stefan Hajnoczi <[email protected]>