Skip to contentSkip to conversation

Patch "platform/x86: hp-wmi: Fix tablet mode detection for convertibles" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Nov 30, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

platform/x86: hp-wmi: Fix tablet mode detection for convertibles

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
platform-x86-hp-wmi-fix-tablet-mode-detection-for-convertibles.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 9968e12a291e639dd51d1218b694d440b22a917f Mon Sep 17 00:00:00 2001

From: =?UTF-8?q?Stefan=20Br=C3=BCns?= <[email protected]>
Date: Fri, 3 Nov 2017 03:01:53 +0100
Subject: platform/x86: hp-wmi: Fix tablet mode detection for convertibles
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From: Stefan Brüns <[email protected]>

commit 9968e12a291e639dd51d1218b694d440b22a917f upstream.

Commit f9cf3b2880cc ("platform/x86: hp-wmi: Refactor dock and tablet state fetchers") consolidated the methods for docking and laptop mode detection, but omitted to apply the correct mask for the laptop mode (it always uses the constant for docking).

Fixes f9cf3b2880cc ("platform/x86: hp-wmi: Refactor dock and tablet state fetchers")
Cc Michel Dänzer <[email protected]>
---
 drivers/platform/x86/hp-wmi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/hp-wmi.c +1 -1
@@ -297,7 +297,7 @@ static int hp_wmi_hw_state(int mask)
 	if (state < 0)
 		return state;
 
-	return state & 0x1;
+	return !!(state & mask);
 }
 
 static int __init hp_wmi_bios_2008_later(void)

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/platform-x86-hp-wmi-fix-tablet-mode-detection-for-convertibles.patch