ARM: dts: imx51-ts4800: Fix syscon and touschscreen nodes
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/12 ARM: dts: imx51-ts4800: Fix syscon and touschscreen nodes
From: Fabio Estevam <[email protected]>
The syscon node has an incorrect notation for its unit address and the wdt node has an unneeded unit address.
Fix them so that the following build warnings with W=1 are gone:
arch/arm/boot/dts/imx51-ts4800.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name arch/arm/boot/dts/imx51-ts4800.dtb: Warning (unit_address_vs_reg): Node /soc/aips at 80000000/weim at 83fda000/fpga at 0/syscon at b0010000/wdt at e has a unit name, but no reg property arch/arm/boot/dts/imx51-ts4800.dtb: Warning (unit_address_vs_reg): Node /soc/aips at 80000000/weim at 83fda000/fpga at 0/touchscreen has a reg or ranges property, but no unit name arch/arm/boot/dts/imx51-ts4800.dtb: Warning (simple_bus_reg): Node /soc/aips at 80000000/weim at 83fda000/fpga at 0/syscon at b0010000 simple-bus unit address format error, expected "10000" arch/arm/boot/dts/imx51-ts4800.dtb: Warning (simple_bus_reg): Node /soc/aips at 80000000/weim at 83fda000/fpga at 0/touchscreen simple-bus unit address format error, expected "12000"
--- arch/arm/boot/dts/imx51-ts4800.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/boot/dts/imx51-ts4800.dts +3 -3
@@ -149,18 +149,18 @@ #size-cells = <1>; ranges = <0 0 0 0x1d000>; - syscon: syscon at b0010000 { + syscon: syscon at 10000 { compatible = "syscon", "simple-mfd"; reg = <0x10000 0x3d>; reg-io-width = <2>; - wdt at e { + wdt { compatible = "technologic,ts4800-wdt"; syscon = <&syscon 0xe>; }; }; - touchscreen { + touchscreen at 12000 { compatible = "technologic,ts4800-ts"; reg = <0x12000 0x1000>; syscon = <&syscon 0x10 6>;
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 2/12 ARM: dts: imx51-zii-rdu1: Add the unit addresses in sysled
From: Fabio Estevam <[email protected]>
As described at Documentation/devicetree/bindings/mfd/mc13xxx.txt the reg property is mandatory, so add the corresponding unit address in order to fix the following build warnings with W=1:
arch/arm/boot/dts/imx51-zii-rdu1.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit namearch/arm/boot/dts/imx51-zii-rdu1.dtb: Warning (unit_address_vs_reg): Node /soc/aips at 70000000/spba at 70000000/ecspi at 70010000/pmic at 0/leds/sysled0 has a reg or ranges property, but no unit name arch/arm/boot/dts/imx51-zii-rdu1.dtb: Warning (unit_address_vs_reg): Node /soc/aips at 70000000/spba at 70000000/ecspi at 70010000/pmic at 0/leds/sysled1 has a reg or ranges property, but no unit name
--- arch/arm/boot/dts/imx51-zii-rdu1.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx51-zii-rdu1.dts +2 -2
@@ -428,13 +428,13 @@ #size-cells = <0>; led-control = <0x0 0x0 0x3f83f8 0x0>; - sysled0 { + sysled0 at 3 { reg = <3>; label = "system:green:status"; linux,default-trigger = "default-on"; }; - sysled1 { + sysled1 at 4 { reg = <4>; label = "system:green:act"; linux,default-trigger = "heartbeat";
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 3/12 ARM: dts: imx53-m53: Remove unneeded reg property
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
As described in Documentation/devicetree/bindings/input/touchscreen/stmpe.txt there is no 'reg' property under stmpe_touchscreen, so remove it to fix the following build warning with W=1:
arch/arm/boot/dts/imx53-m53evk.dtb: Warning (unit_address_vs_reg): Node /soc/aips at 60000000/i2c at 63fc4000/stmpe610 at 41/stmpe_touchscreen has a reg or ranges property, but no unit name
--- arch/arm/boot/dts/imx53-m53.dtsi | 1 - 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx53-m53.dtsi +0 -1
@@ -64,7 +64,6 @@ stmpe_touchscreen { compatible = "st,stmpe-ts"; - reg = <0>; st,sample-time = <4>; st,mod-12b = <1>; st,ref-sel = <0>;
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 4/12 ARM: dts: imx53-tx53-x03x: Move display node out of 'soc'
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Move disp0 node from soc node to root node.
disp0 node does not have any register properties and thus shouldn't be placed on the bus.
This fixes the following build warnings with W=1:
arch/arm/boot/dts/imx53-tx53-x03x.dtb: Warning (simple_bus_reg): Node /soc/disp0 missing or empty reg/ranges property
--- arch/arm/boot/dts/imx53-tx53-x03x.dts | 232 +++++++++++++++++----------------- 1 file changed, 115 insertions(+), 117 deletions(-)
arch/arm/boot/dts/imx53-tx53-x03x.dts +115 -117
@@ -53,132 +53,130 @@ display = &display; }; - soc { - display: disp0 { - compatible = "fsl,imx-parallel-display"; - interface-pix-fmt = "rgb24"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_rgb24_vga1>; - status = "okay"; + display: disp0 { + compatible = "fsl,imx-parallel-display"; + interface-pix-fmt = "rgb24"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rgb24_vga1>; + status = "okay"; - port { - display0_in: endpoint { - remote-endpoint = <&ipu_di0_disp0>; - }; + port { + display0_in: endpoint { + remote-endpoint = <&ipu_di0_disp0>; }; + }; - display-timings { - VGA { - clock-frequency = <25200000>; - hactive = <640>; - vactive = <480>; - hback-porch = <48>; - hsync-len = <96>; - hfront-porch = <16>; - vback-porch = <31>; - vsync-len = <2>; - vfront-porch = <12>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + display-timings { + VGA { + clock-frequency = <25200000>; + hactive = <640>; + vactive = <480>; + hback-porch = <48>; + hsync-len = <96>; + hfront-porch = <16>; + vback-porch = <31>; + vsync-len = <2>; + vfront-porch = <12>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ETV570 { - clock-frequency = <25200000>; - hactive = <640>; - vactive = <480>; - hback-porch = <114>; - hsync-len = <30>; - hfront-porch = <16>; - vback-porch = <32>; - vsync-len = <3>; - vfront-porch = <10>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ETV570 { + clock-frequency = <25200000>; + hactive = <640>; + vactive = <480>; + hback-porch = <114>; + hsync-len = <30>; + hfront-porch = <16>; + vback-porch = <32>; + vsync-len = <3>; + vfront-porch = <10>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ET0350 { - clock-frequency = <6413760>; - hactive = <320>; - vactive = <240>; - hback-porch = <34>; - hsync-len = <34>; - hfront-porch = <20>; - vback-porch = <15>; - vsync-len = <3>; - vfront-porch = <4>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ET0350 { + clock-frequency = <6413760>; + hactive = <320>; + vactive = <240>; + hback-porch = <34>; + hsync-len = <34>; + hfront-porch = <20>; + vback-porch = <15>; + vsync-len = <3>; + vfront-porch = <4>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ET0430 { - clock-frequency = <9009000>; - hactive = <480>; - vactive = <272>; - hback-porch = <2>; - hsync-len = <41>; - hfront-porch = <2>; - vback-porch = <2>; - vsync-len = <10>; - vfront-porch = <2>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <1>; - }; + ET0430 { + clock-frequency = <9009000>; + hactive = <480>; + vactive = <272>; + hback-porch = <2>; + hsync-len = <41>; + hfront-porch = <2>; + vback-porch = <2>; + vsync-len = <10>; + vfront-porch = <2>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <1>; + }; - ET0500 { - clock-frequency = <33264000>; - hactive = <800>; - vactive = <480>; - hback-porch = <88>; - hsync-len = <128>; - hfront-porch = <40>; - vback-porch = <33>; - vsync-len = <2>; - vfront-porch = <10>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ET0500 { + clock-frequency = <33264000>; + hactive = <800>; + vactive = <480>; + hback-porch = <88>; + hsync-len = <128>; + hfront-porch = <40>; + vback-porch = <33>; + vsync-len = <2>; + vfront-porch = <10>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ET0700 { /* same as ET0500 */ - clock-frequency = <33264000>; - hactive = <800>; - vactive = <480>; - hback-porch = <88>; - hsync-len = <128>; - hfront-porch = <40>; - vback-porch = <33>; - vsync-len = <2>; - vfront-porch = <10>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ET0700 { /* same as ET0500 */ + clock-frequency = <33264000>; + hactive = <800>; + vactive = <480>; + hback-porch = <88>; + hsync-len = <128>; + hfront-porch = <40>; + vback-porch = <33>; + vsync-len = <2>; + vfront-porch = <10>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ETQ570 { - clock-frequency = <6596040>; - hactive = <320>; - vactive = <240>; - hback-porch = <38>; - hsync-len = <30>; - hfront-porch = <30>; - vback-porch = <16>; - vsync-len = <3>; - vfront-porch = <4>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ETQ570 { + clock-frequency = <6596040>; + hactive = <320>; + vactive = <240>; + hback-porch = <38>; + hsync-len = <30>; + hfront-porch = <30>; + vback-porch = <16>; + vsync-len = <3>; + vfront-porch = <4>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; }; }; };
Signature · 1 line
2.7.4
PATCH 4/12 ARM: dts: imx53-tx53-x03x: Move display node out of 'soc'
Hi,
Quoted 259 lines · On Fri, 1 Dec 2017 17:24:37 -0200 Fabio Estevam wrote:
From: Fabio Estevam <[email protected]>
Move disp0 node from soc node to root node.
disp0 node does not have any register properties and thus shouldn't be placed on the bus.
This fixes the following build warnings with W=1:
arch/arm/boot/dts/imx53-tx53-x03x.dtb: Warning (simple_bus_reg): Node /soc/disp0 missing or empty reg/ranges propertyCc Lothar Wa?mann <[email protected]>Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx53-tx53-x03x.dts | 232 +++++++++++++++++----------------- 1 file changed, 115 insertions(+), 117 deletions(-)arch/arm/boot/dts/imx53-tx53-x03x.dts +108
-117@@ -53,132 +53,130 @@ display = &display; }; - soc { - display: disp0 { - compatible = "fsl,imx-parallel-display"; - interface-pix-fmt = "rgb24"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_rgb24_vga1>; - status = "okay"; + display: disp0 { + compatible = "fsl,imx-parallel-display"; + interface-pix-fmt = "rgb24"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rgb24_vga1>; + status = "okay"; - port { - display0_in: endpoint { - remote-endpoint = <&ipu_di0_disp0>; - }; + port { + display0_in: endpoint { + remote-endpoint = <&ipu_di0_disp0>; }; + }; - display-timings { - VGA { - clock-frequency = <25200000>; - hactive = <640>; - vactive = <480>; - hback-porch = <48>; - hsync-len = <96>; - hfront-porch = <16>; - vback-porch = <31>; - vsync-len = <2>; - vfront-porch = <12>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + display-timings { + VGA { + clock-frequency = <25200000>; + hactive = <640>; + vactive = <480>; + hback-porch = <48>; + hsync-len = <96>; + hfront-porch = <16>; + vback-porch = <31>; + vsync-len = <2>; + vfront-porch = <12>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ETV570 { - clock-frequency = <25200000>; - hactive = <640>; - vactive = <480>; - hback-porch = <114>; - hsync-len = <30>; - hfront-porch = <16>; - vback-porch = <32>; - vsync-len = <3>; - vfront-porch = <10>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ETV570 { + clock-frequency = <25200000>; + hactive = <640>; + vactive = <480>; + hback-porch = <114>; + hsync-len = <30>; + hfront-porch = <16>; + vback-porch = <32>; + vsync-len = <3>; + vfront-porch = <10>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ET0350 { - clock-frequency = <6413760>; - hactive = <320>; - vactive = <240>; - hback-porch = <34>; - hsync-len = <34>; - hfront-porch = <20>; - vback-porch = <15>; - vsync-len = <3>; - vfront-porch = <4>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ET0350 { + clock-frequency = <6413760>; + hactive = <320>; + vactive = <240>; + hback-porch = <34>; + hsync-len = <34>; + hfront-porch = <20>; + vback-porch = <15>; + vsync-len = <3>; + vfront-porch = <4>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ET0430 { - clock-frequency = <9009000>; - hactive = <480>; - vactive = <272>; - hback-porch = <2>; - hsync-len = <41>; - hfront-porch = <2>; - vback-porch = <2>; - vsync-len = <10>; - vfront-porch = <2>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <1>; - }; + ET0430 { + clock-frequency = <9009000>; + hactive = <480>; + vactive = <272>; + hback-porch = <2>; + hsync-len = <41>; + hfront-porch = <2>; + vback-porch = <2>; + vsync-len = <10>; + vfront-porch = <2>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <1>; + }; - ET0500 { - clock-frequency = <33264000>; - hactive = <800>; - vactive = <480>; - hback-porch = <88>; - hsync-len = <128>; - hfront-porch = <40>; - vback-porch = <33>; - vsync-len = <2>; - vfront-porch = <10>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ET0500 { + clock-frequency = <33264000>; + hactive = <800>; + vactive = <480>; + hback-porch = <88>; + hsync-len = <128>; + hfront-porch = <40>; + vback-porch = <33>; + vsync-len = <2>; + vfront-porch = <10>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ET0700 { /* same as ET0500 */ - clock-frequency = <33264000>; - hactive = <800>; - vactive = <480>; - hback-porch = <88>; - hsync-len = <128>; - hfront-porch = <40>; - vback-porch = <33>; - vsync-len = <2>; - vfront-porch = <10>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ET0700 { /* same as ET0500 */ + clock-frequency = <33264000>; + hactive = <800>; + vactive = <480>; + hback-porch = <88>; + hsync-len = <128>; + hfront-porch = <40>; + vback-porch = <33>; + vsync-len = <2>; + vfront-porch = <10>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; + }; - ETQ570 { - clock-frequency = <6596040>; - hactive = <320>; - vactive = <240>; - hback-porch = <38>; - hsync-len = <30>; - hfront-porch = <30>; - vback-porch = <16>; - vsync-len = <3>; - vfront-porch = <4>; - hsync-active = <0>; - vsync-active = <0>; - de-active = <1>; - pixelclk-active = <0>; - }; + ETQ570 { + clock-frequency = <6596040>; + hactive = <320>; + vactive = <240>; + hback-porch = <38>; + hsync-len = <30>; + hfront-porch = <30>;
arch/arm/boot/dts/imx53-tx53-x03x.dts line 182
Quoted 10 lines
arch/arm/boot/dts/imx53-tx53-x03x.dts +7
-0+ vback-porch = <16>; + vsync-len = <3>; + vfront-porch = <4>; + hsync-active = <0>; + vsync-active = <0>; + de-active = <1>; + pixelclk-active = <0>; }; }; };
Lothar Wa?mann
Fabio Estevam
reviewerPATCH 5/12 ARM: dts: imx6qdl-apf6dev: Move regulators out of simple-bus
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
It is not recommended to place regulator nodes inside simple-bus, so move them out in order to fix the following build warnings with W=1:
arch/arm/boot/dts/imx6dl-apf6dev.dtb: Warning (simple_bus_reg): Node /regulators/3p3v missing or empty reg/ranges property arch/arm/boot/dts/imx6dl-apf6dev.dtb: Warning (simple_bus_reg): Node /regulators/usb-h1-vbus missing or empty reg/ranges property arch/arm/boot/dts/imx6dl-apf6dev.dtb: Warning (simple_bus_reg): Node /regulators/usb-otg-vbus missing or empty reg/ranges property
--- arch/arm/boot/dts/imx6qdl-apf6dev.dtsi | 44 ++++++++++++++++------------------ 1 file changed, 20 insertions(+), 24 deletions(-)
arch/arm/boot/dts/imx6qdl-apf6dev.dtsi +20 -24
@@ -111,32 +111,28 @@ }; }; - regulators { - compatible = "simple-bus"; - - reg_3p3v: 3p3v { - compatible = "regulator-fixed"; - regulator-name = "3P3V"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-always-on; - }; + reg_3p3v: regulator-3p3v { + compatible = "regulator-fixed"; + regulator-name = "3P3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; - reg_usbh1_vbus: usb-h1-vbus { - compatible = "regulator-fixed"; - regulator-name = "usb_h1_vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - regulator-always-on; - }; + reg_usbh1_vbus: regulator-usb-h1-vbus { + compatible = "regulator-fixed"; + regulator-name = "usb_h1_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; - reg_usb_otg_vbus: usb-otg-vbus { - compatible = "regulator-fixed"; - regulator-name = "usb_otg_vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - regulator-always-on; - }; + reg_usb_otg_vbus: regulator-usb-otg-vbus { + compatible = "regulator-fixed"; + regulator-name = "usb_otg_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; }; sound {
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 6/12 ARM: dts: imx6qdl-aristainetos: Move regulators out of simple-bus
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
It is not recommended to place regulator nodes inside simple-bus, so move them out in order to fix the following build warnings with W=1:
arch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name arch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /regulators/regulator at 0 has a unit name, but no reg property arch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /regulators/regulator at 1 has a unit name, but no reg property arch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /regulators/regulator at 2 has a unit name, but no reg property arch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /regulators/regulator at 3 has a unit name, but no reg property
--- arch/arm/boot/dts/imx6qdl-aristainetos.dtsi | 73 +++++++++++++------------- arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi | 76 +++++++++++++--------------- 2 files changed, 70 insertions(+), 79 deletions(-)
arch/arm/boot/dts/imx6qdl-aristainetos.dtsi +34 -39
@@ -12,48 +12,43 @@ #include <dt-bindings/gpio/gpio.h> / { - regulators { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - - reg_2p5v: regulator at 0 { - compatible = "regulator-fixed"; - regulator-name = "2P5V"; - regulator-min-microvolt = <2500000>; - regulator-max-microvolt = <2500000>; - regulator-always-on; - }; - reg_3p3v: regulator at 1 { - compatible = "regulator-fixed"; - regulator-name = "3P3V"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - regulator-always-on; - }; + reg_2p5v: regulator-2p5v { + compatible = "regulator-fixed"; + regulator-name = "2P5V"; + regulator-min-microvolt = <2500000>; + regulator-max-microvolt = <2500000>; + regulator-always-on; + }; - reg_usbh1_vbus: regulator at 2 { - compatible = "regulator-fixed"; - enable-active-high; - gpio = <&gpio3 31 GPIO_ACTIVE_HIGH>; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_aristainetos_usbh1_vbus>; - regulator-name = "usb_h1_vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - }; + reg_3p3v: regulator-3p3v { + compatible = "regulator-fixed"; + regulator-name = "3P3V"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; - reg_usbotg_vbus: regulator at 3 { - compatible = "regulator-fixed"; - enable-active-high; - gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_aristainetos_usbotg_vbus>; - regulator-name = "usb_otg_vbus"; - regulator-min-microvolt = <5000000>; - regulator-max-microvolt = <5000000>; - }; + reg_usbh1_vbus: regulator-usbh1-vbus { + compatible = "regulator-fixed"; + enable-active-high; + gpio = <&gpio3 31 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_aristainetos_usbh1_vbus>; + regulator-name = "usb_h1_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + }; + + reg_usbotg_vbus: regulator-usbotg-vbus { + compatible = "regulator-fixed"; + enable-active-high; + gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_aristainetos_usbotg_vbus>; + regulator-name = "usb_otg_vbus"; + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; }; };
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi +36 -40
82 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH 6/12 ARM: dts: imx6qdl-aristainetos: Move regulators out of simple-bus
Hello fabio,
Am 01.12.2017 um 20:24 schrieb Fabio Estevam:
Quoted 6 lines
From: Fabio Estevam <[email protected]>
It is not recommended to place regulator nodes inside simple-bus, so move them out in order to fix the following build warnings with W=1:
arch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit name
This is not fixed through this patch.
Quoted 11 lines
arch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /regulators/regulator at 0 has a unit name, but no reg propertyarch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /regulators/regulator at 1 has a unit name, but no reg propertyarch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /regulators/regulator at 2 has a unit name, but no reg propertyarch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (unit_address_vs_reg): Node /regulators/regulator at 3 has a unit name, but no reg propertyCc Heiko Schocher <[email protected]>Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx6qdl-aristainetos.dtsi | 73 +++++++++++++------------- arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi | 76 +++++++++++++--------------- 2 files changed, 70 insertions(+), 79 deletions(-)
Beside of the nitpick, Thanks for fixing!
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
Fabio Estevam
reviewerPATCH 7/12 ARM: dts: imx6qdl-aristainetos: Move display node out of 'soc'
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Move disp0 node from soc node to root node.
disp0 node does not have any register properties and thus shouldn't be placed on the bus.
This fixes the following build warnings with W=1:
arch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (simple_bus_reg): Node /soc/disp0 missing or empty reg/ranges property
--- arch/arm/boot/dts/imx6dl-aristainetos_4.dts | 50 ++++++++++++++--------------- arch/arm/boot/dts/imx6dl-aristainetos_7.dts | 48 +++++++++++++-------------- 2 files changed, 47 insertions(+), 51 deletions(-)
arch/arm/boot/dts/imx6dl-aristainetos_4.dts +24 -26
@@ -31,35 +31,33 @@ reg = <0x10000000 0x40000000>; }; - soc { - display0: disp0 { - compatible = "fsl,imx-parallel-display"; - interface-pix-fmt = "rgb24"; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_ipu_disp>; - status = "okay"; + display0: disp0 { + compatible = "fsl,imx-parallel-display"; + interface-pix-fmt = "rgb24"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ipu_disp>; + status = "okay"; - display-timings { - 480x800p60 { - native-mode; - clock-frequency = <30000000>; - hactive = <480>; - vactive = <800>; - hfront-porch = <59>; - hback-porch = <10>; - hsync-len = <10>; - vback-porch = <15>; - vfront-porch = <15>; - vsync-len = <15>; - hsync-active = <1>; - vsync-active = <1>; - }; + display-timings { + 480x800p60 { + native-mode; + clock-frequency = <30000000>; + hactive = <480>; + vactive = <800>; + hfront-porch = <59>; + hback-porch = <10>; + hsync-len = <10>; + vback-porch = <15>; + vfront-porch = <15>; + vsync-len = <15>; + hsync-active = <1>; + vsync-active = <1>; }; + }; - port { - display0_in: endpoint { - remote-endpoint = <&ipu1_di0_disp0>; - }; + port { + display0_in: endpoint { + remote-endpoint = <&ipu1_di0_disp0>; }; }; };
arch/arm/boot/dts/imx6dl-aristainetos_7.dts +23 -25
57 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH 7/12 ARM: dts: imx6qdl-aristainetos: Move display node out of 'soc'
Hello Fabio,
Am 01.12.2017 um 20:24 schrieb Fabio Estevam:
Quoted 9 lines
From: Fabio Estevam <[email protected]>
Move disp0 node from soc node to root node.
disp0 node does not have any register properties and thus shouldn't be placed on the bus.
This fixes the following build warnings with W=1:
Quoted 8 lines
arch/arm/boot/dts/imx6dl-aristainetos_4.dtb: Warning (simple_bus_reg): Node /soc/disp0 missing or empty reg/ranges propertyCc Heiko Schocher <[email protected]>Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx6dl-aristainetos_4.dts | 50 ++++++++++++++--------------- arch/arm/boot/dts/imx6dl-aristainetos_7.dts | 48 +++++++++++++-------------- 2 files changed, 47 insertions(+), 51 deletions(-)
Thanks for fixing!
bye,
Heiko
Signature · 3 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
Fabio Estevam
reviewerPATCH 8/12 ARM: dts: imx6qdl-apalis: Remove unneeded reg property
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
As described in Documentation/devicetree/bindings/input/touchscreen/stmpe.txt there is no 'reg' property under stmpe_touchscreen, so remove it to fix the following build warning with W=1:
arch/arm/boot/dts/imx6q-apalis-eval.dtb: Warning (unit_address_vs_reg): Node /soc/aips-bus at 2100000/i2c at 21a4000/stmpe811 at 41/stmpe_touchscreen has a reg or ranges property, but no unit name
--- arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 - 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx6qdl-apalis.dtsi +0 -1
@@ -338,7 +338,6 @@ stmpe_touchscreen { compatible = "st,stmpe-ts"; - reg = <0>; /* 3.25 MHz ADC clock speed */ st,adc-freq = <1>; /* 8 sample average control */
Signature · 1 line
2.7.4
PATCH 8/12 ARM: dts: imx6qdl-apalis: Remove unneeded reg property
Thanks Fabio for catching that one!
Quoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
As described in
Documentation/devicetree/bindings/input/touchscreen/stmpe.txtthere is no 'reg' property understmpe_touchscreen, so remove it to fix the following build warning with W=1:
Quoted 6 lines
arch/arm/boot/dts/imx6q-apalis-eval.dtb: Warning (unit_address_vs_reg): Node /soc/aips-bus at 2100000/i2c at 21a4000/stmpe81 1 at 41/stmpe_touchscreen has a reg or ranges property, but no unit nameCc Marcel Ziswiler <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Quoted 17 lines
--- arch/arm/boot/dts/imx6qdl-apalis.dtsi | 1 - 1 file changed, 1 deletion(-)arch/arm/boot/dts/imx6qdl-apalis.dtsi +0
-1@@ -338,7 +338,6 @@ stmpe_touchscreen { compatible = "st,stmpe-ts"; - reg = <0>; /* 3.25 MHz ADC clock speed */ st,adc-freq = <1>; /* 8 sample average control */
Fabio Estevam
reviewerPATCH 9/12 ARM: dts: imx6qdl-colibri: Remove unneeded reg property
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
As described in Documentation/devicetree/bindings/input/touchscreen/stmpe.txt there is no 'reg' property under stmpe_touchscreen, so remove it to fix the following build warning with W=1:
arch/arm/boot/dts/imx6dl-colibri-eval-v3.dtb: Warning (unit_address_vs_reg): Node /soc/aips-bus at 2100000/i2c at 21a4000/stmpe811 at 41/stmpe_touchscreen has a reg or ranges property, but no unit name
--- arch/arm/boot/dts/imx6qdl-colibri.dtsi | 1 - 1 file changed, 1 deletion(-)
arch/arm/boot/dts/imx6qdl-colibri.dtsi +0 -1
@@ -274,7 +274,6 @@ stmpe_touchscreen { compatible = "st,stmpe-ts"; - reg = <0>; /* 3.25 MHz ADC clock speed */ st,adc-freq = <1>; /* 8 sample average control */
Signature · 1 line
2.7.4
PATCH 9/12 ARM: dts: imx6qdl-colibri: Remove unneeded reg property
Quoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
As described in
Documentation/devicetree/bindings/input/touchscreen/stmpe.txtthere is no 'reg' property understmpe_touchscreen, so remove it to fix the following build warning with W=1:
Quoted 6 lines
arch/arm/boot/dts/imx6dl-colibri-eval-v3.dtb: Warning (unit_address_vs_reg): Node /soc/aips-bus at 2100000/i2c at 21a4000/stmpe81 1 at 41/stmpe_touchscreen has a reg or ranges property, but no unit nameCc Sanchayan Maity <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Quoted 17 lines
--- arch/arm/boot/dts/imx6qdl-colibri.dtsi | 1 - 1 file changed, 1 deletion(-)arch/arm/boot/dts/imx6qdl-colibri.dtsi +0
-1@@ -274,7 +274,6 @@ stmpe_touchscreen { compatible = "st,stmpe-ts"; - reg = <0>; /* 3.25 MHz ADC clock speed */ st,adc-freq = <1>; /* 8 sample average control */
Fabio Estevam
reviewerPATCH 10/12 ARM: dts: imx6q-h100: Remove unneeded unit address
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Remove the unneeded unit address for the port nodes in order to fix the following build warnings with W=1:
arch/arm/boot/dts/imx6q-h100.dtb: Warning (unit_address_vs_reg): Node /soc/aips-bus at 2100000/i2c at 21a0000/tc358743 at f/port at 0 has a unit name, but no reg property arch/arm/boot/dts/imx6q-h100.dtb: Warning (unit_address_vs_reg): Node /soc/aips-bus at 2100000/mipi at 21dc000/port at 0 has a unit name, but no reg property
--- arch/arm/boot/dts/imx6q-h100.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6q-h100.dts +2 -2
@@ -205,7 +205,7 @@ reset-gpios = <&gpio6 15 GPIO_ACTIVE_LOW>; /* IRQ has a wrong pull resistor which renders it useless */ - port at 0 { + port { tc358743_out: endpoint { remote-endpoint = <&mipi_csi2_in>; data-lanes = <1 2 3 4>;
@@ -348,7 +348,7 @@ &mipi_csi { status = "okay"; - port at 0 { + port { mipi_csi2_in: endpoint { remote-endpoint = <&tc358743_out>; data-lanes = <1 2 3 4>;
Signature · 1 line
2.7.4
Fabio Estevam
reviewerPATCH 11/12 ARM: dts: imx6qdl-nitrogen6_max: Remove unneeded unit address
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
Remove the unneeded unit address for the i2cmux nodes in order to fix the following build warnings with W=1:
arch/arm/boot/dts/imx6q-nitrogen6_max.dtb: Warning (unit_address_vs_reg): Node /i2cmux at 2 has a unit name, but no reg property arch/arm/boot/dts/imx6q-nitrogen6_max.dtb: Warning (unit_address_vs_reg): Node /i2cmux at 3 has a unit name, but no reg property
--- arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi +2 -2
@@ -172,7 +172,7 @@ }; }; - i2cmux at 2 { + i2cmux2 { compatible = "i2c-mux-gpio"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_i2c2mux>;
@@ -196,7 +196,7 @@ }; }; - i2cmux at 3 { + i2cmux3 { compatible = "i2c-mux-gpio"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_i2c3mux>;
Signature · 1 line
2.7.4
PATCH 11/12 ARM: dts: imx6qdl-nitrogen6_max: Remove unneeded unit address
Hi Fabio,
Quoted 29 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Remove the unneeded unit address for the i2cmux nodes in order to fix the following build warnings with W=1:
arch/arm/boot/dts/imx6q-nitrogen6_max.dtb: Warning (unit_address_vs_reg): Node /i2cmux at 2 has a unit name, but no reg propertyarch/arm/boot/dts/imx6q-nitrogen6_max.dtb: Warning (unit_address_vs_reg): Node /i2cmux at 3 has a unit name, but no reg propertyCc Gary Bisson <[email protected]>Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi +1
-1@@ -172,7 +172,7 @@ }; }; - i2cmux at 2 { + i2cmux2 { compatible = "i2c-mux-gpio"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_i2c2mux>;
arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi line 202
Quoted 8 lines
arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi +1
-1@@ -196,7 +196,7 @@ }; }; - i2cmux at 3 { + i2cmux3 { compatible = "i2c-mux-gpio"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_i2c3mux>;
What about naming it i2c2mux and i2c3mux so it is clearer those mux happen respectively for i2c2 and i2c3?
Then I'd rename the sub-nodes i2cXmux at Y instead of i2cX at Y currently.
Let me know your thoughts.
Regards,
Gary
Fabio Estevam
reviewerPATCH 11/12 ARM: dts: imx6qdl-nitrogen6_max: Remove unneeded unit address
Hi Gary,
Quoted 6 lines · Gary Bisson
What about naming it i2c2mux and i2c3mux so it is clearer those mux happen respectively for i2c2 and i2c3?
Then I'd rename the sub-nodes i2cXmux at Y instead of i2cX at Y currently.
Let me know your thoughts.
Is this what you suggest?
arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi +5 -5
@@ -172,7 +172,7 @@ }; }; - i2cmux at 2 { + i2c2mux { compatible = "i2c-mux-gpio"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_i2c2mux>;
@@ -183,20 +183,20 @@ i2c-parent = <&i2c2>; idle-state = <0>; - i2c2 at 1 { + i2c2mux at 1 { reg = <1>; #address-cells = <1>; #size-cells = <0>; }; - i2c2 at 2 { + i2c2mux at 2 { reg = <2>; #address-cells = <1>; #size-cells = <0>; }; }; - i2cmux at 3 { + i2c3mux { compatible = "i2c-mux-gpio"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_i2c3mux>;
@@ -206,7 +206,7 @@ i2c-parent = <&i2c3>; idle-state = <0>; - i2c3 at 1 { + i2c3mux at 1 { reg = <1>; #address-cells = <1>; #size-cells = <0>;
PATCH 11/12 ARM: dts: imx6qdl-nitrogen6_max: Remove unneeded unit address
Hi Fabio,
Quoted 5 lines · Fabio Estevam
Hi Gary,
On Mon, Dec 4, 2017 at 9:19 AM, Gary Bisson
<[email protected]> wrote:
Quoted 8 lines
Quoted 6 lines
What about naming it i2c2mux and i2c3mux so it is clearer those mux happen respectively for i2c2 and i2c3?
Then I'd rename the sub-nodes i2cXmux at Y instead of i2cX at Y currently.
Let me know your thoughts.
Is this what you suggest?
Yes exactly, I find it clearer, what do you think?
Regards,
Gary
Fabio Estevam
reviewerPATCH 11/12 ARM: dts: imx6qdl-nitrogen6_max: Remove unneeded unit address
Hi Gary,
Quoted 1 line · Gary Bisson
Yes exactly, I find it clearer, what do you think?
Yes, I will change it like this.
Thanks
Fabio Estevam
reviewerPATCH 12/12 ARM: dts: imx6ul-14x14-evk: Move regulators out of simple-bus
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
It is not recommended to place regulator nodes inside simple-bus, so move them out in order to fix the following build warnings with W=1:
arch/arm/boot/dts/imx6ul-14x14-evk.dtb: Warning (simple_bus_reg): Node /regulators/sd1_regulator missing or empty reg/ranges property
--- arch/arm/boot/dts/imx6ul-14x14-evk.dts | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-)
arch/arm/boot/dts/imx6ul-14x14-evk.dts +7 -12
@@ -30,19 +30,14 @@ status = "okay"; }; - regulators { - compatible = "simple-bus"; - #address-cells = <1>; - #size-cells = <0>; - reg_sd1_vmmc: sd1_regulator { - compatible = "regulator-fixed"; - regulator-name = "VSD_3V3"; - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - gpio = <&gpio1 9 GPIO_ACTIVE_HIGH>; - enable-active-high; - }; + reg_sd1_vmmc: regulator-sd1-vmmc { + compatible = "regulator-fixed"; + regulator-name = "VSD_3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + gpio = <&gpio1 9 GPIO_ACTIVE_HIGH>; + enable-active-high; }; sound {
Signature · 1 line
2.7.4
PATCH 1/12 ARM: dts: imx51-ts4800: Fix syscon and touschscreen nodes
In reply to Fabio EstevamHi,
Quoted 7 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The syscon node has an incorrect notation for its unit address and the wdt node has an unneeded unit address.
Fix them so that the following build warnings with W=1 are gone:
Quoted 8 lines
arch/arm/boot/dts/imx51-ts4800.dtb: Warning (unit_address_vs_reg): Node /memory has a reg or ranges property, but no unit namearch/arm/boot/dts/imx51-ts4800.dtb: Warning (unit_address_vs_reg): Node /soc/aips at 80000000/weim at 83fda000/fpga at 0/syscon at b0010000/wdt at e has a unit name, but no reg propertyarch/arm/boot/dts/imx51-ts4800.dtb: Warning (unit_address_vs_reg): Node /soc/aips at 80000000/weim at 83fda000/fpga at 0/touchscreen has a reg or ranges property, but no unit namearch/arm/boot/dts/imx51-ts4800.dtb: Warning (simple_bus_reg): Node /soc/aips at 80000000/weim at 83fda000/fpga at 0/syscon atb0010000simple-bus unit address format error, expected "10000"arch/arm/boot/dts/imx51-ts4800.dtb: Warning (simple_bus_reg): Node /soc/aips at 80000000/weim at 83fda000/fpga at 0/touchscreen simple-bus unit address format error, expected "12000"Cc Damien Riegel <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Changes are fine to me, thank you for fixing the warnings. I don't know what the rule is and if I should reply with a tag like Reviewed-by or anything else, please let me know.
Signature · 1 line
Damien
Fabio Estevam
reviewerPATCH 1/12 ARM: dts: imx51-ts4800: Fix syscon and touschscreen nodes
Hi Damien,
Quoted 3 lines · Damien Riegel
Changes are fine to me, thank you for fixing the warnings. I don't know what the rule is and if I should reply with a tag like Reviewed-by or anything else, please let me know.
Thanks for reviewing it.
If you could reply with a Reviewed-by or with a Tested-by (if you are able to test it in the real hardware), that would be nice.
Thanks
PATCH 1/12 ARM: dts: imx51-ts4800: Fix syscon and touschscreen nodes
Quoted 5 lines · Fabio Estevam
Hi Damien,
On Fri, Dec 1, 2017 at 5:45 PM, Damien Riegel
<[email protected]> wrote:
Quoted 8 lines
Quoted 3 lines
Changes are fine to me, thank you for fixing the warnings. I don't know what the rule is and if I should reply with a tag like Reviewed-by or anything else, please let me know.
Thanks for reviewing it.
If you could reply with a Reviewed-by or with a Tested-by (if you are able to test it in the real hardware), that would be nice.
I don't have the hardware at hand to test it right now, so here is my reviewed-by instead.
Signature · 1 line
Damien