Skip to contentSkip to conversation

dccp: CVE-2017-8824: use-after-free in DCCP code

PATCH In review [email protected] 3 participants 3 messages Dec 4, 2017 – Dec 5, 2017

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 dccp: CVE-2017-8824: use-after-free in DCCP code

From: Mohamed Ghannam <[email protected]>

Whenever the sock object is in DCCP_CLOSED state, dccp_disconnect() must free
dccps_hc_tx_ccid and dccps_hc_rx_ccid and set to NULL.

Signed-off-by Mohamed Ghannam <[email protected]>
---
 net/dccp/proto.c | 5 +++++
 1 file changed, 5 insertions(+)
net/dccp/proto.c +5 -0
index b68168f..9d43c1f 100644
@@ -259,6 +259,7 @@ int dccp_disconnect(struct sock *sk, int flags)
 {
 	struct inet_connection_sock *icsk = inet_csk(sk);
 	struct inet_sock *inet = inet_sk(sk);
+	struct dccp_sock *dp = dccp_sk(sk);
 	int err = 0;
 	const int old_state = sk->sk_state;
 

@@ -278,6 +279,10 @@ int dccp_disconnect(struct sock *sk, int flags)
 		sk->sk_err = ECONNRESET;
 
 	dccp_clear_xmit_timers(sk);
+	ccid_hc_rx_delete(dp->dccps_hc_rx_ccid, sk);
+	ccid_hc_tx_delete(dp->dccps_hc_tx_ccid, sk);
+	dp->dccps_hc_rx_ccid = NULL;
+	dp->dccps_hc_tx_ccid = NULL;
 
 	__skb_queue_purge(&sk->sk_receive_queue);
 	__skb_queue_purge(&sk->sk_write_queue);
Signature · 1 line
2.7.4
maintainer
#2 lore raw
In reply to [email protected]

From: [email protected]
Date: Mon, 4 Dec 2017 22:02:06 +0100

Quoted 6 lines

From: Mohamed Ghannam <[email protected]>

Whenever the sock object is in DCCP_CLOSED state, dccp_disconnect() must free
dccps_hc_tx_ccid and dccps_hc_rx_ccid and set to NULL.

Signed-off-by Mohamed Ghannam <[email protected]>

Please eliminate this weird indentation in your commit messages.

The text should be adjustest fully to the leftmost column with no unnecessary whitepsace.

Thank you.