Skip to contentSkip to conversation

power: qos: Export pm_qos_update_request_timeout()

PATCH In review Hareesh Gundu 2 participants 4 messages Dec 5, 2017 – Dec 6, 2017

Subsystems (2)
Suspend to RAM Hibernation
lore
Share & tools
lore

Hareesh Gundu

author
#0 lore raw

PATCH 1/1 power: qos: Export pm_qos_update_request_timeout()

Add EXPORT_SYMBOL_GPL to pm_qos_update_request_timeout, so that it can be usable from modules similar to the pm_qos_update_request().

Signed-off-by Hareesh Gundu <[email protected]>
---
 kernel/power/qos.c | 1 +
 1 file changed, 1 insertion(+)
kernel/power/qos.c +1 -0
index 9d75039..3f501b4 100644
@@ -515,6 +515,7 @@ void pm_qos_update_request_timeout(struct pm_qos_request *req, s32 new_value,
 
 	schedule_delayed_work(&req->work, usecs_to_jiffies(timeout_us));
 }
+EXPORT_SYMBOL_GPL(pm_qos_update_request_timeout);
 
 /**
  * pm_qos_remove_request - modifies an existing qos request
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 5 lines · Hareesh Gundu

Add EXPORT_SYMBOL_GPL to pm_qos_update_request_timeout, so that it can be usable from modules similar to the pm_qos_update_request().

Signed-off-by Hareesh Gundu <[email protected]>

I'd rather see a modular user of this along with the export.

Quoted 19 lines
---
 kernel/power/qos.c | 1 +
 1 file changed, 1 insertion(+)
kernel/power/qos.c +1 -1
index 9d75039..3f501b4 100644
@@ -515,6 +515,7 @@ void pm_qos_update_request_timeout(struct pm_qos_request *req, s32 new_value,
 
        schedule_delayed_work(&req->work, usecs_to_jiffies(timeout_us));
 }
+EXPORT_SYMBOL_GPL(pm_qos_update_request_timeout);
 
 /**
  * pm_qos_remove_request - modifies an existing qos request
--

1.9.1

author
#2 lore raw
Quoted 6 lines · Rafael J. Wysocki
Quoted 5 lines · Hareesh Gundu

Add EXPORT_SYMBOL_GPL to pm_qos_update_request_timeout, so that it can be usable from modules similar to the pm_qos_update_request().

Signed-off-by Hareesh Gundu <[email protected]>

There is no in-tree kernel module using it. It's required for modules built out-tree kernel. Does it really required show out tree kernel module uses this symbol ?

Quoted 21 lines

I'd rather see a modular user of this along with the export.

Quoted 19 lines
---
  kernel/power/qos.c | 1 +
  1 file changed, 1 insertion(+)
kernel/power/qos.c +1 -1
index 9d75039..3f501b4 100644
@@ -515,6 +515,7 @@ void pm_qos_update_request_timeout(struct pm_qos_request *req, s32 new_value,
 
         schedule_delayed_work(&req->work, usecs_to_jiffies(timeout_us));
  }
+EXPORT_SYMBOL_GPL(pm_qos_update_request_timeout);
 
  /**
   * pm_qos_remove_request - modifies an existing qos request
--

1.9.1

maintainer
#3 lore raw
Quoted 10 lines · Hareesh Gundu
Quoted 8 lines · Rafael J. Wysocki
Quoted 5 lines · Hareesh Gundu

Add EXPORT_SYMBOL_GPL to pm_qos_update_request_timeout, so that it can be usable from modules similar to the pm_qos_update_request().

Quoted 5 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Hareesh Gundu <[email protected]>

There is no in-tree kernel module using it. It's required for modules built out-tree kernel.
Does it really required show out tree kernel module uses this symbol ?

If the module is out of the tree, the patch can be out of the tree too, unless there is a very good reason for it to be in the tree.

So, what is that reason?