Patch "drm/exynos/decon5433: set STANDALONE_UPDATE_F also if planes are disabled" has been added to the 4.9-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
drm/exynos/decon5433: set STANDALONE_UPDATE_F also if planes are disabled
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-exynos-decon5433-set-standalone_update_f-also-if-planes-are-disabled.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Wed Dec 6 17:39:55 CET 2017
From: Andrzej Hajda <[email protected]>
Date: Fri, 13 Jan 2017 10:20:58 +0100
Subject: drm/exynos/decon5433: set STANDALONE_UPDATE_F also if planes are disabled
From: Andrzej Hajda <[email protected]>
[ Upstream commit 821b40b79db7dedbfe15ab330dfd181e661a533f ]
STANDALONE_UPDATE_F should be set if something changed in plane configurations, including plane disable.
The patch fixes page-faults bugs, caused by decon still using framebuffers of disabled planes.
v2: fixed clear-bit code (Thx Marek)
v3: use test_and_clear_bit (Thx Joonyoung)
--- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/exynos/exynos5433_drm_decon.c +5 -3
@@ -46,7 +46,8 @@ enum decon_flag_bits {BIT_CLKS_ENABLED ,BIT_IRQS_ENABLED ,BIT_WIN_UPDATED , -BIT_SUSPENDED +BIT_SUSPENDED , +BIT_REQUEST_UPDATE }; struct decon_context {
@@ -313,6 +314,7 @@ static void decon_update_plane(struct ex/* window enable */ decon_set_bits (ctx,DECON_WINCONx (win), WINCONx_ENWIN_F, ~0 ); +set_bit (BIT_REQUEST_UPDATE , &ctx->flags); } static void decon_disable_plane(struct exynos_drm_crtc *crtc,
@@ -325,6 +327,7 @@ static void decon_disable_plane(struct ereturn ;decon_set_bits (ctx,DECON_WINCONx (win), WINCONx_ENWIN_F,0 ); +set_bit (BIT_REQUEST_UPDATE , &ctx->flags); }static void decon_atomic_flush (struct exynos_drm_crtc *crtc)
@@ -338,8 +341,7 @@ static void decon_atomic_flush(struct exfor (i = ctx->first_win; i <WINDOWS_NR ; i++)decon_shadow_protect_win (ctx, i, false); -/* update iff there are active windows */ -if (crtc->base.state->plane_mask) +if (test_and_clear_bit (BIT_REQUEST_UPDATE , &ctx->flags))decon_set_bits (ctx,DECON_UPDATE ,STANDALONE_UPDATE_F , ~0 );if (ctx->out_type &IFTYPE_I80 )
Patches currently in stable-queue which might be from [email protected] are
queue-4.9/drm-exynos-decon5433-set-standalone_update_f-also-if-planes-are-disabled.patch queue-4.9/drm-exynos-decon5433-update-shadow-registers-iff-there-are-active-windows.patch queue-4.9/drm-exynos-decon5433-set-standalone_update_f-on-output-enablement.patch