Fix subtle race in tst-cancel2 / tst-cancelx2
PATCH 1/1 Fix subtle race in tst-cancel2 / tst-cancelx2
When ran on ARC, these tests would ocassionally fail
| [ARCLinux]# for i in 1 2 3 4 5 ; do ./tst-cancel2; echo $?; done | write succeeded | result is wrong: expected 0xffffffff, got 0x1 | 1 <-- fail | 0 <-- pass | 0 <--- pass | 0 <-- pass | write succeeded | result is wrong: expected 0xffffffff, got 0x1 | 1 <-- fail
Same test (which originated form glibc) doesn't fail in glibc builds. Turns out there's a subtle race in uclibc version
The test creates a new thread, makes it do a looong write call, and parent then cancels the thread, expecting it to unwind out of write call cleanly. However the write (even for 10k bytes) could fnish befor eparent gets a chance ti run and/or cancel - causing the occasional failire.
Cc: Cupertino Miranda <cmiranda at synopsys.com>
Fix this subtelty by making it write not just once but forever.
--- test/nptl/tst-cancel2.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
test/nptl/tst-cancel2.c +1 -5
@@ -32,11 +32,7 @@ tf (void *arg)write blocks. */ char buf[100000 ]; -if (write (fd[1 ], buf,sizeof (buf)) ==sizeof (buf)) - { -puts ("write succeeded" ); -return (void *)1l ; - } +while (write (fd[1 ], buf,sizeof (buf)) >0 );return (void *)42l ; }
Signature · 1 line
2.7.4
PATCH v2 1/1 Fix subtle race in tst-cancel2 / tst-cancelx2
When ran on ARC, these tests would ocassionally fail
| [ARCLinux]# for i in 1 2 3 4 5 ; do ./tst-cancel2; echo $?; done | write succeeded | result is wrong: expected 0xffffffff, got 0x1 | 1 <-- fail | 0 <-- pass | 0 <--- pass | 0 <-- pass | write succeeded | result is wrong: expected 0xffffffff, got 0x1 | 1 <-- fail
Same test (which originated form glibc) doesn't fail in glibc builds. Turns out there's a subtle race in uclibc version
The test creates a new thread, makes it do a looong write call, and parent then cancels the thread, expecting it to unwind out of write call cleanly. However the write (even for 10k bytes) could finish before parent gets a chance to resume and/or cancel it, causing the occasional failure.
Fix this subtelty by making it write not just once but forever.
---
Change since v1: fix typos in changelogs
--- test/nptl/tst-cancel2.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
test/nptl/tst-cancel2.c +1 -5
@@ -32,11 +32,7 @@ tf (void *arg)write blocks. */ char buf[100000 ]; -if (write (fd[1 ], buf,sizeof (buf)) ==sizeof (buf)) - { -puts ("write succeeded" ); -return (void *)1l ; - } +while (write (fd[1 ], buf,sizeof (buf)) >0 );return (void *)42l ; }
Signature · 1 line
2.7.4
PATCH v2 1/1 Fix subtle race in tst-cancel2 / tst-cancelx2
Quoted 22 lines · Vineet Gupta
When ran on ARC, these tests would ocassionally fail
| [ARCLinux]# for i in 1 2 3 4 5 ; do ./tst-cancel2; echo $?; done | write succeeded | result is wrong: expected 0xffffffff, got 0x1 | 1 <-- fail | 0 <-- pass | 0 <--- pass | 0 <-- pass | write succeeded | result is wrong: expected 0xffffffff, got 0x1 | 1 <-- failSame test (which originated form glibc) doesn't fail in glibc builds. Turns out there's a subtle race in uclibc version
The test creates a new thread, makes it do a looong write call, and parent then cancels the thread, expecting it to unwind out of write call cleanly. However the write (even for 10k bytes) could finish before parent gets a chance to resume and/or cancel it, causing the occasional failure.
Quoted 7 lines
Fix this subtelty by making it write not just once but forever.
Cc Cupertino Miranda <cmiranda at synopsys.com>Signed-off-by Vineet Gupta <vgupta at synopsys.com>---
Change since v1: fix typos in changelogs
---
Ping ?
Quoted 21 lines
test/nptl/tst-cancel2.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)test/nptl/tst-cancel2.c +1
-5@@ -32,11 +32,7 @@ tf (void *arg)write blocks. */ char buf[100000 ]; -if (write (fd[1 ], buf,sizeof (buf)) ==sizeof (buf)) - { -puts ("write succeeded" ); -return (void *)1l ; - } +while (write (fd[1 ], buf,sizeof (buf)) >0 );return (void *)42l ; }
PATCH v2 1/1 Fix subtle race in tst-cancel2 / tst-cancelx2
Hi,
patch applied and pushed,
just forgot the mail,
best regards
Waldemar
Quoted 49 lines
Am 18.12.2017 um 20:18 schrieb Vineet Gupta <Vineet.Gupta1 at synopsys.com>:
Quoted 12 lines · Vineet Gupta
When ran on ARC, these tests would ocassionally fail
| [ARCLinux]# for i in 1 2 3 4 5 ; do ./tst-cancel2; echo $?; done | write succeeded | result is wrong: expected 0xffffffff, got 0x1 | 1 <-- fail | 0 <-- pass | 0 <--- pass | 0 <-- pass | write succeeded | result is wrong: expected 0xffffffff, got 0x1 | 1 <-- failQuoted 13 lines
Same test (which originated form glibc) doesn't fail in glibc builds. Turns out there's a subtle race in uclibc version
The test creates a new thread, makes it do a looong write call, and parent then cancels the thread, expecting it to unwind out of write call cleanly. However the write (even for 10k bytes) could finish before parent gets a chance to resume and/or cancel it, causing the occasional failure.
Fix this subtelty by making it write not just once but forever.
Cc: Cupertino Miranda <cmiranda at synopsys.com>
Signed-off-by: Vineet Gupta <vgupta at synopsys.com>
---
Change since v1: fix typos in changelogs
---Ping ?
Quoted 17 lines
test/nptl/tst-cancel2.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)test/nptl/tst-cancel2.c +1
-4@@ -32,11 +32,7 @@ tf (void *arg)write blocks. */ char buf[100000 ]; - if (write (fd[1], buf, sizeof (buf)) == sizeof (buf)) - { -puts ("write succeeded" ); -return (void *)1l ; - } + while (write (fd[1], buf, sizeof (buf)) > 0);return (void *)42l ; }