Patch "btrfs: fix missing error return in btrfs_drop_snapshot" has been added to the 4.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
btrfs: fix missing error return in btrfs_drop_snapshot
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
btrfs-fix-missing-error-return-in-btrfs_drop_snapshot.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
e19182c0fff451e3744c1107d98f072e7ca377a0Mon Sep 17 00:00:00 2001
From: Jeff Mahoney <[email protected]>
Date: Mon, 4 Dec 2017 13:11:45 -0500
Subject: btrfs: fix missing error return in btrfs_drop_snapshot
From: Jeff Mahoney <[email protected]>
commit e19182c0fff451e3744c1107d98f072e7ca377a0 upstream.
If btrfs_del_root fails in btrfs_drop_snapshot, we'll pick up the error but then return 0 anyway due to mixing err and ret.
--- fs/btrfs/extent-tree.c | 1 + 1 file changed, 1 insertion(+)
fs/btrfs/extent-tree.c +1 -0
@@ -9283,6 +9283,7 @@ int btrfs_drop_snapshot(struct btrfs_roo ret =btrfs_del_root (trans, fs_info, &root->root_key);if (ret) {btrfs_abort_transaction (trans, ret); + err = ret; goto out_end_trans; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/btrfs-fix-missing-error-return-in-btrfs_drop_snapshot.patch queue-4.14/btrfs-handle-errors-while-updating-refcounts-in-update_ref_for_cow.patch