Skip to contentSkip to conversation

kernel-devsrc: Use full mrproper to clean

PATCH In review Saul Wold 2 participants 3 messages Dec 5, 2017 – Dec 12, 2017

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

PATCH 1/1 kernel-devsrc: Use full mrproper to clean

By using the full mrproper clean target it also removes some generated files that are not required on the target to build. It also helps to fix reprodudible builds as the generated files could have different permissions causing the check to fail.

Tested with building and booting kernel from source on the target

[YOCTO #12137]

---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/linux/kernel-devsrc.bb +1 -1
index c1b5b7786d7..d925a33aeb1 100644
@@ -52,7 +52,7 @@ do_install() {
         # The main build artifacts. We clean the directory to avoid QA errors on mismatched
         # architecture (since scripts and helpers are native format).
         KBUILD_OUTPUT="$kerneldir"
-        oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean _mrproper_scripts
+        oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean mrproper
         # make clean generates an absolute path symlink called "source"
         # in $kerneldir points to $kerneldir, which doesn't make any
         # sense, so remove it.
Signature · 1 line
2.13.6
#1 lore raw

This breaks some of the sanity tests, which build a kernel module:

https://autobuilder.yocto.io/builders/nightly-x86-64/builds/664

Ross

Quoted 42 lines · Saul Wold

By using the full mrproper clean target it also removes some generated files
that are not required on the target to build. It also helps to fix reprodudible
builds as the generated files could have different permissions causing the check to fail.

Tested with building and booting kernel from source on the target

[YOCTO #12137]

---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/linux/kernel-devsrc.bb +0 -0
index c1b5b7786d7..d925a33aeb1 100644
@@ -52,7 +52,7 @@ do_install() {
         # The main build artifacts. We clean the directory to avoid QA

errors on mismatched

         # architecture (since scripts and helpers are native format).
         KBUILD_OUTPUT="$kerneldir"
-        oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}"
clean _mrproper_scripts
+        oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}"
clean mrproper
         # make clean generates an absolute path symlink called "source"
         # in $kerneldir points to $kerneldir, which doesn't make any
         # sense, so remove it.
--
2.13.6

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

author
#2 lore raw
Quoted 4 lines · Ross

This breaks some of the sanity tests, which build a kernel module:

https://autobuilder.yocto.io/builders/nightly-x86-64/builds/664

Interesting, I did a local build of a kernel module as well as a full build of the kernel with out failure, I will investigate the oe- selftest failure.

Sau!

Quoted 50 lines

Ross

Quoted 45 lines · Saul Wold

By using the full mrproper clean target it also removes some generated files
that are not required on the target to build. It also helps to fix reprodudible
builds as the generated files could have different permissions causing the
check to fail.

Tested with building and booting kernel from source on the target

[YOCTO #12137]

---
 meta/recipes-kernel/linux/kernel-devsrc.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-kernel/linux/kernel-devsrc.bb +0 -0
index c1b5b7786d7..d925a33aeb1 100644
@@ -52,7 +52,7 @@ do_install() {
         # The main build artifacts. We clean the directory to

avoid QA errors on mismatched

         # architecture (since scripts and helpers are native
format).
         KBUILD_OUTPUT="$kerneldir"
-        oe_runmake -C $kerneldir CC="${KERNEL_CC}"
LD="${KERNEL_LD}" clean _mrproper_scripts
+        oe_runmake -C $kerneldir CC="${KERNEL_CC}"
LD="${KERNEL_LD}" clean mrproper
         # make clean generates an absolute path symlink called
"source"
         # in $kerneldir points to $kerneldir, which doesn't make
any
         # sense, so remove it.
--
2.13.6

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core