Skip to contentSkip to conversation

Patch "thunderbolt: tb: fix use after free in tb_activate_pcie_devices" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Dec 18, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

thunderbolt: tb: fix use after free in tb_activate_pcie_devices

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
thunderbolt-tb-fix-use-after-free-in-tb_activate_pcie_devices.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Dec 18 13:28:59 CET 2017

From: "Gustavo A. R. Silva" <[email protected]>
Date: Sat, 4 Nov 2017 23:52:54 -0500
Subject: thunderbolt: tb: fix use after free in tb_activate_pcie_devices

From: "Gustavo A. R. Silva" <[email protected]>

[ Upstream commit a2e373438f72391493a4425efc1b82030b6b4fd5 ]

Add a ̣̣continue statement in order to avoid using a previously free'd pointer tunnel in list_add.

Addresses-Coverity-ID: 1415336

Fixes 9d3cce0b6136 ("thunderbolt: Introduce thunderbolt bus and connection manager")
---
 drivers/thunderbolt/tb.c |    1 +
 1 file changed, 1 insertion(+)
drivers/thunderbolt/tb.c +1 -0
@@ -225,6 +225,7 @@ static void tb_activate_pcie_devices(str
 			tb_port_info(up_port,
 				     "PCIe tunnel activation failed, aborting\n");
 			tb_pci_free(tunnel);
+			continue;
 		}
 
 		list_add(&tunnel->list, &tcm->tunnel_list);

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/thunderbolt-tb-fix-use-after-free-in-tb_activate_pcie_devices.patch