Skip to contentSkip to conversation

Patch "fjes: Fix wrong netdevice feature flags" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Dec 18, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

fjes: Fix wrong netdevice feature flags

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
fjes-fix-wrong-netdevice-feature-flags.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Mon Dec 18 14:47:43 CET 2017

From: Taku Izumi <[email protected]>
Date: Wed, 15 Mar 2017 13:47:50 +0900
Subject: fjes: Fix wrong netdevice feature flags

From: Taku Izumi <[email protected]>

[ Upstream commit fe8daf5fa715f7214952f06a387e4b7de818c5be ]

This patch fixes netdev->features for Extended Socket network device.

Currently Extended Socket network device's netdev->feature claims NETIF_F_HW_CSUM, however this is completely wrong. There's no feature of checksum offloading.
That causes invalid TCP/UDP checksum and packet rejection when IP forwarding from Extended Socket network device to other network device.

NETIF_F_HW_CSUM should be omitted.

---
 drivers/net/fjes/fjes_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/fjes/fjes_main.c +1 -1
@@ -1205,7 +1205,7 @@ static void fjes_netdev_setup(struct net
 	fjes_set_ethtool_ops(netdev);
 	netdev->mtu = fjes_support_mtu[0];
 	netdev->flags |= IFF_BROADCAST;
-	netdev->features |= NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_CTAG_FILTER;
+	netdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
 }
 
 static void fjes_irq_watch_task(struct work_struct *work)

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/fjes-fix-wrong-netdevice-feature-flags.patch