coda/imx-vdoa: Remove irq member from vdoa_data struct
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/1 coda/imx-vdoa: Remove irq member from vdoa_data struct
From: Fabio Estevam <[email protected]>
The 'irq' member of the vdoa_data struct is only used inside probe, so there is no need for it. Use a local variable 'ret' instead.
Signed-off-by Fabio Estevam <[email protected]>
--- drivers/media/platform/coda/imx-vdoa.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/media/platform/coda/imx-vdoa.c +4 -4
@@ -86,7 +86,6 @@ struct vdoa_data {struct device *dev;struct clk *vdoa_clk;void __iomem *regs; -int irq; };struct vdoa_q_data {
@@ -293,6 +292,7 @@ static int vdoa_probe(struct platform_device *pdev) {struct vdoa_data *vdoa;struct resource *res; +int ret;dma_set_coherent_mask (&pdev->dev,DMA_BIT_MASK (32 ));
@@ -316,12 +316,12 @@ static int vdoa_probe(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_IRQ ,0 );if (!res)return -EINVAL ; - vdoa->irq =devm_request_threaded_irq (&pdev->dev, res->start,NULL , + ret =devm_request_threaded_irq (&pdev->dev, res->start,NULL , vdoa_irq_handler,IRQF_ONESHOT ,"vdoa" , vdoa); -if (vdoa->irq <0 ) { +if (ret <0 ) {dev_err (vdoa->dev,"Failed to get irq\n" ); -return vdoa->irq; +return ret; }platform_set_drvdata (pdev, vdoa);
Signature · 1 line
2.7.4
Quoted 6 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
The 'irq' member of the
vdoa_datastruct is only used inside probe, so there is no need for it. Use a local variable 'ret' instead.Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Philipp Zabel <[email protected]>
regards
Philipp
Quoted 40 lines
--- drivers/media/platform/coda/imx-vdoa.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/media/platform/coda/imx-vdoa.c +4
-4@@ -86,7 +86,6 @@ struct vdoa_data {struct device *dev;struct clk *vdoa_clk;void __iomem *regs; -int irq; };struct vdoa_q_data {@@ -293,6 +292,7 @@ static int vdoa_probe(struct platform_device *pdev) {struct vdoa_data *vdoa;struct resource *res; +int ret;dma_set_coherent_mask (&pdev->dev,DMA_BIT_MASK (32 ));@@ -316,12 +316,12 @@ static int vdoa_probe(struct platform_device *pdev) res =platform_get_resource (pdev,IORESOURCE_IRQ ,0 );if (!res)return -EINVAL ; - vdoa->irq =devm_request_threaded_irq (&pdev->dev, res->start,NULL , + ret =devm_request_threaded_irq (&pdev->dev, res->start,NULL , vdoa_irq_handler,IRQF_ONESHOT ,"vdoa" , vdoa); -if (vdoa->irq <0 ) { +if (ret <0 ) {dev_err (vdoa->dev,"Failed to get irq\n" ); -return vdoa->irq; +return ret; }platform_set_drvdata (pdev, vdoa);