padata: Remove FSF address

PATCH In review Cheah Kok Cheong 4 participants 10 messages Dec 20, 2017 – Jan 5, 2018

Subsystems (2)

Crypto API Padata parallel execution mechanism

lore

Share & tools

lore

Cheah Kok Cheong

author

2017-12-20 20:16 UTC #0 lore raw

PATCH 1/2 padata: Remove FSF address

Remove FSF address otherwise checkpatch will flag my next patch.

Signed-off-by Cheah Kok Cheong <[email protected]>

---
 kernel/padata.c | 4 ----
 1 file changed, 4 deletions(-)

kernel/padata.c +0 -4

index 57c0074..9d91909 100644
@@ -14,10 +14,6 @@
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
 #include <linux/export.h>

Signature · 1 line

2.7.4

Cheah Kok Cheong

author

2017-12-20 20:15 UTC #1 lore raw

PATCH 2/2 padata: Remove redundant export.h header

It is already included in module.h, see
commit f50169324df4 ("module.h: split out the EXPORT_SYMBOL into export.h") for their relationship.

Signed-off-by Cheah Kok Cheong <[email protected]>

---
 kernel/padata.c | 1 -
 1 file changed, 1 deletion(-)

kernel/padata.c +0 -1

index 9d91909..e265953 100644
@@ -16,7 +16,6 @@
  * more details.
  */
 
-#include <linux/export.h>
 #include <linux/cpumask.h>
 #include <linux/err.h>
 #include <linux/cpu.h>

Signature · 1 line

2.7.4

Philippe Ombredanne

2017-12-20 20:21 UTC #2 lore raw

In reply to Cheah Kok Cheong

Quoted 23 lines · Cheah Kok Cheong

Remove FSF address otherwise checkpatch will flag my next patch.

Signed-off-by Cheah Kok Cheong <[email protected]>

---
 kernel/padata.c | 4 ----
 1 file changed, 4 deletions(-)

kernel/padata.c +0 -5

index 57c0074..9d91909 100644
@@ -14,10 +14,6 @@
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
 #include <linux/export.h>
--

Quoted 2 lines

2.7.4

Why not use instead the simpler SPDX ids?

Signature · 2 lines

Cordially
Philippe Ombredanne

Cheah Kok Cheong

author

2017-12-20 21:17 UTC #3 lore raw

Quoted 22 lines · Philippe Ombredanne

Quoted 21 lines · Cheah Kok Cheong

Remove FSF address otherwise checkpatch will flag my next patch.

Signed-off-by Cheah Kok Cheong <[email protected]>

---
 kernel/padata.c | 4 ----
 1 file changed, 4 deletions(-)

kernel/padata.c +0 -4

index 57c0074..9d91909 100644
@@ -14,10 +14,6 @@
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
  */

Quoted 10 lines

Quoted 4 lines
kernel/padata.c +0 -1
 #include <linux/export.h>
--
2.7.4
Why not use instead the simpler SPDX ids?
Signature · 2 lines
Cordially
Philippe Ombredanne

Hi Philippe,
Adding the SPDX id can be the subject of a separate patch.
Believe you are part of the team doing an audit in this matter. I shall leave adding the SPDX id to you guys the professionals. Looks like you guys are using script to do this en masse.

But if you insist and our maintainer is agreeable, I can send another patch to add the SPDX id.

Thanks.
Brgds,
CheahKC

Philippe Ombredanne

2017-12-21 07:35 UTC #4 lore raw

Dear CheahKC,

Quoted 34 lines · Cheah Kok Cheong

Quoted 22 lines · Philippe Ombredanne
Quoted 21 lines · Cheah Kok Cheong
Remove FSF address otherwise checkpatch will flag my next patch.
Signed-off-by Cheah Kok Cheong <[email protected]>
---
 kernel/padata.c | 4 ----
 1 file changed, 4 deletions(-)
kernel/padata.c +0 -4
index 57c0074..9d91909 100644
@@ -14,10 +14,6 @@
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
Quoted 10 lines
Quoted 4 lines
kernel/padata.c +0 -1
 #include <linux/export.h>
--
2.7.4
Why not use instead the simpler SPDX ids?
--
Cordially
Philippe Ombredanne

Quoted 8 lines

Hi Philippe,
Adding the SPDX id can be the subject of a separate patch.
Believe you are part of the team doing an audit in this matter. I shall leave adding the SPDX id to you guys the professionals. Looks like you guys are using script to do this en masse.
But if you insist and our maintainer is agreeable, I can send another patch to add the SPDX id.

If you could work it out directly that would be best. There are a lot of files in the kernel and each one needs a careful review even with best license detection script (which . So tagging files on the go when they are updated is the best way to help!

Thank you.

Signature · 2 lines

Cordially
Philippe Ombredanne

Cheah Kok Cheong

author

2017-12-21 11:05 UTC #5 lore raw

Quoted 46 lines · Philippe Ombredanne

Dear CheahKC,
Quoted 34 lines · Cheah Kok Cheong
Quoted 22 lines · Philippe Ombredanne
Quoted 21 lines · Cheah Kok Cheong
Remove FSF address otherwise checkpatch will flag my next patch.
Signed-off-by Cheah Kok Cheong <[email protected]>
---
 kernel/padata.c | 4 ----
 1 file changed, 4 deletions(-)
kernel/padata.c +0 -4
index 57c0074..9d91909 100644
@@ -14,10 +14,6 @@
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
Quoted 10 lines
Quoted 4 lines
kernel/padata.c +0 -1
 #include <linux/export.h>
--
2.7.4
Why not use instead the simpler SPDX ids?
--
Cordially
Philippe Ombredanne
Quoted 8 lines
Hi Philippe,
Adding the SPDX id can be the subject of a separate patch.
Believe you are part of the team doing an audit in this matter. I shall leave adding the SPDX id to you guys the professionals. Looks like you guys are using script to do this en masse.
But if you insist and our maintainer is agreeable, I can send another patch to add the SPDX id.

Quoted 11 lines

If you could work it out directly that would be best. There are a lot of files in the kernel and each one needs a careful review even with best license detection script (which . So tagging files on the go when they are updated is the best way to help!
Thank you.
Signature · 2 lines
Cordially
Philippe Ombredanne

Ok I'll send a separate patch to add the SPDX id. Glad to help.

Thank you.

Brgds,
CheahKC

Cheah Kok Cheong

author

2017-12-21 11:36 UTC #6 lore raw

PATCH 1/1 padata: add SPDX identifier

Add SPDX license identifier according to the type of license text found in the file.

Cc Philippe Ombredanne <[email protected]>

Signed-off-by Cheah Kok Cheong <[email protected]>

---
 kernel/padata.c | 1 +
 1 file changed, 1 insertion(+)

kernel/padata.c +1 -0

index e265953..eb9a9d9 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * padata.c - generic interface to process data streams in parallel
  *

Signature · 1 line

2.7.4

Herbert Xu

maintainer

2017-12-28 06:53 UTC #7 lore raw

Re: [PATCH] padata: add SPDX identifier

Quoted 14 lines · Cheah Kok Cheong

Add SPDX license identifier according to the type of license text found in the file.
Cc Philippe Ombredanne <[email protected]>
Signed-off-by Cheah Kok Cheong <[email protected]>
---
kernel/padata.c | 1 +
1 file changed, 1 insertion(+)
kernel/padata.c +0 -0
index e265953..eb9a9d9 100644

kernel/padata.c line 4

Quoted 4 lines

kernel/padata.c +1 -0

@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
 * padata.c - generic interface to process data streams in parallel
 *

Steffen, are you OK with this patch?

Thanks,

Signature · 3 lines

Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Steffen Klassert

maintainer Acked-by

2017-12-30 08:21 UTC #8 lore raw

Re: [PATCH] padata: add SPDX identifier

Quoted 10 lines · Herbert Xu

Quoted 9 lines · Cheah Kok Cheong
Add SPDX license identifier according to the type of license text found in the file.
Cc Philippe Ombredanne <[email protected]>
Signed-off-by Cheah Kok Cheong <[email protected]>
---
kernel/padata.c | 1 +
1 file changed, 1 insertion(+)

Quoted 11 lines

kernel/padata.c line 4
Quoted 9 lines
kernel/padata.c +1 -0
index e265953..eb9a9d9 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
 * padata.c - generic interface to process data streams in parallel
 *
Steffen, are you OK with this patch?

Yes, I'm ok with this.

Acked-by Steffen Klassert <[email protected]>

Herbert Xu

maintainer

2018-01-05 11:14 UTC #9 lore raw

Re: padata: add SPDX identifier

In reply to Cheah Kok Cheong

Quoted 6 lines · Cheah Kok Cheong

Add SPDX license identifier according to the type of license text found in the file.
Cc Philippe Ombredanne <[email protected]>
Signed-off-by Cheah Kok Cheong <[email protected]>
Acked-by Steffen Klassert <[email protected]>

Patch applied. Thanks.

Signature · 3 lines

Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt