Patch "objtool: Print top level commands on incorrect usage" has been added to the 4.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
objtool: Print top level commands on incorrect usage
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
objtool-print-top-level-commands-on-incorrect-usage.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
6a93bb7e4a7d6670677d5b0eb980936eb9cc5d2eMon Sep 17 00:00:00 2001
From: Kamalesh Babulal <[email protected]>
Date: Sat, 14 Oct 2017 20:17:54 +0530
Subject: objtool: Print top level commands on incorrect usage
From: Kamalesh Babulal <[email protected]>
commit 6a93bb7e4a7d6670677d5b0eb980936eb9cc5d2e upstream.
Print top-level objtool commands, along with the error on incorrect command line usage. Objtool command line parser exit's with code 129, for incorrect usage. Convert the cmd_usage() exit code also, to maintain consistency across objtool.
After the patch:
$ ./objtool -j
Unknown option: -j
usage: objtool COMMAND [ARGS]
Commands:
check Perform stack metadata validation on an object file
orc Generate in-place ORC unwind tables for an object file
$ echo $? 129
--- tools/objtool/objtool.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
tools/objtool/objtool.c +2 -4
@@ -70,7 +70,7 @@ static void cmd_usage(void)printf ("\n" ); -exit (1 ); +exit (129 ); }static void handle_options (int *argc,const char ***argv)
@@ -86,9 +86,7 @@ static void handle_options(int *argc, cobreak ; }else {fprintf (stderr,"Unknown option: %s\n" , cmd); -fprintf (stderr,"\n Usage: %s\n" , - objtool_usage_string); -exit (1 ); +cmd_usage (); } (*argv)++;
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/objtool-print-top-level-commands-on-incorrect-usage.patch