virt: vbox: use %pR format for printing resource_size_t
Arnd Bergmann
maintainerPATCH 1/1 virt: vbox: use %pR format for printing resource_size_t
resource_size_t may be larger than pointers depending on configuration, so we can run into this build warning:
drivers/virt/vboxguest/vboxguest_linux.c: In function 'vbg_pci_probe':drivers/virt/vboxguest/vboxguest_linux.c:295:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] drivers/virt/vboxguest/vboxguest_linux.c:367:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
This uses the special %pR to print the address by reference.
--- drivers/virt/vboxguest/vboxguest_linux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/virt/vboxguest/vboxguest_linux.c +4 -4
@@ -291,8 +291,8 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) vmmdev =devm_ioremap (dev, mmio, mmio_len);if (!vmmdev) { -vbg_err ("vboxguest: Error ioremap failed; MMIO addr=%p size=%d\n" , - (void *)mmio, (int )mmio_len); +vbg_err ("vboxguest: Error ioremap failed; MMIO addr=%pR size=%pR\n" , + &mmio, &mmio_len); goto err_disable_pcidev; }
@@ -362,9 +362,9 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)device_create_file (dev, &dev_attr_host_version);device_create_file (dev, &dev_attr_host_features); -vbg_info ("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %p (size %d)\n" , +vbg_info ("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pR (size %pR)\n" , gdev->misc_device.minor, pci->irq, gdev->io_port, - (void *)mmio, (int )mmio_len); + &mmio, &mmio_len);return 0 ;
Signature · 1 line
2.9.0
Joe Perches
NAKQuoted 2 lines · Arnd Bergmann
resource_size_tmay be larger than pointers depending on configuration, so we can run into this build warning:
nak.
struct resource is different than resource_size_t
Quoted 39 lines
drivers/virt/vboxguest/vboxguest_linux.c: In function 'vbg_pci_probe':drivers/virt/vboxguest/vboxguest_linux.c:295:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]drivers/virt/vboxguest/vboxguest_linux.c:367:4: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]This uses the special %pR to print the address by reference.
Fixes 0ba002bc4393 ("virt: Add vboxguest driver for Virtual Box Guest integration")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/virt/vboxguest/vboxguest_linux.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/virt/vboxguest/vboxguest_linux.c +4
-4@@ -291,8 +291,8 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) vmmdev =devm_ioremap (dev, mmio, mmio_len);if (!vmmdev) { -vbg_err ("vboxguest: Error ioremap failed; MMIO addr=%p size=%d\n" , - (void *)mmio, (int )mmio_len); +vbg_err ("vboxguest: Error ioremap failed; MMIO addr=%pR size=%pR\n" , + &mmio, &mmio_len); goto err_disable_pcidev; }@@ -362,9 +362,9 @@ static int vbg_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)device_create_file (dev, &dev_attr_host_version);device_create_file (dev, &dev_attr_host_features); -vbg_info ("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %p (size %d)\n" , +vbg_info ("vboxguest: misc device minor %d, IRQ %d, I/O port %x, MMIO at %pR (size %pR)\n" , gdev->misc_device.minor, pci->irq, gdev->io_port, - (void *)mmio, (int )mmio_len); + &mmio, &mmio_len);return 0 ;
Arnd Bergmann
maintainerQuoted 7 lines · Joe Perches
Quoted 2 lines · Arnd Bergmann
resource_size_tmay be larger than pointers depending on configuration, so we can run into this build warning:nak.
struct resource is different than
resource_size_t
Ouch, thanks for catching this!
It should have been %pap of course.
Arnd