Skip to contentSkip to conversation

Patch "ALSA: hda - Clear the leftover component assignment at snd_hdac_i915_exit()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Dec 22, 2017

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ALSA: hda - Clear the leftover component assignment at snd_hdac_i915_exit()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-hda-clear-the-leftover-component-assignment-at-snd_hdac_i915_exit.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From faafd03d23c913633d2ef7e6ffebdce01b164409 Mon Sep 17 00:00:00 2001

From: Takashi Iwai <[email protected]>
Date: Tue, 29 Mar 2016 12:29:24 +0200
Subject: ALSA: hda - Clear the leftover component assignment at snd_hdac_i915_exit()

From: Takashi Iwai <[email protected]>

commit faafd03d23c913633d2ef7e6ffebdce01b164409 upstream.

The commit [d745f5e7b8b2: ALSA: hda - Add the pin / port mapping on Intel ILK and VLV] introduced a WARN_ON() to check the pointer for avoiding the double initializations. But hdac_acomp pointer wasn't cleared at snd_hdac_i915_exit(), thus after reloading the HD-audio driver, it may result in the false positive warning. This patch makes sure to clear the leftover pointer at exit.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94736

---
 sound/hda/hdac_i915.c |    1 +
 1 file changed, 1 insertion(+)
sound/hda/hdac_i915.c +1 -0
@@ -273,6 +273,7 @@ int snd_hdac_i915_exit(struct hdac_bus *
 
 	kfree(acomp);
 	bus->audio_component = NULL;
+	hdac_acomp = NULL;
 
 	return 0;
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/alsa-hda-degrade-i915-binding-failure-message.patch queue-4.4/alsa-hda-add-support-for-docking-station-for-hp-820-g2.patch queue-4.4/alsa-hda-enable-audio-component-for-old-intel-pch-devices.patch queue-4.4/alsa-hda-add-support-for-docking-station-for-hp-840-g3.patch queue-4.4/alsa-hda-clear-the-leftover-component-assignment-at-snd_hdac_i915_exit.patch queue-4.4/alsa-hda-fix-yet-another-i915-pointer-leftover-in-error-path.patch