Skip to contentSkip to conversation

Staging: vt6656: fix unnecessary parantheses

PATCH In review Sumit Pundir 2 participants 2 messages Dec 22, 2017 – Jan 8, 2018 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: vt6656: fix unnecessary parantheses

This patch fixes a coding style issue as noted by
checkpatch.pl related to unnecessary parentheses.

This patch fixes the following checkpatch.pl warning:

WARNING: Unnecessary parentheses around 'priv->basic_rates'.

---
 drivers/staging/vt6656/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/card.c +1 -1
index 501f482..811602e 100644
@@ -443,7 +443,7 @@ int vnt_ofdm_min_rate(struct vnt_private *priv)
 	int ii;
 
 	for (ii = RATE_54M; ii >= RATE_6M; ii--) {
-		if ((priv->basic_rates) & ((u16)BIT(ii)))
+		if (priv->basic_rates & ((u16)BIT(ii)))
 			return true;
 	}
 

--
2.7.4

maintainer
#1 lore raw
Quoted 17 lines · Sumit Pundir

This patch fixes a coding style issue as noted by
checkpatch.pl related to unnecessary parentheses.

This patch fixes the following checkpatch.pl warning:

WARNING: Unnecessary parentheses around 'priv->basic_rates'.

---
 drivers/staging/vt6656/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6656/card.c +0 -0
index 501f482..811602e 100644

drivers/staging/vt6656/card.c int vnt_ofdm_min_rate(struct vnt_private *priv) · line 446

Quoted 5 lines
drivers/staging/vt6656/card.c +1 -1
@@ -443,7 +443,7 @@ int vnt_ofdm_min_rate(struct vnt_private *priv)
 	int ii;
 
 	for (ii = RATE_54M; ii >= RATE_6M; ii--) {
-		if ((priv->basic_rates) & ((u16)BIT(ii)))
+		if (priv->basic_rates & ((u16)BIT(ii)))

You still have one too many () around the BIT stuff...