Patch "drm/sun4i: Fix error path handling" has been added to the 4.14-stable tree
Subsystems (5)
This is a note to let you know that I've just added the patch titled
drm/sun4i: Fix error path handling
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-sun4i-fix-error-path-handling.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
92411f6d7f1afcc95e54295d40e96a75385212ecMon Sep 17 00:00:00 2001
From: Maxime Ripard <[email protected]>
Date: Thu, 7 Dec 2017 16:58:50 +0100
Subject: drm/sun4i: Fix error path handling
From: Maxime Ripard <[email protected]>
commit 92411f6d7f1afcc95e54295d40e96a75385212ec upstream.
The commit 4c7f16d14a33 ("drm/sun4i: Fix TCON clock and regmap initialization sequence") moved a bunch of logic around, but forgot to update the gotos after the introduction of the err_free_dotclock label.
It means that if we fail later that the one introduced in that commit, we'll just to the old label which isn't free the clock we created. This will result in a breakage as soon as someone tries to do something with that clock, since its resources will have been long reclaimed.
--- drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/sun4i/sun4i_tcon.c +2 -2
@@ -567,12 +567,12 @@ static int sun4i_tcon_bind(struct deviceif (IS_ERR (tcon->crtc)) {dev_err (dev,"Couldn't create our CRTC\n" ); ret =PTR_ERR (tcon->crtc); - goto err_free_clocks; + goto err_free_dotclock; } ret =sun4i_rgb_init (drm, tcon);if (ret <0 ) - goto err_free_clocks; + goto err_free_dotclock;list_add_tail (&tcon->list, &drv->tcon_list);
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/drm-sun4i-fix-error-path-handling.patch queue-4.14/clk-sunxi-sun9i-mmc-implement-reset-callback-for-reset-controls.patch