Skip to contentSkip to conversation

uboot-tools: fix dtc invocation

PATCH New yegorslists at googlemail.com 4 participants 5 messages Dec 1, 2017 – Dec 27, 2017

lore
Share & tools
lore

yegorslists at googlemail.com

author
#0 lore raw

PATCH v2 1/1 uboot-tools: fix dtc invocation

From: Yegor Yefremov <[email protected]>

Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR skips this step for uboot-tools building one has to provide CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line. Otherwise mkimage will not be able to create FIT images, i.e.:

mkimage -f kernel-fit.its kernel-fit.itb

Signed-off-by Yegor Yefremov <[email protected]>

---
Changes v1 -> v2:
- pass CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line instead of patching the Makefile (suggested by Thomas Petazzoni)

 package/uboot-tools/uboot-tools.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/uboot-tools/uboot-tools.mk +2 -2
index 04b526883f..4c559185af 100644
@@ -22,7 +22,7 @@ UBOOT_TOOLS_MAKE_OPTS = CROSS_COMPILE="$(TARGET_CROSS)" \
 	STRIP=$(TARGET_STRIP)
 
 ifeq ($(BR2_PACKAGE_UBOOT_TOOLS_FIT_SUPPORT),y)
-UBOOT_TOOLS_MAKE_OPTS += CONFIG_FIT=y
+UBOOT_TOOLS_MAKE_OPTS += CONFIG_FIT=y CONFIG_MKIMAGE_DTC_PATH=dtc
 UBOOT_TOOLS_DEPENDENCIES += dtc
 endif
 

@@ -85,7 +85,7 @@ HOST_UBOOT_TOOLS_MAKE_OPTS = HOSTCC="$(HOSTCC)" \
 	HOSTLDFLAGS="$(HOST_LDFLAGS)"
 
 ifeq ($(BR2_PACKAGE_HOST_UBOOT_TOOLS_FIT_SUPPORT),y)
-HOST_UBOOT_TOOLS_MAKE_OPTS += CONFIG_FIT=y
+HOST_UBOOT_TOOLS_MAKE_OPTS += CONFIG_FIT=y CONFIG_MKIMAGE_DTC_PATH=dtc
 HOST_UBOOT_TOOLS_DEPENDENCIES += host-dtc
 endif
Signature · 1 line
2.11.0
Applied
#1 lore raw

PATCH v2 1/1 uboot-tools: fix dtc invocation

Hello,

Quoted 7 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>

Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR skips this step for uboot-tools building one has to provide CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line. Otherwise mkimage will not be able to create FIT images, i.e.:

Quoted 7 lines

mkimage -f kernel-fit.its kernel-fit.itb

Signed-off-by Yegor Yefremov <[email protected]>

---
Changes v1 -> v2:
- pass CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line instead of patching the Makefile (suggested by Thomas Petazzoni)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 uboot-tools: fix dtc invocation

In reply to yegorslists at googlemail.com
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"yegorslists" == yegorslists <[email protected]> writes:

From: Yegor Yefremov <[email protected]>
Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR skips this step for uboot-tools building one has to provide CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line. Otherwise mkimage will not be able to create FIT images, i.e.:

Quoted 7 lines

mkimage -f kernel-fit.its kernel-fit.itb

Signed-off-by Yegor Yefremov <[email protected]>

---
Changes v1 -> v2:
- pass CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line instead of patching the Makefile (suggested by Thomas Petazzoni)

Committed to 2017.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH v2 1/1 uboot-tools: fix dtc invocation

Quoted 4 lines · Peter Korsgaard
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"yegorslists" == yegorslists <[email protected]> writes:

From: Yegor Yefremov <[email protected]>
Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR

This isn't quite right, the change to u-boot that pulls in the dtc path via a Kconfig setting was part of uboot 2017.11-rc1. The version of u- boot tools in buildroot 2017.11.x, uboot 2017.09, does not have the change and works correctly without this patch.

However, the patch does no harm: it just supplies an unused variable on the command line.

Quoted 4 lines
Quoted 3 lines

skips this step for uboot-tools building one has to provide CONFIG_MKIMAGE_DTC_PATH=dtc on the build command line. Otherwise mkimage will not be able to create FIT images, i.e.:

#4 lore raw

PATCH v2 1/1 uboot-tools: fix dtc invocation

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Trent" == Trent Piepho <[email protected]> writes:

Quoted 4 lines · Peter Korsgaard
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"yegorslists" == yegorslists <[email protected]> writes:

From: Yegor Yefremov <[email protected]>
Since uboot 2017.09 path to dtc will be configured via Kconfig. As BR

Quoted 7 lines

This isn't quite right, the change to u-boot that pulls in the dtc path via a Kconfig setting was part of uboot 2017.11-rc1. The version of u- boot tools in buildroot 2017.11.x, uboot 2017.09, does not have the change and works correctly without this patch.

However, the patch does no harm: it just supplies an unused variable on the command line.

Ahh, ok - Thanks for the heads up.

Signature · 1 line
Bye, Peter Korsgaard