Skip to contentSkip to conversation

i2c: ismt: Use %pad specifier for dma_addr_t variables

PATCH Applied Andy Shevchenko 3 participants 6 messages Nov 10, 2017 – Jan 4, 2018

Subsystems (2)
I2C subsystem host drivers I2C/smbus ismt driver
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 i2c: ismt: Use %pad specifier for dma_addr_t variables

...which takes care of proper format and size of the value.

Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/i2c/busses/i2c-ismt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/busses/i2c-ismt.c +1 -2
index b51adffa4841..c0d0f34d34f3 100644
@@ -572,8 +572,7 @@ static int ismt_access(struct i2c_adapter *adap, u16 addr,
 			return -EIO;
 		}
 
-		dev_dbg(dev, " dma_addr = 0x%016llX\n",
-			(unsigned long long)dma_addr);
+		dev_dbg(dev, " dma_addr = %pad\n", &dma_addr);
 
 		desc->dptr_low = lower_32_bits(dma_addr);
 		desc->dptr_high = upper_32_bits(dma_addr);
Signature · 1 line
2.14.2
author
#1 lore raw
Quoted 1 line · Andy Shevchenko

...which takes care of proper format and size of the value.

Wolfram, any comment on this?

Quoted 22 lines
Signed-off-by Andy Shevchenko <[email protected]>
---
 drivers/i2c/busses/i2c-ismt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/i2c/busses/i2c- renamed from drivers/i2c/busses/i2c-ismt.c +0 -0

ismt.c
index b51adffa4841..c0d0f34d34f3 100644

drivers/i2c/busses/i2c-ismt.c +1 -2
@@ -572,8 +572,7 @@ static int ismt_access(struct i2c_adapter *adap,
 u16 addr,
 			return -EIO;
 		}
 
-		dev_dbg(dev, " dma_addr = 0x%016llX\n",
-			(unsigned long long)dma_addr);
+		dev_dbg(dev, " dma_addr = %pad\n", &dma_addr);
 
 		desc->dptr_low = lower_32_bits(dma_addr);

desc->dptr_high = upper_32_bits(dma_addr);

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
Applied
#2 lore raw
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

...which takes care of proper format and size of the value.

Wolfram, any comment on this?

I was leaving this for the driver maintainers, but well, this is an easy one, so...

Quoted 3 lines
Quoted 3 lines
Signed-off-by Andy Shevchenko <[email protected]>

Applied to for-next, thanks!

maintainer Acked-by
#3 lore raw
Quoted 6 lines · Wolfram Sang
Quoted 4 lines · Andy Shevchenko
Quoted 1 line · Andy Shevchenko

...which takes care of proper format and size of the value.

Wolfram, any comment on this?

Quoted 9 lines

I was leaving this for the driver maintainers, but well, this is an easy one, so...

Quoted 3 lines
Quoted 3 lines
Signed-off-by Andy Shevchenko <[email protected]>

Applied to for-next, thanks!

Sorry for the delay, I was on holiday. FWIW

Acked-by Neil Horman <[email protected]>