Skip to contentSkip to conversation

xen/input: do not advertise multi-touch pressure support

PATCH Applied Oleksandr Andrushchenko 2 participants 3 messages Jan 2, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/input: do not advertise multi-touch pressure support

From: Oleksandr Andrushchenko <[email protected]>

Some user-space applications expect multi-touch pressure on contact to be reported if it is advertised in device properties. Otherwise, such applications may treat reports not as actual touches, but hovering. Currently this is only advertised, but not reported.
Fix this by not advertising that ABS_MT_PRESSURE is supported.

---
 drivers/input/misc/xen-kbdfront.c | 2 --
 1 file changed, 2 deletions(-)
drivers/input/misc/xen-kbdfront.c +0 -2
index 6bf56bb5f8d9..d91f3b1c5375 100644
@@ -326,8 +326,6 @@ static int xenkbd_probe(struct xenbus_device *dev,
 				     0, width, 0, 0);
 		input_set_abs_params(mtouch, ABS_MT_POSITION_Y,
 				     0, height, 0, 0);
-		input_set_abs_params(mtouch, ABS_MT_PRESSURE,
-				     0, 255, 0, 0);
 
 		ret = input_mt_init_slots(mtouch, num_cont, INPUT_MT_DIRECT);
 		if (ret) {
Signature · 1 line
2.7.4
maintainer Applied
#1 lore raw
Quoted 11 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Some user-space applications expect multi-touch pressure on contact to be reported if it is advertised in device properties. Otherwise, such applications may treat reports not as actual touches, but hovering. Currently this is only advertised, but not reported.
Fix this by not advertising that ABS_MT_PRESSURE is supported.

Applied, thank you.

Quoted 20 lines
---
 drivers/input/misc/xen-kbdfront.c | 2 --
 1 file changed, 2 deletions(-)
drivers/input/misc/xen-kbdfront.c +0 -2
index 6bf56bb5f8d9..d91f3b1c5375 100644
@@ -326,8 +326,6 @@ static int xenkbd_probe(struct xenbus_device *dev,
 				     0, width, 0, 0);
 		input_set_abs_params(mtouch, ABS_MT_POSITION_Y,
 				     0, height, 0, 0);
-		input_set_abs_params(mtouch, ABS_MT_PRESSURE,
-				     0, 255, 0, 0);
 
 		ret = input_mt_init_slots(mtouch, num_cont, INPUT_MT_DIRECT);
 		if (ret) {
Signature · 1 line
2.7.4
Signature · 1 line
Dmitry
maintainer Applied
#2 lore raw
In reply to Oleksandr Andrushchenko
Quoted 11 lines · Oleksandr Andrushchenko

From: Oleksandr Andrushchenko <[email protected]>

Some user-space applications expect multi-touch pressure on contact to be reported if it is advertised in device properties. Otherwise, such applications may treat reports not as actual touches, but hovering. Currently this is only advertised, but not reported.
Fix this by not advertising that ABS_MT_PRESSURE is supported.

Applied, thank you.

Quoted 20 lines
---
 drivers/input/misc/xen-kbdfront.c | 2 --
 1 file changed, 2 deletions(-)
drivers/input/misc/xen-kbdfront.c +0 -2
index 6bf56bb5f8d9..d91f3b1c5375 100644
@@ -326,8 +326,6 @@ static int xenkbd_probe(struct xenbus_device *dev,
 				     0, width, 0, 0);
 		input_set_abs_params(mtouch, ABS_MT_POSITION_Y,
 				     0, height, 0, 0);
-		input_set_abs_params(mtouch, ABS_MT_PRESSURE,
-				     0, 255, 0, 0);
 
 		ret = input_mt_init_slots(mtouch, num_cont, INPUT_MT_DIRECT);
 		if (ret) {
Signature · 1 line
2.7.4
Signature · 6 lines
Dmitry

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel