igt/kms-crc-rotation: Fix flip subtests to follow kms guidelines.
PATCH 1/1 igt/kms-crc-rotation: Fix flip subtests to follow kms guidelines.
Fix flip subtest that used plaform names in igt_require() instead of testing if rotation property is supported on given combination of rotation/flips.
--- tests/kms_rotation_crc.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
tests/kms_rotation_crc.c +1 -6
@@ -394,9 +394,6 @@ static void __test_plane_rotation(data_t *data, int plane_type, bool test_bad_foigt_plane_t *plane;int i; -if (IS_CHERRYVIEW (data->devid) && pipe !=PIPE_B ) -continue ; -igt_output_set_pipe (output, pipe); plane =igt_output_get_plane_type (output, plane_type);
@@ -837,9 +834,7 @@ igt_main tiling_test_str(reflect_x->tiling), rot_test_str(reflect_x->rot), flip_test_str(reflect_x->flips)) { -igt_require (gen >=10 || - (IS_CHERRYVIEW (data.devid) && reflect_x->rot ==IGT_ROTATION_0 - && reflect_x->tiling ==LOCAL_I915_FORMAT_MOD_X_TILED )); +igt_require (subtest->flips); data.rotation = (IGT_REFLECT_X | reflect_x->rot); data.override_tiling = reflect_x->tiling; data.flips = reflect_x->flips;
Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for igt/kms-crc-rotation: Fix flip subtests to follow kms guidelines.
== Series Details ==
== Series Details ==
Series: igt/kms-crc-rotation: Fix flip subtests to follow kms guidelines.
URL : https://patchwork.freedesktop.org/series/36246/
State : success
== Summary ==
IGT patchset tested on top of latest successful build 834321a5d76a16783000441a02d7e79e72be9cc9 tools: Cannonlake port clock programming
with latest DRM-Tip kernel build CI_DRM_3617c6410238e3c4 drm-tip: 2018y-01m-09d-18h-59m-27s UTC integration manifest
No testlist changes.
Test debugfs_test:
Subgroup read_all_entries:
dmesg-fail -> DMESG-WARN (fi-elk-e7500) fdo#103989
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
dmesg-warn -> PASS (fi-kbl-r) fdo#104172 +1
Subgroup suspend-read-crc-pipe-b:
pass -> INCOMPLETE (fi-snb-2520m) fdo#103713
Subgroup suspend-read-crc-pipe-c:
fail -> PASS (fi-skl-6700k2) fdo#104108fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104172 https://bugs.freedesktop.org/show_bug.cgi?id=104172
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:423s fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:427s fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:373s fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:492s fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:284s fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:485s fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:488s fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:470s fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:461s fi-elk-e7500 total:224 pass:168 dwarn:10 dfail:0 fail:0 skip:45 fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:275s fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:515s fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:394s fi-hsw-4770r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:401s fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:416s fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:471s fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:414s fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:462s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:501s fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:456s fi-kbl-r total:288 pass:260 dwarn:1 dfail:0 fail:0 skip:27 time:501s fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:580s fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:437s fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:509s fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:530s fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:495s fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:488s fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:434s fi-snb-2520m total:245 pass:211 dwarn:0 dfail:0 fail:0 skip:33 fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:406s Blacklisted hosts: fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:580s fi-cnl-y2 total:288 pass:258 dwarn:3 dfail:0 fail:0 skip:27 time:534s fi-glk-dsi total:288 pass:169 dwarn:1 dfail:4 fail:0 skip:114 time:304s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_763/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for igt/kms-crc-rotation: Fix flip subtests to follow kms guidelines.
In reply to Anusha Srivatsa== Series Details ==
== Series Details ==
Series: igt/kms-crc-rotation: Fix flip subtests to follow kms guidelines.
URL : https://patchwork.freedesktop.org/series/36246/
State : success
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS (shard-snb) fdo#101623 +1
Test gem_tiled_swapping:
Subgroup non-threaded:
pass -> INCOMPLETE (shard-snb) fdo#104218
Test kms_flip:
Subgroup flip-vs-absolute-wf_vblank-interruptible:
fail -> PASS (shard-hsw) fdo#100368fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#104218 https://bugs.freedesktop.org/show_bug.cgi?id=104218
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
shard-hsw total:2688 pass:1523 dwarn:1 dfail:0 fail:10 skip:1152 time:8451s shard-snb total:2677 pass:1294 dwarn:1 dfail:0 fail:10 skip:1369 time:7113s
Blacklisted hosts:
shard-apl total:2688 pass:1668 dwarn:1 dfail:0 fail:25 skip:991 time:12827s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_763/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 27 lines · Anusha Srivatsa
Fix flip subtest that used plaform names in
igt_require()instead of testing if rotation property is supported on given combination of rotation/flips.Suggested-by Daniel VetterCc Daniel Vetter <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>--- tests/kms_rotation_crc.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)tests/kms_rotation_crc.c +0
-3@@ -394,9 +394,6 @@ static void __test_plane_rotation(data_t *data, int plane_type, bool test_bad_foigt_plane_t *plane;int i; -if (IS_CHERRYVIEW (data->devid) && pipe !=PIPE_B ) -continue ; -igt_output_set_pipe (output, pipe); plane =igt_output_get_plane_type (output, plane_type);
tests/kms_rotation_crc.c igt_main · line 842
Quoted 6 lines
tests/kms_rotation_crc.c +0
-3@@ -837,9 +834,7 @@ igt_main tiling_test_str(reflect_x->tiling), rot_test_str(reflect_x->rot), flip_test_str(reflect_x->flips)) { -igt_require (gen >=10 || - (IS_CHERRYVIEW (data.devid) && reflect_x->rot ==IGT_ROTATION_0 - && reflect_x->tiling ==LOCAL_I915_FORMAT_MOD_X_TILED ));
This isn't what I meant, and I also just realized that the rotation subtests also hardcodes this.
Instead what you need to do in both cases is to read the possible values for the ROTATION property, and skip if not everything you need is supported.
The other subtest check that needs to be fixed is
igt_require(!(subtest->rot & (IGT_ROTATION_90 | IGT_ROTATION_270)) || gen >= 9);
It's convoluted, but essentially what this does is skip 90/270 rotation tests on pre-gen9.
Part of the checks are there already, see
igt_require(igt_plane_has_prop(plane, IGT_PLANE_ROTATION));
But this isn't complete - we only check whether the property exists, not whether it supports all the different rotation/reflect modes we want to test.
tests/kms_rotation_crc.c igt_main · line 837
Quoted 1 line
tests/kms_rotation_crc.c +1
-0+igt_require (subtest->flips);
This check here simply skips all the tests where we don't flip, which is probably not quite what you had in mind I think. Did you test this and compare results before/after on a machine where this test actually runs? -Daniel
Quoted 10 lines
tests/kms_rotation_crc.c +0
-0data.rotation = (IGT_REFLECT_X | reflect_x->rot); data.override_tiling = reflect_x->tiling; data.flips = reflect_x->flips;Signature · 6 lines
2.7.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx