drm/i915/guc: Don't enable GuC when vGPU is active
Subsystems (2)
PATCH 1/2 drm/i915/guc: Don't enable GuC when vGPU is active
In GVT-g, if GuC is to be used it is to be loaded by Host and not by VM/vGPU. Currently, GVT-g host is not supported with GuC submission. Also currently vGPU is to be not supported with GuC submission AFAIK. CI BAT highlighted GuC init issue on skl-gvtdvm due to lack of movntdqa needed for logging with below warning:
WARN_ON(!i915_memcpy_from_wc(((void *)0), ((void *)0), 0))
WARNING: CPU: 0 PID: 216 at drivers/gpu/drm/i915/intel_guc_log.c:383
This patch disables GuC when vGPU is active.
--- drivers/gpu/drm/i915/intel_uc.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_uc.c +2 -0
@@ -61,6 +61,8 @@ static int __get_platform_enable_guc(struct drm_i915_private *dev_priv) enable_guc |=ENABLE_GUC_LOAD_HUC ;/* Any platform specific fine-tuning can be done here */ +if (intel_vgpu_active (dev_priv)) + enable_guc =0 ;return enable_guc; }
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 HAX: drm/i915/uc: Enable GuC/HuC for CI
--- drivers/gpu/drm/i915/i915_params.c | 2 +- drivers/gpu/drm/i915/i915_params.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_params.c +1 -1
@@ -152,7 +152,7 @@ struct i915_params i915_modparams __read_mostly = {i915_param_named_unsafe (enable_guc, int,0400 ,"Enable GuC load for GuC submission and/or HuC load. " "Required functionality can be selected using bitmask values. " -"(-1=auto, 0=disable [default], 1=GuC submission, 2=HuC load)" ); +"(-1=auto [default], 0=disable, 1=GuC submission, 2=HuC load)" );i915_param_named (guc_log_level, int,0400 ,"GuC firmware logging level (-1:disabled (default), 0-3:enabled)" );
drivers/gpu/drm/i915/i915_params.h +1 -1
@@ -47,7 +47,7 @@ param(int, disable_power_well, -1) \ param(int, enable_ips, 1) \ param(int, invert_brightness, 0) \ - param(int, enable_guc, 0) \ + param(int, enable_guc, -1) \ param(int, guc_log_level, -1) \ param(char *, guc_firmware_path, NULL) \param (char *, huc_firmware_path, NULL) \
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
In reply to Sagar Arun Kamble== Series Details ==
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
URL : https://patchwork.freedesktop.org/series/36343/
State : failure
== Summary ==
Series 36343v1 series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/
Test core_auth:
Subgroup basic-auth:
pass -> SKIP (fi-skl-gvtdvm)
Test core_prop_blob:
Subgroup basic:
pass -> SKIP (fi-skl-gvtdvm)
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989
pass -> SKIP (fi-skl-gvtdvm)
Test drv_getparams_basic:
Subgroup basic-eu-total:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-subslice-total:
pass -> SKIP (fi-skl-gvtdvm)
Test drv_hangman:
Subgroup error-state-basic:
pass -> SKIP (fi-skl-gvtdvm)
Test gem_basic:
Subgroup bad-close:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup create-close:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup create-fd-close:
pass -> SKIP (fi-skl-gvtdvm)
Test gem_busy:
Subgroup basic-busy-default:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-hang-default:
pass -> SKIP (fi-skl-gvtdvm) fdo#104108 +2
Test gem_close_race:
Subgroup basic-process:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-threads:
pass -> SKIP (fi-skl-gvtdvm)
Test gem_cpu_reloc:
Subgroup basic:
pass -> SKIP (fi-skl-gvtdvm)
Test gem_cs_tlb:
Subgroup basic-default:
pass -> SKIP (fi-skl-gvtdvm)
Test gem_ctx_create:
Subgroup basic:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-files:
pass -> SKIP (fi-skl-gvtdvm)
Test gem_ctx_exec:
Subgroup basic:
pass -> SKIP (fi-skl-gvtdvm)
Test gem_ctx_param:
Subgroup basic:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-default:
pass -> SKIP (fi-skl-gvtdvm)
Test gem_ctx_switch:
Subgroup basic-default:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-default-heavy:
pass -> SKIP (fi-skl-gvtdvm)
Test gem_exec_basic:
Subgroup basic-blt:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-bsd:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-bsd1:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-bsd2:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-default:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-render:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup basic-vebox:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup gtt-blt:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup gtt-bsd:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup gtt-bsd1:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup gtt-bsd2:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup gtt-default:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup gtt-render:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup gtt-vebox:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup readonly-blt:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup readonly-bsd:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup readonly-bsd1:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup readonly-bsd2:
pass -> SKIP (fi-skl-gvtdvm)
Subgroup readonly-default:WARNING: Long output truncated
da4321c7c088d01ad62b18d37dcfe5ef8d0b855d drm-tip: 2018y-01m-11d-14h-59m-37s UTC integration manifest a0e8e84432b0 HAX: drm/i915/uc: Enable GuC/HuC for CI973357da236a drm/i915/guc: Don't enable GuC when vGPU is active
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Is skl-gvtdvm not having vGPU active?
It has flag X86_FEATURE_HYPERVISOR set however it might be set on host too so relying intel_vgpu_active().
Quoted 110 lines · Patchwork
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
URL : https://patchwork.freedesktop.org/series/36343/
State : failure== Summary ==
Series 36343v1 series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/Test
core_auth:Subgroup basic-auth: pass -> SKIP (fi-skl-gvtdvm) Test core_prop_blob: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989 pass -> SKIP (fi-skl-gvtdvm) Test drv_getparams_basic: Subgroup basic-eu-total: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-subslice-total: pass -> SKIP (fi-skl-gvtdvm) Test drv_hangman: Subgroup error-state-basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_basic: Subgroup bad-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-fd-close: pass -> SKIP (fi-skl-gvtdvm) Test gem_busy: Subgroup basic-busy-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-hang-default: pass -> SKIP (fi-skl-gvtdvm) fdo#104108 +2 Test gem_close_race: Subgroup basic-process: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-threads: pass -> SKIP (fi-skl-gvtdvm) Test gem_cpu_reloc: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_cs_tlb: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_create: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-files: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_exec: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_param: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_switch: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default-heavy: pass -> SKIP (fi-skl-gvtdvm) Test gem_exec_basic: Subgroup basic-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-default:WARNING: Long output truncated
Quoted 7 lines
da4321c7c088d01ad62b18d37dcfe5ef8d0b855ddrm-tip: 2018y-01m-11d-14h-59m-37s UTC integration manifesta0e8e84432b0HAX: drm/i915/uc: Enable GuC/HuC for CI973357da236adrm/i915/guc: Don't enable GuC when vGPU is active== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Quoted 5 lines · Sagar Arun Kamble
Is skl-gvtdvm not having vGPU active?
It has flag
X86_FEATURE_HYPERVISORset however it might be set on host too so relyingintel_vgpu_active().
Do you mean flag X86_FEATURE_HYPERVISOR is set on host, too? This is weird since this flag indicates the OS is running on a hypervisor.
Quoted 120 lines · Patchwork
Quoted 117 lines
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
URL : https://patchwork.freedesktop.org/series/36343/
State : failure== Summary ==
Series 36343v1 series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/Test
core_auth:Subgroup basic-auth: pass -> SKIP (fi-skl-gvtdvm) Test core_prop_blob: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989 pass -> SKIP (fi-skl-gvtdvm) Test drv_getparams_basic: Subgroup basic-eu-total: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-subslice-total: pass -> SKIP (fi-skl-gvtdvm) Test drv_hangman: Subgroup error-state-basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_basic: Subgroup bad-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-fd-close: pass -> SKIP (fi-skl-gvtdvm) Test gem_busy: Subgroup basic-busy-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-hang-default: pass -> SKIP (fi-skl-gvtdvm) fdo#104108 +2 Test gem_close_race: Subgroup basic-process: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-threads: pass -> SKIP (fi-skl-gvtdvm) Test gem_cpu_reloc: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_cs_tlb: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_create: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-files: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_exec: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_param: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_switch: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default-heavy: pass -> SKIP (fi-skl-gvtdvm) Test gem_exec_basic: Subgroup basic-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-default:WARNING: Long output truncated
da4321c7c088d01ad62b18d37dcfe5ef8d0b855ddrm-tip: 2018y-01m-11d-14h-59m-37s UTC integration manifesta0e8e84432b0HAX: drm/i915/uc: Enable GuC/HuC for CI973357da236adrm/i915/guc: Don't enable GuC when vGPU is active== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
Signature · 6 lines
Thanks, Changbin Du _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Joonas Lahtinen
maintainerRe: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Quoted 9 lines · Changbin
Quoted 5 lines · Sagar Arun Kamble
Is skl-gvtdvm not having vGPU active?
It has flag
X86_FEATURE_HYPERVISORset however it might be set on host too so relyingintel_vgpu_active().Do you mean flag
X86_FEATURE_HYPERVISORis set on host, too? This is weird since this flag indicates the OS is running on a hypervisor.
+ CI folks and Zhenyu
Somehow, magically, the virtual machine seems to starts skipping all tests when GuC is disabled?
Has somebody actually validated that the tests results are valid for the virtual machine? Or is this a one-off CI quirk?
PS. I'd do the check as early return condition at the top, like vGPU feature disabling elsewhere. It's not much point calculating the details (calling into functions like intel_uc_fw_is_selected) and then throwing results out afterwards :)
Quoted 122 lines
Quoted 120 lines · Patchwork
Quoted 117 lines
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
URL : https://patchwork.freedesktop.org/series/36343/
State : failure== Summary ==
Series 36343v1 series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/Test
core_auth:Subgroup basic-auth: pass -> SKIP (fi-skl-gvtdvm) Test core_prop_blob: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989 pass -> SKIP (fi-skl-gvtdvm) Test drv_getparams_basic: Subgroup basic-eu-total: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-subslice-total: pass -> SKIP (fi-skl-gvtdvm) Test drv_hangman: Subgroup error-state-basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_basic: Subgroup bad-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-fd-close: pass -> SKIP (fi-skl-gvtdvm) Test gem_busy: Subgroup basic-busy-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-hang-default: pass -> SKIP (fi-skl-gvtdvm) fdo#104108 +2 Test gem_close_race: Subgroup basic-process: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-threads: pass -> SKIP (fi-skl-gvtdvm) Test gem_cpu_reloc: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_cs_tlb: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_create: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-files: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_exec: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_param: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_switch: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default-heavy: pass -> SKIP (fi-skl-gvtdvm) Test gem_exec_basic: Subgroup basic-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-default:WARNING: Long output truncated
da4321c7c088d01ad62b18d37dcfe5ef8d0b855ddrm-tip: 2018y-01m-11d-14h-59m-37s UTC integration manifesta0e8e84432b0HAX: drm/i915/uc: Enable GuC/HuC for CI973357da236adrm/i915/guc: Don't enable GuC when vGPU is active== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Quoted 11 lines · Joonas Lahtinen
Quoted 9 lines · Changbin
Quoted 5 lines · Sagar Arun Kamble
Is skl-gvtdvm not having vGPU active?
It has flag
X86_FEATURE_HYPERVISORset however it might be set on host too so relyingintel_vgpu_active().Do you mean flag
X86_FEATURE_HYPERVISORis set on host, too? This is weird since this flag indicates the OS is running on a hypervisor.
Quoted 7 lines
+ CI folks and Zhenyu
Somehow, magically, the virtual machine seems to starts skipping all tests when GuC is disabled?
Has somebody actually validated that the tests results are valid for the virtual machine? Or is this a one-off CI quirk?
Are these tests really run in VM with GVT-g enabled on host?
Quoted 6 lines
PS. I'd do the check as early return condition at the top, like vGPU feature disabling elsewhere. It's not much point calculating the details (calling into functions like
intel_uc_fw_is_selected) and then throwing results out afterwards :)
yeah, better, and we do plan to support vGuC from ICL for vGPU.
Quoted 126 lines
Quoted 122 lines
Quoted 120 lines · Patchwork
Quoted 117 lines
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
URL : https://patchwork.freedesktop.org/series/36343/
State : failure== Summary ==
Series 36343v1 series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/Test
core_auth:Subgroup basic-auth: pass -> SKIP (fi-skl-gvtdvm) Test core_prop_blob: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989 pass -> SKIP (fi-skl-gvtdvm) Test drv_getparams_basic: Subgroup basic-eu-total: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-subslice-total: pass -> SKIP (fi-skl-gvtdvm) Test drv_hangman: Subgroup error-state-basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_basic: Subgroup bad-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-fd-close: pass -> SKIP (fi-skl-gvtdvm) Test gem_busy: Subgroup basic-busy-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-hang-default: pass -> SKIP (fi-skl-gvtdvm) fdo#104108 +2 Test gem_close_race: Subgroup basic-process: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-threads: pass -> SKIP (fi-skl-gvtdvm) Test gem_cpu_reloc: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_cs_tlb: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_create: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-files: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_exec: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_param: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_switch: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default-heavy: pass -> SKIP (fi-skl-gvtdvm) Test gem_exec_basic: Subgroup basic-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-default:WARNING: Long output truncated
da4321c7c088d01ad62b18d37dcfe5ef8d0b855ddrm-tip: 2018y-01m-11d-14h-59m-37s UTC integration manifesta0e8e84432b0HAX: drm/i915/uc: Enable GuC/HuC for CI973357da236adrm/i915/guc: Don't enable GuC when vGPU is active== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
Signature · 3 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation
Signature · 3 lines
Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Quoted 14 lines · Zhenyu Wang
Quoted 13 lines · Joonas Lahtinen
Quoted 9 lines · Changbin
Quoted 5 lines · Sagar Arun Kamble
Is skl-gvtdvm not having vGPU active?
It has flag
X86_FEATURE_HYPERVISORset however it might be set on host too so relyingintel_vgpu_active().Do you mean flag
X86_FEATURE_HYPERVISORis set on host, too? This is weird since this flag indicates the OS is running on a hypervisor.+ CI folks and Zhenyu
Quoted 7 lines
Quoted 5 lines
Somehow, magically, the virtual machine seems to starts skipping all tests when GuC is disabled?
Has somebody actually validated that the tests results are valid for the virtual machine? Or is this a one-off CI quirk?
Are these tests really run in VM with GVT-g enabled on host?
These tests are ran on VM running on GVT-d (as name implies), not GVT-g.
Tomi
Quoted 6 lines
Quoted 5 lines
PS. I'd do the check as early return condition at the top, like vGPU feature disabling elsewhere. It's not much point calculating the details (calling into functions like
intel_uc_fw_is_selected) and then throwing results out afterwards :)
Quoted 129 lines
yeah, better, and we do plan to support vGuC from ICL for vGPU.
Quoted 126 lines
Quoted 122 lines
Quoted 120 lines · Patchwork
Quoted 117 lines
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
URL : https://patchwork.freedesktop.org/series/36343/
State : failure== Summary ==
Series 36343v1 series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/Test
core_auth:Subgroup basic-auth: pass -> SKIP (fi-skl-gvtdvm) Test core_prop_blob: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989 pass -> SKIP (fi-skl-gvtdvm) Test drv_getparams_basic: Subgroup basic-eu-total: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-subslice-total: pass -> SKIP (fi-skl-gvtdvm) Test drv_hangman: Subgroup error-state-basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_basic: Subgroup bad-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-fd-close: pass -> SKIP (fi-skl-gvtdvm) Test gem_busy: Subgroup basic-busy-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-hang-default: pass -> SKIP (fi-skl-gvtdvm) fdo#104108 +2 Test gem_close_race: Subgroup basic-process: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-threads: pass -> SKIP (fi-skl-gvtdvm) Test gem_cpu_reloc: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_cs_tlb: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_create: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-files: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_exec: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_param: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_switch: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default-heavy: pass -> SKIP (fi-skl-gvtdvm) Test gem_exec_basic: Subgroup basic-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-default:WARNING: Long output truncated
da4321c7c088d01ad62b18d37dcfe5ef8d0b855ddrm-tip: 2018y-01m-11d-14h-59m-37s UTC integration manifesta0e8e84432b0HAX: drm/i915/uc: Enable GuC/HuC for CI973357da236adrm/i915/guc: Don't enable GuC when vGPU is active== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
Signature · 3 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation
Tomi
Signature · 5 lines
Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Joonas Lahtinen
maintainerRe: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Quoted 18 lines · Tomi Sarvela
Quoted 17 lines · Zhenyu Wang
Quoted 16 lines · Joonas Lahtinen
Quoted 9 lines · Changbin
Quoted 5 lines · Sagar Arun Kamble
Is skl-gvtdvm not having vGPU active?
It has flag
X86_FEATURE_HYPERVISORset however it might be set on host too so relyingintel_vgpu_active().Do you mean flag
X86_FEATURE_HYPERVISORis set on host, too? This is weird since this flag indicates the OS is running on a hypervisor.+ CI folks and Zhenyu
Somehow, magically, the virtual machine seems to starts skipping all tests when GuC is disabled?
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Has somebody actually validated that the tests results are valid for the virtual machine? Or is this a one-off CI quirk?
Are these tests really run in VM with GVT-g enabled on host?
These tests are ran on VM running on GVT-d (as name implies), not GVT-g.
I don't still understand how explicitly disabling GuC could make all the tests skip on a machine that didn't use GuC to begin with. There must be something wrong in the initialization code.
That intel_vgpu_active() check by my logic should not trigger in GVT-d (because we don't have virtual GPU, we have the real deal, just without stolen etc.), so I'm bit baffled.
Regards, Joonas
Quoted 141 lines
Tomi
Quoted 6 lines
Quoted 5 lines
PS. I'd do the check as early return condition at the top, like vGPU feature disabling elsewhere. It's not much point calculating the details (calling into functions like
intel_uc_fw_is_selected) and then throwing results out afterwards :)Quoted 129 lines
yeah, better, and we do plan to support vGuC from ICL for vGPU.
Quoted 127 lines
Quoted 122 lines
Quoted 120 lines · Patchwork
Quoted 117 lines
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
URL : https://patchwork.freedesktop.org/series/36343/
State : failure== Summary ==
Series 36343v1 series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/Test
core_auth:Subgroup basic-auth: pass -> SKIP (fi-skl-gvtdvm) Test core_prop_blob: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500) fdo#103989 pass -> SKIP (fi-skl-gvtdvm) Test drv_getparams_basic: Subgroup basic-eu-total: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-subslice-total: pass -> SKIP (fi-skl-gvtdvm) Test drv_hangman: Subgroup error-state-basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_basic: Subgroup bad-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-fd-close: pass -> SKIP (fi-skl-gvtdvm) Test gem_busy: Subgroup basic-busy-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-hang-default: pass -> SKIP (fi-skl-gvtdvm) fdo#104108 +2 Test gem_close_race: Subgroup basic-process: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-threads: pass -> SKIP (fi-skl-gvtdvm) Test gem_cpu_reloc: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_cs_tlb: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_create: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-files: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_exec: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_param: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_switch: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default-heavy: pass -> SKIP (fi-skl-gvtdvm) Test gem_exec_basic: Subgroup basic-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-default:WARNING: Long output truncated
da4321c7c088d01ad62b18d37dcfe5ef8d0b855ddrm-tip: 2018y-01m-11d-14h-59m-37s UTC integration manifesta0e8e84432b0HAX: drm/i915/uc: Enable GuC/HuC for CI973357da236adrm/i915/guc: Don't enable GuC when vGPU is active== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
Signature · 3 lines
Joonas Lahtinen Open Source Technology Center Intel CorporationTomi
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Quoted 28 lines · Joonas Lahtinen
Quoted 20 lines · Tomi Sarvela
Quoted 6 lines · Zhenyu Wang
Quoted 5 lines · Joonas Lahtinen
Quoted 4 lines · Changbin
Quoted 3 lines · Sagar Arun Kamble
Is skl-gvtdvm not having vGPU active?
It has flag
X86_FEATURE_HYPERVISORset however it might be seton host too
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
so relying
intel_vgpu_active().Do you mean flag
X86_FEATURE_HYPERVISORis set on host, too? Thisis weird since this
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
flag indicates the OS is running on a hypervisor.
+ CI folks and Zhenyu
Somehow, magically, the virtual machine seems to starts skipping all tests when GuC is disabled?
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Has somebody actually validated that the tests results are valid for the virtual machine? Or is this a one-off CI quirk?
Are these tests really run in VM with GVT-g enabled on host?
These tests are ran on VM running on GVT-d (as name implies), not GVT-g.
Quoted 7 lines
I don't still understand how explicitly disabling GuC could make all the tests skip on a machine that didn't use GuC to begin with. There must be something wrong in the initialization code.
That
intel_vgpu_active()check by my logic should not trigger in GVT-d (because we don't have virtual GPU, we have the real deal, just without stolen etc.), so I'm bit baffled.
True. This intel_vgpu_active() check added by Sagar is not active in these scenarios so we keep turn on GuC on that platform (as default from auto)
- param(int, enable_guc, 0) \
+ param(int, enable_guc, -1) \
[drm:intel_uc_sanitize_options [i915]] enable_guc=3 (submission:yes huc:yes)
but since i915_memcpy_from_wc() check still fails due to running under hypervisor (introduced by "drm/i915: Do not enable movntdqa optimization in hypervisor guest"), initialization of the GuC log fails
WARN_ON(!i915_memcpy_from_wc(((void *)0), ((void *)0), 0))
WARNING: CPU: 0 PID: 228 at drivers/gpu/drm/i915/intel_guc_log.c:527 intel_guc_log_create
and that is treated as driver load error (as we no longer support silent fallback from GuC to execlist, if GuC was selected using auto(-1) or explicit load(1) modparam option.
On the other mail thread there was proposal to make GuC log optional in case of running under hypervisor and disable it, but in my opinion it is not a solution but just short term fix, as we want to keep GuC log enabled since it works as is with other hypervisors.
Michal
Quoted 153 lines
Regards, Joonas
Quoted 150 lines
Tomi
Quoted 3 lines
Quoted 3 lines
PS. I'd do the check as early return condition at the top, like vGPU feature disabling elsewhere. It's not much point calculating the details (calling into functions like
intel_uc_fw_is_selected) andthen
Quoted 11 lines
Quoted 2 lines
throwing results out afterwards :)
yeah, better, and we do plan to support vGuC from ICL for vGPU.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines · Patchwork
Quoted 3 lines
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Don't enable
GuC when vGPU is active
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
URL : https://patchwork.freedesktop.org/series/36343/
State : failure== Summary ==
Series 36343v1 series starting with [1/2] drm/i915/guc: Don't
enable GuC when vGPU is active
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Test
core_auth:Subgroup basic-auth: pass -> SKIP (fi-skl-gvtdvm) Test core_prop_blob: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500)fdo#103989
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
pass -> SKIP (fi-skl-gvtdvm) Test drv_getparams_basic: Subgroup basic-eu-total: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-subslice-total: pass -> SKIP (fi-skl-gvtdvm) Test drv_hangman: Subgroup error-state-basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_basic: Subgroup bad-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-close:Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
pass -> SKIP (fi-skl-gvtdvm) Subgroup create-fd-close: pass -> SKIP (fi-skl-gvtdvm) Test gem_busy: Subgroup basic-busy-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-hang-default: pass -> SKIP (fi-skl-gvtdvm)fdo#104108 +2
Quoted 69 lines
Quoted 69 lines
Quoted 69 lines
Quoted 69 lines
Quoted 69 lines
Test
gem_close_race:Subgroup basic-process: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-threads: pass -> SKIP (fi-skl-gvtdvm) Test gem_cpu_reloc: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_cs_tlb: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_create: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-files: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_exec: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_param: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_switch: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default-heavy: pass -> SKIP (fi-skl-gvtdvm) Test gem_exec_basic: Subgroup basic-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-default:WARNING: Long output truncated
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
da4321c7c088d01ad62b18d37dcfe5ef8d0b855ddrm-tip:2018y-01m-11d-14h-59m-37s UTC integration manifest
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
a0e8e84432b0HAX: drm/i915/uc: Enable GuC/HuC for CI973357da236adrm/i915/guc: Don't enable GuC when vGPU isactive
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
--
Joonas Lahtinen
Open Source Technology Center
Intel CorporationTomi
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Quoted 60 lines · Michal Wajdeczko
Quoted 28 lines · Joonas Lahtinen
Quoted 20 lines · Tomi Sarvela
Quoted 6 lines · Zhenyu Wang
Quoted 5 lines · Joonas Lahtinen
Quoted 4 lines · Changbin
Quoted 3 lines · Sagar Arun Kamble
Is skl-gvtdvm not having vGPU active?
It has flag
X86_FEATURE_HYPERVISORset however it might beset on host too
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
so relying
intel_vgpu_active().Do you mean flag
X86_FEATURE_HYPERVISORis set on host, too?This is weird since this
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
flag indicates the OS is running on a hypervisor.
+ CI folks and Zhenyu
Somehow, magically, the virtual machine seems to starts skipping all tests when GuC is disabled?
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Has somebody actually validated that the tests results are valid for the virtual machine? Or is this a one-off CI quirk?
Are these tests really run in VM with GVT-g enabled on host?
These tests are ran on VM running on GVT-d (as name implies), not GVT-g.
Quoted 7 lines
I don't still understand how explicitly disabling GuC could make all the tests skip on a machine that didn't use GuC to begin with. There must be something wrong in the initialization code.
That
intel_vgpu_active()check by my logic should not trigger in GVT-d (because we don't have virtual GPU, we have the real deal, just without stolen etc.), so I'm bit baffled.True. This
intel_vgpu_active()check added by Sagar is not active in these scenarios so we keep turn on GuC on that platform (as default from auto)(quoted diff) +1
-1- param(int, enable_guc, 0) \ + param(int, enable_guc, -1) \[drm:intel_uc_sanitize_options [i915]] enable_guc=3 (submission:yes huc:yes)
but since
i915_memcpy_from_wc()check still fails due to running under hypervisor (introduced by "drm/i915: Do not enable movntdqa optimization in hypervisor guest"), initialization of the GuC log fails
WARN_ON(!i915_memcpy_from_wc(((void *)0), ((void *)0), 0))WARNING: CPU: 0 PID: 228 at drivers/gpu/drm/i915/intel_guc_log.c:527
intel_guc_log_createand that is treated as driver load error (as we no longer support silent fallback from GuC to execlist, if GuC was selected using auto(-1) or explicit
load(1) modparam option.
Quoted 6 lines
On the other mail thread there was proposal to make GuC log optional in case of running under hypervisor and disable it, but in my opinion it is not a solution but just short term fix, as we want to keep GuC log enabled since it works as is with other hypervisors.
Michal
To enable Guc logging on hypervisor guest, I think the correct solution is to fallback to memcpy() after i915_has_memcpy_from_wc(). At least for kvm, it needs this change considering GPU passthrough.
Thanks,
Changbin Du
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
Quoted 66 lines · Changbin
Quoted 65 lines · Michal Wajdeczko
Quoted 28 lines · Joonas Lahtinen
Quoted 20 lines · Tomi Sarvela
Quoted 6 lines · Zhenyu Wang
Quoted 5 lines · Joonas Lahtinen
Quoted 4 lines · Changbin
Quoted 3 lines · Sagar Arun Kamble
Is skl-gvtdvm not having vGPU active?
It has flag
X86_FEATURE_HYPERVISORset however it might beset on host too
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
so relying
intel_vgpu_active().Do you mean flag
X86_FEATURE_HYPERVISORis set on host, too?This is weird since this
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
flag indicates the OS is running on a hypervisor.
+ CI folks and Zhenyu
Somehow, magically, the virtual machine seems to starts skipping all tests when GuC is disabled?
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Has somebody actually validated that the tests results are valid for the virtual machine? Or is this a one-off CI quirk?
Are these tests really run in VM with GVT-g enabled on host?
These tests are ran on VM running on GVT-d (as name implies), not GVT-g.
Quoted 7 lines
I don't still understand how explicitly disabling GuC could make all the tests skip on a machine that didn't use GuC to begin with. There must be something wrong in the initialization code.
That
intel_vgpu_active()check by my logic should not trigger in GVT-d (because we don't have virtual GPU, we have the real deal, just without stolen etc.), so I'm bit baffled.True. This
intel_vgpu_active()check added by Sagar is not active in these scenarios so we keep turn on GuC on that platform (as default from auto)(quoted diff) +1
-1- param(int, enable_guc, 0) \ + param(int, enable_guc, -1) \[drm:intel_uc_sanitize_options [i915]] enable_guc=3 (submission:yes huc:yes)
but since
i915_memcpy_from_wc()check still fails due to running under hypervisor (introduced by "drm/i915: Do not enable movntdqa optimization in hypervisor guest"), initialization of the GuC log fails
WARN_ON(!i915_memcpy_from_wc(((void *)0), ((void *)0), 0))WARNING: CPU: 0 PID: 228 at drivers/gpu/drm/i915/intel_guc_log.c:527
intel_guc_log_createand that is treated as driver load error (as we no longer support silent fallback from GuC to execlist, if GuC was selected using auto(-1) or explicit
load(1) modparam option.On the other mail thread there was proposal to make GuC log optional in case of running under hypervisor and disable it, but in my opinion it is not a solution but just short term fix, as we want to keep GuC log enabled since it works as is with other hypervisors.
Quoted 5 lines
Quoted 1 line
Michal
To enable Guc logging on hypervisor guest, I think the correct solution is to fallback to
memcpy()afteri915_has_memcpy_from_wc(). At least for kvm, it needs this change considering GPU passthrough.
Perhaps a stupid question - but we are not talking about a scheme where multiple guests could read the same GuC log?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Joonas Lahtinen
maintainerRe: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/guc: Don't enable GuC when vGPU is active
In reply to Michal WajdeczkoQuoted 54 lines · Michal Wajdeczko
Quoted 30 lines · Joonas Lahtinen
Quoted 22 lines · Tomi Sarvela
Quoted 6 lines · Zhenyu Wang
Quoted 5 lines · Joonas Lahtinen
Quoted 4 lines · Changbin
Quoted 3 lines · Sagar Arun Kamble
Is skl-gvtdvm not having vGPU active?
It has flag
X86_FEATURE_HYPERVISORset however it might be seton host too
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
so relying
intel_vgpu_active().Do you mean flag
X86_FEATURE_HYPERVISORis set on host, too? Thisis weird since this
Quoted 7 lines
Quoted 7 lines
Quoted 1 line
flag indicates the OS is running on a hypervisor.
+ CI folks and Zhenyu
Somehow, magically, the virtual machine seems to starts skipping all tests when GuC is disabled?
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
Has somebody actually validated that the tests results are valid for the virtual machine? Or is this a one-off CI quirk?
Are these tests really run in VM with GVT-g enabled on host?
These tests are ran on VM running on GVT-d (as name implies), not GVT-g.
Quoted 7 lines
I don't still understand how explicitly disabling GuC could make all the tests skip on a machine that didn't use GuC to begin with. There must be something wrong in the initialization code.
That
intel_vgpu_active()check by my logic should not trigger in GVT-d (because we don't have virtual GPU, we have the real deal, just without stolen etc.), so I'm bit baffled.True. This
intel_vgpu_active()check added by Sagar is not active in these scenarios so we keep turn on GuC on that platform (as default from auto)(quoted diff) +1
-1- param(int, enable_guc, 0) \ + param(int, enable_guc, -1) \[drm:intel_uc_sanitize_options [i915]] enable_guc=3 (submission:yes huc:yes)
but since
i915_memcpy_from_wc()check still fails due to running under hypervisor (introduced by "drm/i915: Do not enable movntdqa optimization in hypervisor guest"), initialization of the GuC log fails
Quoted 8 lines
WARN_ON(!i915_memcpy_from_wc(((void *)0), ((void *)0), 0))WARNING: CPU: 0 PID: 228 at drivers/gpu/drm/i915/intel_guc_log.c:527
intel_guc_log_createand that is treated as driver load error (as we no longer support silent fallback from GuC to execlist, if GuC was selected using auto(-1) or explicit
load(1) modparam option.
Seems like this already bit us (earlier than expected), so I guess it's time to fix it sooner than later.
As previously stated, it's not really reasonable for the user to leave them with no working driver at all if the GuC load fails. I think WARN would be justified for the user in case they explicitly requested for GuC and we couldn't deliver, as the functional experience might differ.
When you combine that with a kselftest which will report a failure when explicit GuC submission was set in enable_guc but no GuC could be contacted, we will keep getting a CI failure when we want to test GuC functionality and ELSP is used instead. So in those cases, I expect a clear indication that something-something-guc@explicit-enable subtest will fail.
In the future, we can then make that WARN then trigger in the event of an automatic loading failure after we've gained solid experience that it works more times than it breaks. But that's for future.
Regards, Joonas
Quoted 170 lines
On the other mail thread there was proposal to make GuC log optional in case of running under hypervisor and disable it, but in my opinion it is not a solution but just short term fix, as we want to keep GuC log enabled since it works as is with other hypervisors.
Michal
Quoted 162 lines
Regards, Joonas
Quoted 159 lines
Tomi
Quoted 3 lines
Quoted 3 lines
PS. I'd do the check as early return condition at the top, like vGPU feature disabling elsewhere. It's not much point calculating the details (calling into functions like
intel_uc_fw_is_selected) andthen
Quoted 11 lines
Quoted 2 lines
throwing results out afterwards :)
yeah, better, and we do plan to support vGuC from ICL for vGPU.
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines · Patchwork
Quoted 3 lines
== Series Details ==
Series: series starting with [1/2] drm/i915/guc: Don't enable
GuC when vGPU is active
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
URL : https://patchwork.freedesktop.org/series/36343/
State : failure== Summary ==
Series 36343v1 series starting with [1/2] drm/i915/guc: Don't
enable GuC when vGPU is active
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
https://patchwork.freedesktop.org/api/1.0/series/36343/revisions/1/mbox/
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Test
core_auth:Subgroup basic-auth: pass -> SKIP (fi-skl-gvtdvm) Test core_prop_blob: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test debugfs_test: Subgroup read_all_entries: dmesg-warn -> DMESG-FAIL (fi-elk-e7500)fdo#103989
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
pass -> SKIP (fi-skl-gvtdvm) Test drv_getparams_basic: Subgroup basic-eu-total: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-subslice-total: pass -> SKIP (fi-skl-gvtdvm) Test drv_hangman: Subgroup error-state-basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_basic: Subgroup bad-close: pass -> SKIP (fi-skl-gvtdvm) Subgroup create-close:Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
pass -> SKIP (fi-skl-gvtdvm) Subgroup create-fd-close: pass -> SKIP (fi-skl-gvtdvm) Test gem_busy: Subgroup basic-busy-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-hang-default: pass -> SKIP (fi-skl-gvtdvm)fdo#104108 +2
Quoted 69 lines
Quoted 69 lines
Quoted 69 lines
Quoted 69 lines
Quoted 69 lines
Test
gem_close_race:Subgroup basic-process: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-threads: pass -> SKIP (fi-skl-gvtdvm) Test gem_cpu_reloc: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_cs_tlb: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_create: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-files: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_exec: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_param: Subgroup basic: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Test gem_ctx_switch: Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default-heavy: pass -> SKIP (fi-skl-gvtdvm) Test gem_exec_basic: Subgroup basic-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup basic-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-default: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-render: pass -> SKIP (fi-skl-gvtdvm) Subgroup gtt-vebox: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-blt: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd1: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-bsd2: pass -> SKIP (fi-skl-gvtdvm) Subgroup readonly-default:WARNING: Long output truncated
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
da4321c7c088d01ad62b18d37dcfe5ef8d0b855ddrm-tip:2018y-01m-11d-14h-59m-37s UTC integration manifest
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
a0e8e84432b0HAX: drm/i915/uc: Enable GuC/HuC for CI973357da236adrm/i915/guc: Don't enable GuC when vGPU isactive
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7651/issues.html
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
--
Joonas Lahtinen
Open Source Technology Center
Intel CorporationTomi
Signature · 7 lines
Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx