SCSI target patches for kernel v4.15
cover SCSI target patches for kernel v4.15
Hello Martin,
This patch series consists of patches I came up with while reviewing and testing the SCSI target code. Please consider these patches for kernel v4.15.
Thanks,
Bart.
Bart Van Assche (11):
target: Move a declaration of a global variable into a header file
target: Suppress gcc 7 fallthrough warnings
target: Inline transport_put_cmd()
target: Avoid that EXTENDED COPY commands triggers lock inversion target/iscsi: Define OFFLOAD_BUF_SIZE once target/iscsi: Use min() in iscsit_dump_data_payload() instead of
open-coding it
target/iscsi: Fix endianness in an error message target/iscsi: Modify iscsit_do_crypto_hash_buf() prototype target/iscsi: Fix a race condition in iscsit_add_reject_from_cmd() target/iscsi: Detect conn_cmd_list corruption early usb/gadget: Make it again possible to enable the legacy drivers
without enabling USB_ETH
drivers/target/iscsi/cxgbit/cxgbit_main.c | 1 + drivers/target/iscsi/iscsi_target.c | 50 +++++++++++------------- drivers/target/iscsi/iscsi_target_erl1.c | 7 ++-- drivers/target/iscsi/iscsi_target_seq_pdu_list.c | 2 - drivers/target/iscsi/iscsi_target_util.c | 4 ++ drivers/target/target_core_configfs.c | 18 ++++++++- drivers/target/target_core_fabric_configfs.c | 2 - drivers/target/target_core_internal.h | 1 + drivers/target/target_core_pr.c | 2 + drivers/target/target_core_transport.c | 27 +++---------- drivers/usb/gadget/Kconfig | 4 +- drivers/usb/gadget/legacy/Kconfig | 10 +++++ include/target/target_core_base.h | 1 + 13 files changed, 68 insertions(+), 61 deletions(-)
Signature · 1 line
2.14.2
cover SCSI target patches for kernel v4.16
Hello Martin,
As you maybe know some time ago I started working on simplifying task management function handling in the SCSI target core (see e.g. "[PATCH 00/34] SCSI target patches for kernel v4.11"; January 2017;
https://www.spinics.net/lists/target-devel/msg14054.html). There were some patches in that series that rightfully raised Nic's eyebrows. Reviewing these patches myself made me realize that before TMF handling can be made synchronous that some unusual constructs in the SCSI target core have to be reworked first. Hence this patch series. The following tests have been run against this patch series for both the iSCSI and SRPT target drivers:
- Run the libiscsi conformance tests.
- Run fio ${dev} in one shell and while sg_reset -d ${dev}; do :; done from another shell. This is a good way to stress test TMF handling.
- For the SRP target driver: run the srp-test software.
Please consider this patch series for kernel v4.16.
Thanks,
Bart.
Bart Van Assche (11):
target: Fix an argument name in a function documentation header
target: Use config_item_name() instead of open-coding it
target: Avoid that EXTENDED COPY commands trigger lock inversion
target: Make the session shutdown code also wait for commands that are
being aborted
target: Add more documentation
target: Simplify core_tmr_handle_tas_abort()
target: Fold core_tmr_handle_tas_abort() into
transport_cmd_finish_abort()
target: Simplify transport_generic_free_cmd() (1/2)
target: Simplify transport_generic_free_cmd() (2/2)
target: Simplify the code for waiting for command completion target/iscsi: Reduce number of __iscsit_free_cmd() callers
drivers/target/iscsi/iscsi_target.c | 2 - drivers/target/iscsi/iscsi_target_configfs.c | 1 + drivers/target/iscsi/iscsi_target_util.c | 4 +- drivers/target/target_core_configfs.c | 4 +- drivers/target/target_core_device.c | 31 +++-- drivers/target/target_core_internal.h | 2 +- drivers/target/target_core_sbc.c | 7 +- drivers/target/target_core_tmr.c | 30 +---- drivers/target/target_core_transport.c | 166 ++++++++++++--------------- include/target/target_core_base.h | 5 +- 10 files changed, 113 insertions(+), 139 deletions(-)
Signature · 1 line
2.15.1
Re: [PATCH 00/11] SCSI target patches for kernel v4.16
In reply to Bart Van AsscheT24gV2VkLCAyMDE3LTEyLTEzIGF0IDE1OjUwIC0wODAwLCBCYXJ0IFZhbiBBc3NjaGUgd3JvdGU6 DQo+IEFzIHlvdSBtYXliZSBrbm93IHNvbWUgdGltZSBhZ28gSSBzdGFydGVkIHdvcmtpbmcgb24g c2ltcGxpZnlpbmcgdGFzaw0KPiBtYW5hZ2VtZW50IGZ1bmN0aW9uIGhhbmRsaW5nIGluIHRoZSBT Q1NJIHRhcmdldCBjb3JlIChzZWUgZS5nLiAiW1BBVENIIDAwLzM0XQ0KPiBTQ1NJIHRhcmdldCBw YXRjaGVzIGZvciBrZXJuZWwgdjQuMTEiOyBKYW51YXJ5IDIwMTc7DQo+IGh0dHBzOi8vd3d3LnNw aW5pY3MubmV0L2xpc3RzL3RhcmdldC1kZXZlbC9tc2cxNDA1NC5odG1sKS4gVGhlcmUgd2VyZSBz b21lDQo+IHBhdGNoZXMgaW4gdGhhdCBzZXJpZXMgdGhhdCByaWdodGZ1bGx5IHJhaXNlZCBOaWMn cyBleWVicm93cy4gUmV2aWV3aW5nIHRoZXNlDQo+IHBhdGNoZXMgbXlzZWxmIG1hZGUgbWUgcmVh bGl6ZSB0aGF0IGJlZm9yZSBUTUYgaGFuZGxpbmcgY2FuIGJlIG1hZGUNCj4gc3luY2hyb25vdXMg dGhhdCBzb21lIHVudXN1YWwgY29uc3RydWN0cyBpbiB0aGUgU0NTSSB0YXJnZXQgY29yZSBoYXZl IHRvIGJlDQo+IHJld29ya2VkIGZpcnN0LiBIZW5jZSB0aGlzIHBhdGNoIHNlcmllcy4gVGhlIGZv bGxvd2luZyB0ZXN0cyBoYXZlIGJlZW4gcnVuDQo+IGFnYWluc3QgdGhpcyBwYXRjaCBzZXJpZXMg Zm9yIGJvdGggdGhlIGlTQ1NJIGFuZCBTUlBUIHRhcmdldCBkcml2ZXJzOg0KPiAtIFJ1biB0aGUg bGliaXNjc2kgY29uZm9ybWFuY2UgdGVzdHMuDQo+IC0gUnVuIGZpbyAke2Rldn0gaW4gb25lIHNo ZWxsIGFuZCB3aGlsZSBzZ19yZXNldCAtZCAke2Rldn07IGRvIDo7IGRvbmUgZnJvbQ0KPiAgIGFu b3RoZXIgc2hlbGwuIFRoaXMgaXMgYSBnb29kIHdheSB0byBzdHJlc3MgdGVzdCBUTUYgaGFuZGxp bmcuDQo+IC0gRm9yIHRoZSBTUlAgdGFyZ2V0IGRyaXZlcjogcnVuIHRoZSBzcnAtdGVzdCBzb2Z0 d2FyZS4NCg0KSGVsbG8gTmljLA0KDQpIYXZlIHlvdSBhbHJlYWR5IGhhZCB0aGUgdGltZSB0byBs b29rIGF0IHRoaXMgcGF0Y2ggc2VyaWVzPw0KDQpUaGFua3MsDQoNCkJhcnQu
cover SCSI target patches for kernel v5.2
In reply to Bart Van AsscheHi Martin,
This patch series fixes a few bugs and also simplifies the SCSI target code. Please consider these patches for kernel v5.2.
Thanks,
Bart.
Bart Van Assche (11):
target/core: Fix a race condition in the LUN lookup code target/core: Rework the SPC-2 reservation handling code target/core: Release SPC-2 reservation upon initiator logout target/core: Remove a set-but-not-used member variable from the XCOPY
implementation
target/core: Simplify LUN initialization in XCOPY implementation target/core: Make the XCOPY setup code easier to read by inlining two
functions
target/iscsi: Detect conn_cmd_list corruption early target/iscsi: Only send R2T if needed
target/iscsi: Handle too large immediate data buffers correctly target/iscsi: Make iscsit_map_iovec() more robust target/iscsi: Make sure PDU processing continues if parsing a command
fails
drivers/target/iscsi/iscsi_target.c | 118 ++++++++++++++++------- drivers/target/iscsi/iscsi_target_util.c | 5 + drivers/target/target_core_configfs.c | 5 +- drivers/target/target_core_device.c | 4 +- drivers/target/target_core_pr.c | 33 ++++--- drivers/target/target_core_pr.h | 1 + drivers/target/target_core_tmr.c | 2 +- drivers/target/target_core_transport.c | 10 ++ drivers/target/target_core_xcopy.c | 92 +++++------------- include/target/iscsi/iscsi_target_core.h | 1 + include/target/target_core_base.h | 4 +- include/target/target_core_fabric.h | 1 + 12 files changed, 150 insertions(+), 126 deletions(-)
Signature · 1 line
2.21.0.196.g041f5ea1cf98
Martin K. Petersen
AppliedRe: [PATCH 00/11] SCSI target patches for kernel v5.2
In reply to Bart Van AsscheBart,
Quoted 2 lines
This patch series fixes a few bugs and also simplifies the SCSI target code.
Applied to 5.2/scsi-queue, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering