Skip to contentSkip to conversation

dts-bindings: usb-uhci: Document newly added properties

PATCH In review Benjamin Herrenschmidt 3 participants 4 messages Jan 16, 2018 – Jan 20, 2018 1 message not in the archive

Subsystems (2)
Device tree bindings USB
lore
Share & tools
lore

Benjamin Herrenschmidt

author
#0 lore raw

PATCH 1/1 dts-bindings: usb-uhci: Document newly added properties

Commit 4642d34a439f80e16af0d56ed6258a33abae257a
"usb/uhci: Add support for Aspeed BMC SoCs" added
support for a new #ports property, along with
Aspeed specific compatible strings. This adds
documentation for them.

Signed-off-by Benjamin Herrenschmidt <[email protected]>
---
 Documentation/devicetree/bindings/usb/usb-uhci.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/usb/usb-uhci.txt +6 -0
index 298133416c97..c1153eb38a9a 100644
@@ -3,8 +3,14 @@ Generic Platform UHCI Controller
 
 Required properties:
 - compatible : "generic-uhci" (deprecated: "platform-uhci")
+  supports additional Aspeed specific workarounds by also
+  including the "aspeed,ast2400-uhci" or "aspeed,ast2500-uhci"
+  string.
 - reg : Should contain 1 register ranges(address and length)
 - interrupts : UHCI controller interrupt
+- #ports: (optional) 1 cell, number of ports (overrides
+  auto-detection which is needed among others on some Aspeed
+  parts).
 
 Example:

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1516061175.31850.140.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org

Acked-by
#2 lore raw
Quoted 7 lines · Benjamin Herrenschmidt

Commit 4642d34a439f80e16af0d56ed6258a33abae257a
"usb/uhci: Add support for Aspeed BMC SoCs" added
support for a new #ports property, along with
Aspeed specific compatible strings. This adds
documentation for them.

Signed-off-by Benjamin Herrenschmidt <[email protected]>
Acked-by Joel Stanley <[email protected]>
Quoted 15 lines
---
 Documentation/devicetree/bindings/usb/usb-uhci.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/usb/usb-uhci.txt +1 -0
index 298133416c97..c1153eb38a9a 100644
@@ -3,8 +3,14 @@ Generic Platform UHCI Controller
 
 Required properties:
 - compatible : "generic-uhci" (deprecated: "platform-uhci")
+  supports additional Aspeed specific workarounds by also

Documentation/devicetree/bindings/usb/usb-uhci.txt Generic Platform UHCI Controller · line 16

Quoted 10 lines
Documentation/devicetree/bindings/usb/usb-uhci.txt +5 -0
+  including the "aspeed,ast2400-uhci" or "aspeed,ast2500-uhci"
+  string.
 - reg : Should contain 1 register ranges(address and length)
 - interrupts : UHCI controller interrupt
+- #ports: (optional) 1 cell, number of ports (overrides
+  auto-detection which is needed among others on some Aspeed
+  parts).
 
 Example:

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to a message not in the archive
Quoted 16 lines · Benjamin Herrenschmidt

Commit 4642d34a439f80e16af0d56ed6258a33abae257a
"usb/uhci: Add support for Aspeed BMC SoCs" added
support for a new #ports property, along with
Aspeed specific compatible strings. This adds
documentation for them.

Signed-off-by Benjamin Herrenschmidt <[email protected]>
---
 Documentation/devicetree/bindings/usb/usb-uhci.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/usb/usb-uhci.txt +0 -0
index 298133416c97..c1153eb38a9a 100644

Documentation/devicetree/bindings/usb/usb-uhci.txt Generic Platform UHCI Controller · line 8

Quoted 6 lines
Documentation/devicetree/bindings/usb/usb-uhci.txt +3 -0
@@ -3,8 +3,14 @@ Generic Platform UHCI Controller
 
 Required properties:
 - compatible : "generic-uhci" (deprecated: "platform-uhci")
+  supports additional Aspeed specific workarounds by also
+  including the "aspeed,ast2400-uhci" or "aspeed,ast2500-uhci"
+  string.

That's usually why we have SoC compatibles, so the description doesn't really add anything. Can you format with one valid compatible list per line:

compatible : Should be one of:

	"aspeed,ast2500-uhci", "generic-uhci"
	"aspeed,ast2400-uhci", "generic-uhci"
	"generic-uhci"
	"platform-uhci" (deprecated)

We should deprecate "generic-uhci" too IMO, but hardly anyone adds new UHCI controllers.

Quoted 11 lines
Documentation/devicetree/bindings/usb/usb-uhci.txt +3 -1
 - reg : Should contain 1 register ranges(address and length)
 - interrupts : UHCI controller interrupt
+- #ports: (optional) 1 cell, number of ports (overrides
+  auto-detection which is needed among others on some Aspeed
+  parts).
 
 Example:
 
 
 
--
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#4 lore raw
Quoted 28 lines · Rob Herring
Quoted 16 lines · Benjamin Herrenschmidt

Commit 4642d34a439f80e16af0d56ed6258a33abae257a
"usb/uhci: Add support for Aspeed BMC SoCs" added
support for a new #ports property, along with
Aspeed specific compatible strings. This adds
documentation for them.

Signed-off-by Benjamin Herrenschmidt <[email protected]>
---
 Documentation/devicetree/bindings/usb/usb-uhci.txt | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/usb/usb-uhci.txt +0 -0
index 298133416c97..c1153eb38a9a 100644

Documentation/devicetree/bindings/usb/usb-uhci.txt Generic Platform UHCI Controller · line 8

Quoted 6 lines
Documentation/devicetree/bindings/usb/usb-uhci.txt +3 -0
@@ -3,8 +3,14 @@ Generic Platform UHCI Controller
 
 Required properties:
 - compatible : "generic-uhci" (deprecated: "platform-uhci")
+  supports additional Aspeed specific workarounds by also
+  including the "aspeed,ast2400-uhci" or "aspeed,ast2500-uhci"
+  string.

That's usually why we have SoC compatibles, so the description doesn't really add anything. Can you format with one valid compatible list per line:

Quoted 8 lines

compatible : Should be one of:

	"aspeed,ast2500-uhci", "generic-uhci"
	"aspeed,ast2400-uhci", "generic-uhci"
	"generic-uhci"
	"platform-uhci" (deprecated)

We should deprecate "generic-uhci" too IMO, but hardly anyone adds new UHCI controllers.

So I made a mistake in the code, I need both the aspeed specific compatible *and* the platform-uhci one since I didn't amend the driver to match on the aspeed ones. I suppose I could just send a fixup patch as nobody yet has deployed anything yet on the field.

Quoted 6 lines
Quoted 6 lines
Documentation/devicetree/bindings/usb/usb-uhci.txt +3 -0
 - reg : Should contain 1 register ranges(address and length)
 - interrupts : UHCI controller interrupt
+- #ports: (optional) 1 cell, number of ports (overrides
+  auto-detection which is needed among others on some Aspeed
+  parts).
Quoted 8 lines
Quoted 8 lines
Documentation/devicetree/bindings/usb/usb-uhci.txt +0 -1
 Example:
 
 
 
--

To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html