Skip to contentSkip to conversation

Patch "Input: twl4030-vibra - fix sibling-node lookup" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Jan 20, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Input: twl4030-vibra - fix sibling-node lookup

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
input-twl4030-vibra-fix-sibling-node-lookup.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5b189201993ab03001a398de731045bfea90c689 Mon Sep 17 00:00:00 2001

From: Johan Hovold <[email protected]>
Date: Mon, 8 Jan 2018 17:15:06 -0800
Subject: Input: twl4030-vibra - fix sibling-node lookup

From: Johan Hovold <[email protected]>

commit 5b189201993ab03001a398de731045bfea90c689 upstream.

A helper purported to look up a child node based on its name was using the wrong of-helper and ended up prematurely freeing the parent of-node while searching the whole device tree depth-first starting at the parent node.

Fixes 64b9e4d803b1 ("input: twl4030-vibra: Support for DT booted kernel")
Fixes e661d0a04462 ("Input: twl4030-vibra - fix ERROR: Bad of_node_put() warning")
---
 drivers/input/misc/twl4030-vibra.c |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/input/misc/twl4030-vibra.c +4 -2
@@ -178,12 +178,14 @@ static SIMPLE_DEV_PM_OPS(twl4030_vibra_p
 			 twl4030_vibra_suspend, twl4030_vibra_resume);
 
 static bool twl4030_vibra_check_coexist(struct twl4030_vibra_data *pdata,
-			      struct device_node *node)
+			      struct device_node *parent)
 {
+	struct device_node *node;
+
 	if (pdata && pdata->coexist)
 		return true;
 
-	node = of_find_node_by_name(node, "codec");
+	node = of_get_child_by_name(parent, "codec");
 	if (node) {
 		of_node_put(node);
 		return true;

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/input-twl4030-vibra-fix-sibling-node-lookup.patch queue-4.14/input-twl6040-vibra-fix-child-node-lookup.patch queue-4.14/input-88pm860x-ts-fix-child-node-lookup.patch