Patch "net: igmp: fix source address check for IGMPv3 reports" has been added to the 4.14-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
net: igmp: fix source address check for IGMPv3 reports
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-igmp-fix-source-address-check-for-igmpv3-reports.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Sun Jan 28 17:35:08 CET 2018
From: Felix Fietkau <[email protected]>
Date: Fri, 19 Jan 2018 11:50:46 +0100
Subject: net: igmp: fix source address check for IGMPv3 reports
From: Felix Fietkau <[email protected]>
[ Upstream commit ad23b750933ea7bf962678972a286c78a8fa36aa ]
Commit "net: igmp: Use correct source address on IGMPv3 reports" introduced a check to validate the source address of locally generated IGMPv3 packets.
Instead of checking the local interface address directly, it uses inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the local subnet (or equal to the point-to-point address if used).
This breaks for point-to-point interfaces, so check against ifa->ifa_local directly.
--- net/ipv4/igmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/igmp.c +1 -1
@@ -332,7 +332,7 @@ static __be32 igmpv3_get_srcaddr(structreturn htonl (INADDR_ANY );for_ifa (in_dev) { -if (inet_ifa_match (fl4->saddr, ifa)) +if (fl4->saddr == ifa->ifa_local)return fl4->saddr; }endfor_ifa (in_dev);
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/net-igmp-fix-source-address-check-for-igmpv3-reports.patch
please apply that patch to 4.4 and 3.18 as well. they are affected by this regression
thanks,
Sebastian
Am 28.01.2018 um 17:39 schrieb [email protected]:
Quoted 62 lines
This is a note to let you know that I've just added the patch titled
net: igmp: fix source address check for IGMPv3 reports
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summaryThe filename of the patch is:
net-igmp-fix-source-address-check-for-igmpv3-reports.patch
and it can be found in the queue-4.14 subdirectory.If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
From foo@baz Sun Jan 28 17:35:08 CET 2018
From: Felix Fietkau <[email protected]>
Date: Fri, 19 Jan 2018 11:50:46 +0100
Subject: net: igmp: fix source address check for IGMPv3 reportsFrom: Felix Fietkau <[email protected]>
[ Upstream commit
ad23b750933ea7bf962678972a286c78a8fa36aa]Commit "net: igmp: Use correct source address on IGMPv3 reports" introduced a check to validate the source address of locally generated IGMPv3 packets.
Instead of checking the local interface address directly, it usesinet_ifa_match(fl4->saddr, ifa), which checks if the address is on the local subnet (or equal to the point-to-point address if used).This breaks for point-to-point interfaces, so check against
ifa->ifa_localdirectly.Cc Kevin Cernekee <[email protected]>Fixes a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports")Reported-by Sebastian Gottschall <[email protected]>Signed-off-by Felix Fietkau <[email protected]>Signed-off-by David S. Miller <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>--- net/ipv4/igmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/ipv4/igmp.c +1
-1@@ -332,7 +332,7 @@ static __be32 igmpv3_get_srcaddr(structreturn htonl (INADDR_ANY );for_ifa (in_dev) { -if (inet_ifa_match (fl4->saddr, ifa)) +if (fl4->saddr == ifa->ifa_local)return fl4->saddr; }endfor_ifa (in_dev);Patches currently in stable-queue which might be from [email protected] are
queue-4.14/net-igmp-fix-source-address-check-for-igmpv3-reports.patch
Signature · 11 lines
Mit freundlichen Gr�ssen / Regards Sebastian Gottschall / CTO NewMedia-NET GmbH - DD-WRT Firmensitz: Stubenwaldallee 21a, 64625 Bensheim Registergericht: Amtsgericht Darmstadt, HRB 25473 Gesch�ftsf�hrer: Peter Steinh�user, Christian Scheele http://www.dd-wrt.com email: [email protected] Tel.: +496251-582650 / Fax: +496251-5826565
Greg KH
maintainerQuoted 2 lines · Sebastian Gottschall
please apply that patch to 4.4 and 3.18 as well. they are affected by this regression
Thanks for letting me know, now queued up.
greg k-h