Skip to contentSkip to conversation

ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly

PATCH New Andy Shevchenko 2 participants 4 messages Jan 22, 2018 – Jan 29, 2018

Subsystems (3)
Arm (32-bit) Arm sub-architectures PXA2xx/PXA3xx support
lore
Share & tools
lore

Andy Shevchenko

author
#0 lore raw

PATCH 1/1 ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly

Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied type, use PROPERTY_ENTRY_U32() dedicated macro.

It will help modify internals of built-in device properties API.

No functional change intended.

Signed-off-by Andy Shevchenko <[email protected]>
---
 arch/arm/mach-pxa/raumfeld.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach-pxa/raumfeld.c +3 -3
index 9d662fed03ec..0bf5419a9d10 100644
@@ -378,9 +378,9 @@ static struct gpiod_lookup_table raumfeld_rotary_gpios_table = {
 };
 
 static const struct property_entry raumfeld_rotary_properties[] __initconst = {
-	PROPERTY_ENTRY_INTEGER("rotary-encoder,steps-per-period", u32, 24),
-	PROPERTY_ENTRY_INTEGER("linux,axis",			  u32, REL_X),
-	PROPERTY_ENTRY_INTEGER("rotary-encoder,relative_axis",	  u32, 1),
+	PROPERTY_ENTRY_U32("rotary-encoder,steps-per-period", 24),
+	PROPERTY_ENTRY_U32("linux,axis",		      REL_X),
+	PROPERTY_ENTRY_U32("rotary-encoder,relative_axis",    1),
 	{ },
 };
Signature · 1 line
2.15.1
author
#1 lore raw

PATCH 1/1 ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly

Quoted 8 lines · Andy Shevchenko

Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied type,
use PROPERTY_ENTRY_U32() dedicated macro.

It will help modify internals of built-in device properties API.

No functional change intended.

Can someone apply that, or at least Ack? It's needed as a prerequisite to fix one bug in device property core API.

Quoted 28 lines
Signed-off-by Andy Shevchenko <[email protected]>
---
 arch/arm/mach-pxa/raumfeld.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-pxa/raumfeld.c +0 -0

pxa/raumfeld.c
index 9d662fed03ec..0bf5419a9d10 100644

arch/arm/mach-pxa/raumfeld.c +3 -3
@@ -378,9 +378,9 @@ static struct gpiod_lookup_table
 raumfeld_rotary_gpios_table = {
 };
 
 static const struct property_entry raumfeld_rotary_properties[]
 __initconst = {
-	PROPERTY_ENTRY_INTEGER("rotary-encoder,steps-per-period",
 u32, 24),
-	PROPERTY_ENTRY_INTEGER("linux,axis",			 
 u32, REL_X),
-	PROPERTY_ENTRY_INTEGER("rotary-encoder,relative_axis",	
  u32, 1),
+	PROPERTY_ENTRY_U32("rotary-encoder,steps-per-period", 24),
+	PROPERTY_ENTRY_U32("linux,axis",		      REL_X),
+	PROPERTY_ENTRY_U32("rotary-encoder,relative_axis",    1),
 	{ },
 };
Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
maintainer
#2 lore raw

PATCH 1/1 ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly

Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Andy Shevchenko

Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied type,
use PROPERTY_ENTRY_U32() dedicated macro.

Quoted 7 lines
Quoted 4 lines

It will help modify internals of built-in device properties API.

No functional change intended.

Can someone apply that, or at least Ack? It's needed as a prerequisite to fix one bug in device property core API.

I can certainly ack it :

Acked-by Robert Jarzmik <[email protected]>

I would have gladly taken it into my pxa/for-next branch, but for a reason your original mail did not land in my mailbox ... computers can be deceiving sometimes.

I you send it to me again I'll apply it to my tree.

Cheers.

--
Robert

author
#3 lore raw

PATCH 1/1 ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly

Quoted 7 lines · Robert Jarzmik

I would have gladly taken it into my pxa/for-next branch, but for a reason your
original mail did not land in my mailbox ... computers can be deceiving
sometimes.

I you send it to me again I'll apply it to my tree.

Done!

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy