Skip to contentSkip to conversation

ovl: check ERR_PTR() return value from ovl_encode_fh()

PATCH New Amir Goldstein 1 participant 1 message Jan 30, 2018 Overlay filesystem

lore
Share & tools
lore

Amir Goldstein

author maintainer
#0 lore raw

PATCH 1/1 ovl: check ERR_PTR() return value from ovl_encode_fh()

Fixes 8ed5eec9d6c4 ("ovl: encode pure upper file handles")

---

Miklos,

Another fix on top on overlayfs-next, for an issue reported by 0-day robot.

If you are going to squash this one and the other regression fix to overlayfs-next, just keep in mind that overlayfs-next has already been merged with Al's for-next branch on linux-next tree to resolve a conflict.

Thanks,
Amir.

 fs/overlayfs/export.c | 3 +++
 1 file changed, 3 insertions(+)
fs/overlayfs/export.c +3 -0
index b65ea49de457..bb94ce9da5c8 100644
@@ -108,6 +108,9 @@ static int ovl_d_to_fh(struct dentry *dentry, char *buf, int buflen)
 
 	/* Encode an upper or origin file handle */
 	fh = ovl_encode_fh(origin ?: ovl_dentry_upper(dentry), !origin);
+	err = PTR_ERR(fh);
+	if (IS_ERR(fh))
+		goto fail;
 
 	err = -EOVERFLOW;
 	if (fh->len > buflen)
Signature · 1 line
2.7.4