f2fs: support passing down write hints to block layer
Subsystems (3)
v2 cover f2fs: support passing down write hints to block layer
From: Hyunchul Lee <[email protected]>
Changes since version 1:
- Set 'whint_mode' to off if 'active_logs' is two or four
- Minor fixes suggested by Chao
This set implements passing down write hints to block layer with the following mapping. This mapping equals the conclusion from discussion in the link, https://sourceforge.net/p/linux-f2fs/mailman/message/36170969/
But there are two exceptions. (1) the 'iohint_mode' mount option is changed to 'whint_mode'. (2) in "user-based" mode, WRITE_LIFE_EXTREME is passed down instead of WRITE_LIFE_NOT_SET for files flagged with ioctl(COLD) and extension list.
1) whint_mode=off. F2FS only passes down WRITE_LIFE_NOT_SET.
2) whint_mode=user-based. F2FS tries to pass down hints given by users.
User F2FS Block
---- ---- -----
META WRITE_LIFE_NOT_SET
HOT_NODE "
WARM_NODE "
COLD_NODE "
*ioctl(COLD) COLD_DATA WRITE_LIFE_EXTREME
*extension list " "-- buffered io
WRITE_LIFE_EXTREME COLD_DATA WRITE_LIFE_EXTREME WRITE_LIFE_SHORT HOT_DATA WRITE_LIFE_SHORT WRITE_LIFE_NOT_SET WARM_DATA WRITE_LIFE_NOT_SET WRITE_LIFE_NONE " " WRITE_LIFE_MEDIUM " " WRITE_LIFE_LONG " "
-- direct io
WRITE_LIFE_EXTREME COLD_DATA WRITE_LIFE_EXTREME WRITE_LIFE_SHORT HOT_DATA WRITE_LIFE_SHORT WRITE_LIFE_NOT_SET WARM_DATA WRITE_LIFE_NOT_SET WRITE_LIFE_NONE " WRITE_LIFE_NONE WRITE_LIFE_MEDIUM " WRITE_LIFE_MEDIUM WRITE_LIFE_LONG " WRITE_LIFE_LONG
3) whint_mode=fs-based. F2FS passes down hints with its policy.
User F2FS Block
---- ---- -----
META WRITE_LIFE_MEDIUM;
HOT_NODE WRITE_LIFE_NOT_SET
WARM_NODE "
COLD_NODE WRITE_LIFE_NONE
ioctl(COLD) COLD_DATA WRITE_LIFE_EXTREME
extension list " "-- buffered io
WRITE_LIFE_EXTREME COLD_DATA WRITE_LIFE_EXTREME WRITE_LIFE_SHORT HOT_DATA WRITE_LIFE_SHORT WRITE_LIFE_NOT_SET WARM_DATA WRITE_LIFE_LONG WRITE_LIFE_NONE " " WRITE_LIFE_MEDIUM " " WRITE_LIFE_LONG " "
-- direct io
WRITE_LIFE_EXTREME COLD_DATA WRITE_LIFE_EXTREME WRITE_LIFE_SHORT HOT_DATA WRITE_LIFE_SHORT WRITE_LIFE_NOT_SET WARM_DATA WRITE_LIFE_NOT_SET WRITE_LIFE_NONE " WRITE_LIFE_NONE WRITE_LIFE_MEDIUM " WRITE_LIFE_MEDIUM WRITE_LIFE_LONG " WRITE_LIFE_LONG
Hyunchul Lee (3):
f2fs: support passing down write hints given by users to block layer
f2fs: support passing down write hints to block layer with F2FS policy
f2fs: Add the 'whint_mode' mount option to f2fs documentation
Documentation/filesystems/f2fs.txt | 6 +++ fs/f2fs/data.c | 28 +++++++++-- fs/f2fs/f2fs.h | 10 ++++ fs/f2fs/segment.c | 98 ++++++++++++++++++++++++++++++++++++++ fs/f2fs/super.c | 35 +++++++++++++- 5 files changed, 171 insertions(+), 6 deletions(-)
Signature · 1 line
1.9.1
PATCH v2 1/3 f2fs: support passing down write hints given by users to block layer
From: Hyunchul Lee <[email protected]>
Add the 'whint_mode' mount option that controls which write hints are passed down to block layer. There are "off" and "user-based" mode. The default mode is "off".
1) whint_mode=off. F2FS only passes down WRITE_LIFE_NOT_SET.
2) whint_mode=user-based. F2FS tries to pass down hints given by users.
User F2FS Block
---- ---- -----
META WRITE_LIFE_NOT_SET
HOT_NODE "
WARM_NODE "
COLD_NODE "
ioctl(COLD) COLD_DATA WRITE_LIFE_EXTREME
extension list " "-- buffered io
WRITE_LIFE_EXTREME COLD_DATA WRITE_LIFE_EXTREME WRITE_LIFE_SHORT HOT_DATA WRITE_LIFE_SHORT WRITE_LIFE_NOT_SET WARM_DATA WRITE_LIFE_NOT_SET WRITE_LIFE_NONE " " WRITE_LIFE_MEDIUM " " WRITE_LIFE_LONG " "
-- direct io
WRITE_LIFE_EXTREME COLD_DATA WRITE_LIFE_EXTREME WRITE_LIFE_SHORT HOT_DATA WRITE_LIFE_SHORT WRITE_LIFE_NOT_SET WARM_DATA WRITE_LIFE_NOT_SET WRITE_LIFE_NONE " WRITE_LIFE_NONE WRITE_LIFE_MEDIUM " WRITE_LIFE_MEDIUM WRITE_LIFE_LONG " WRITE_LIFE_LONG
Many thanks to Chao Yu and Jaegeuk Kim for comments to implement this patch.
---
v2:
- Set "whint_mode" to off if "active_logs" is two or four
- Use a local variable to check "whint_mode" instead of sbi->whint_mode in f2fs_direct_IO
- Fix comments about rw_hint_to_seg_type()
fs/f2fs/data.c | 28 +++++++++++++++++++++----- fs/f2fs/f2fs.h | 9 +++++++++ fs/f2fs/segment.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/f2fs/super.c | 30 +++++++++++++++++++++++++++- 4 files changed, 120 insertions(+), 6 deletions(-)
fs/f2fs/data.c +23 -5
@@ -175,15 +175,22 @@ static bool __same_bdev(struct f2fs_sb_info *sbi,*/ static struct bio *__bio_alloc (struct f2fs_sb_info *sbi,block_t blk_addr,struct writeback_control *wbc, -int npages,bool is_read) +int npages,bool is_read, +enum page_type type,enum temp_type temp) {struct bio *bio; bio =f2fs_bio_alloc (sbi, npages, true);f2fs_target_device (sbi, blk_addr, bio); - bio->bi_end_io = is_read ? f2fs_read_end_io : f2fs_write_end_io; - bio->bi_private = is_read ?NULL : sbi; +if (is_read) { + bio->bi_end_io = f2fs_read_end_io; + bio->bi_private =NULL ; + }else { + bio->bi_end_io = f2fs_write_end_io; + bio->bi_private = sbi; + bio->bi_write_hint =io_type_to_rw_hint (sbi, type, temp); + }if (wbc)wbc_init_bio (wbc, bio);
@@ -382,7 +389,7 @@ int f2fs_submit_page_bio(struct f2fs_io_info *fio)/* Allocate a new bio */ bio =__bio_alloc (fio->sbi, fio->new_blkaddr, fio->io_wbc, -1 ,is_read_io (fio->op)); +1 ,is_read_io (fio->op), fio->type, fio->temp);if (bio_add_page (bio, page,PAGE_SIZE ,0 ) <PAGE_SIZE ) {bio_put (bio);
@@ -445,7 +452,8 @@ int f2fs_submit_page_write(struct f2fs_io_info *fio) goto out_fail; } io->bio =__bio_alloc (sbi, fio->new_blkaddr, fio->io_wbc, -BIO_MAX_PAGES , false); +BIO_MAX_PAGES , false, + fio->type, fio->temp); io->fio = *fio; }
@@ -2287,10 +2295,13 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter) {struct address_space *mapping = iocb->ki_filp->f_mapping;struct inode *inode = mapping->host; +struct f2fs_sb_info *sbi =F2FS_I_SB (inode);size_t count =iov_iter_count (iter);loff_t offset = iocb->ki_pos;int rw =iov_iter_rw (iter);int err; +enum rw_hint hint; +int whint_mode = sbi->whint_mode; err =check_direct_IO (inode, iter, offset);if (err)
@@ -2301,11 +2312,18 @@ static ssize_t f2fs_direct_IO(struct kiocb *iocb, struct iov_iter *iter)trace_f2fs_direct_IO_enter (inode, offset, count, rw); +if (rw ==WRITE && whint_mode ==WHINT_MODE_OFF ) { + hint = iocb->ki_hint; + iocb->ki_hint =WRITE_LIFE_NOT_SET ; + } +down_read (&F2FS_I (inode)->dio_rwsem[rw]); err =blockdev_direct_IO (iocb, inode, iter, get_data_block_dio);up_read (&F2FS_I (inode)->dio_rwsem[rw]);if (rw ==WRITE ) { +if (whint_mode ==WHINT_MODE_OFF ) + iocb->ki_hint = hint;if (err >0 ) {f2fs_update_iostat (F2FS_I_SB (inode),APP_DIRECT_IO , err);
fs/f2fs/f2fs.h +9 -0
@@ -1037,6 +1037,11 @@ enum { MAX_TIME, }; +enum { +WHINT_MODE_OFF ,/* not pass down write hints */ +WHINT_MODE_USER ,/* try to pass down hints given by users */ +}; +struct f2fs_sb_info {struct super_block *sb;/* pointer to VFS super block */ struct proc_dir_entry *s_proc;/* proc entry */
@@ -1220,6 +1225,8 @@ struct f2fs_sb_info {char *s_qf_names[MAXQUOTAS ];int s_jquota_fmt;/* Format of quota to use */ #endif +/* For which write hints are passed down to block layer */ +int whint_mode; };#ifdef CONFIG_F2FS_FAULT_INJECTION
@@ -2768,6 +2775,8 @@ int lookup_journal_in_cursum(struct f2fs_journal *journal, int type,int __init create_segment_manager_caches (void );void destroy_segment_manager_caches (void );int rw_hint_to_seg_type (enum rw_hint hint); +enum rw_hint io_type_to_rw_hint (struct f2fs_sb_info *sbi,enum page_type type, +enum temp_type temp);/* * checkpoint.c
fs/f2fs/segment.c +59 -0
77 lines not on this page · raw message
fs/f2fs/super.c +29 -1
@@ -129,6 +129,7 @@ enum { Opt_jqfmt_vfsold, Opt_jqfmt_vfsv0, Opt_jqfmt_vfsv1, + Opt_whint, Opt_err, };
@@ -182,6 +183,7 @@ enum { {Opt_jqfmt_vfsold, "jqfmt=vfsold"}, {Opt_jqfmt_vfsv0, "jqfmt=vfsv0"}, {Opt_jqfmt_vfsv1, "jqfmt=vfsv1"}, + {Opt_whint, "whint_mode=%s"}, {Opt_err, NULL}, };
@@ -679,6 +681,22 @@ static int parse_options(struct super_block *sb, char *options) "quota operations not supported");break ;#endif +case Opt_whint: + name =match_strdup (&args[0 ]); +if (!name) +return -ENOMEM ; +if (strlen (name) ==10 && + !strncmp (name,"user-based" ,10 )) { + sbi->whint_mode =WHINT_MODE_USER ; + }else if (strlen (name) ==3 && + !strncmp (name,"off" ,3 )) { + sbi->whint_mode =WHINT_MODE_OFF ; + }else { +kfree (name); +return -EINVAL ; + } +kfree (name); +break ;default : f2fs_msg(sb, KERN_ERR, "Unrecognized mount option \"%s\" or missing value",
@@ -715,6 +733,12 @@ static int parse_options(struct super_block *sb, char *options)return -EINVAL ; } } + +/* Not pass down write hints if the number of active logs is lesser +* than NR_CURSEG_TYPE. +*/ +if (sbi->active_logs !=NR_CURSEG_TYPE ) + sbi->whint_mode =WHINT_MODE_OFF ;return 0 ; }
@@ -1225,6 +1249,8 @@ static int f2fs_show_options(struct seq_file *seq, struct dentry *root)seq_puts (seq,",prjquota" );#endif f2fs_show_quota_options (seq, sbi->sb); +if (sbi->whint_mode ==WHINT_MODE_USER ) +seq_printf (seq,",whint_mode=%s" ,"user-based" );return 0 ; }
@@ -1234,6 +1260,7 @@ static void default_options(struct f2fs_sb_info *sbi)/* init some FS parameters */ sbi->active_logs =NR_CURSEG_TYPE ; sbi->inline_xattr_size =DEFAULT_INLINE_XATTR_ADDRS ; + sbi->whint_mode =WHINT_MODE_OFF ;set_opt (sbi,BG_GC );set_opt (sbi,INLINE_XATTR );
@@ -1274,6 +1301,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)bool need_restart_gc = false;bool need_stop_gc = false;bool no_extent_cache = !test_opt (sbi,EXTENT_CACHE ); +int old_whint_mode = sbi->whint_mode;#ifdef CONFIG_F2FS_FAULT_INJECTION struct f2fs_fault_info ffi = sbi->fault_info;#endif
@@ -1373,7 +1401,7 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) need_stop_gc = true; } -if (*flags &SB_RDONLY ) { +if (*flags &SB_RDONLY || sbi->whint_mode != old_whint_mode) {writeback_inodes_sb (sb,WB_REASON_SYNC );sync_inodes_sb (sb);
Signature · 1 line
1.9.1
Re: [PATCH v2 1/3] f2fs: support passing down write hints given by users to block layer
On 2018/1/31 10:36, Hyunchul Lee wrote> Signed-off-by: Hyunchul Lee <[email protected]>
Thanks,
PATCH v2 2/3 f2fs: support passing down write hints to block layer with F2FS policy
In reply to Hyunchul LeeFrom: Hyunchul Lee <[email protected]>
Add 'whint_mode=fs-based' mount option. In this mode, F2FS passes down write hints with its policy.
* whint_mode=fs-based. F2FS passes down hints with its policy.
User F2FS Block
---- ---- -----
META WRITE_LIFE_MEDIUM;
HOT_NODE WRITE_LIFE_NOT_SET
WARM_NODE "
COLD_NODE WRITE_LIFE_NONE
ioctl(COLD) COLD_DATA WRITE_LIFE_EXTREME
extension list " "-- buffered io
WRITE_LIFE_EXTREME COLD_DATA WRITE_LIFE_EXTREME WRITE_LIFE_SHORT HOT_DATA WRITE_LIFE_SHORT WRITE_LIFE_NOT_SET WARM_DATA WRITE_LIFE_LONG WRITE_LIFE_NONE " " WRITE_LIFE_MEDIUM " " WRITE_LIFE_LONG " "
-- direct io
WRITE_LIFE_EXTREME COLD_DATA WRITE_LIFE_EXTREME WRITE_LIFE_SHORT HOT_DATA WRITE_LIFE_SHORT WRITE_LIFE_NOT_SET WARM_DATA WRITE_LIFE_NOT_SET WRITE_LIFE_NONE " WRITE_LIFE_NONE WRITE_LIFE_MEDIUM " WRITE_LIFE_MEDIUM WRITE_LIFE_LONG " WRITE_LIFE_LONG
Many thanks to Chao Yu and Jaegeuk Kim for comments to implement this patch.
---
v2:
- Change "case" statements to "if" statements in rw_hint_to_seg_type()
fs/f2fs/f2fs.h | 1 + fs/f2fs/segment.c | 57 ++++++++++++++++++++++++++++++++++++++++++++++--------- fs/f2fs/super.c | 5 +++++ 3 files changed, 54 insertions(+), 9 deletions(-)
fs/f2fs/f2fs.h +1 -0
@@ -1040,6 +1040,7 @@ enum {enum {WHINT_MODE_OFF ,/* not pass down write hints */ WHINT_MODE_USER ,/* try to pass down hints given by users */ +WHINT_MODE_FS ,/* pass down hints with F2FS policy */ };struct f2fs_sb_info {
fs/f2fs/segment.c +48 -9
74 lines not on this page · raw message
fs/f2fs/super.c +5 -0
@@ -691,6 +691,9 @@ static int parse_options(struct super_block *sb, char *options) }else if (strlen (name) ==3 && !strncmp (name,"off" ,3 )) { sbi->whint_mode =WHINT_MODE_OFF ; + }else if (strlen (name) ==8 && + !strncmp (name,"fs-based" ,8 )) { + sbi->whint_mode =WHINT_MODE_FS ; }else {kfree (name);return -EINVAL ;
@@ -1251,6 +1254,8 @@ static int f2fs_show_options(struct seq_file *seq, struct dentry *root)f2fs_show_quota_options (seq, sbi->sb);if (sbi->whint_mode ==WHINT_MODE_USER )seq_printf (seq,",whint_mode=%s" ,"user-based" ); +else if (sbi->whint_mode ==WHINT_MODE_FS ) +seq_printf (seq,",whint_mode=%s" ,"fs-based" );return 0 ; }
Signature · 1 line
1.9.1
Re: [PATCH v2 2/3] f2fs: support passing down write hints to block layer with F2FS policy
Quoted 1 line · Hyunchul Lee
Signed-off-by Hyunchul Lee <[email protected]>
Thanks,
PATCH v2 3/3 f2fs: Add the 'whint_mode' mount option to f2fs documentation
In reply to Hyunchul LeeFrom: Hyunchul Lee <[email protected]>
--- Documentation/filesystems/f2fs.txt | 6 ++++++ 1 file changed, 6 insertions(+)
Documentation/filesystems/f2fs.txt +6 -0
@@ -174,6 +174,12 @@ offgrpjquota Turn off group journelled quota. offprjjquota Turn off project journelled quota. quota Enable plain user disk quota accounting. noquota Disable all plain disk quota option. +whint_mode=%s Control which write hints are passed down to block + layer. This supports "off", "user-based", and + "fs-based". In "off" mode (default), f2fs does not pass + down hints. In "user-based" mode, f2fs tries to pass + down hints given by users. And in "fs-based" mode, f2fs + passes down hints with its policy. ================================================================================ DEBUGFS ENTRIES
Signature · 1 line
1.9.1
Re: [PATCH v2 3/3] f2fs: Add the 'whint_mode' mount option to f2fs documentation
On 2018/1/31 10:36, Hyunchul Lee wrote:> Signed-off-by: Hyunchul Lee <[email protected]>
Thanks,
Jaegeuk Kim
maintainerRe: [PATCH v2 3/3] f2fs: Add the 'whint_mode' mount option to f2fs documentation
In reply to Hyunchul LeeHi Hyunchul,
I've added the policy in the Doc as wel.
Thanks,
Quoted 26 lines · Hyunchul Lee
From: Hyunchul Lee <[email protected]>
Signed-off-by Hyunchul Lee <[email protected]>--- Documentation/filesystems/f2fs.txt | 6 ++++++ 1 file changed, 6 insertions(+)Documentation/filesystems/f2fs.txt +6
-0@@ -174,6 +174,12 @@ offgrpjquota Turn off group journelled quota. offprjjquota Turn off project journelled quota. quota Enable plain user disk quota accounting. noquota Disable all plain disk quota option. +whint_mode=%s Control which write hints are passed down to block + layer. This supports "off", "user-based", and + "fs-based". In "off" mode (default), f2fs does not pass + down hints. In "user-based" mode, f2fs tries to pass + down hints given by users. And in "fs-based" mode, f2fs + passes down hints with its policy. ================================================================================ DEBUGFS ENTRIESSignature · 1 line
1.9.1
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot