Patch "crypto: inside-secure - fix hash when length is a multiple of a block" has been added to the 4.14-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
crypto: inside-secure - fix hash when length is a multiple of a block
to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
crypto-inside-secure-fix-hash-when-length-is-a-multiple-of-a-block.patch
and it can be found in the queue-4.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
809778e02cd45d0625439fee67688f655627bb3cMon Sep 17 00:00:00 2001
From: =?UTF-8?q?Antoine=20T=C3=A9nart?= <[email protected]>
Date: Tue, 26 Dec 2017 17:21:17 +0100
Subject: crypto: inside-secure - fix hash when length is a multiple of a block
From: Antoine Tenart <[email protected]>
commit 809778e02cd45d0625439fee67688f655627bb3c upstream.
This patch fixes the hash support in the SafeXcel driver when the update size is a multiple of a block size, and when a final call is made just after with a size of 0. In such cases the driver should cache the last block from the update to avoid handling 0 length data on the final call (that's a hardware limitation).
--- drivers/crypto/inside-secure/safexcel_hash.c | 34 +++++++++++++++++++-------- 1 file changed, 24 insertions(+), 10 deletions(-)
drivers/crypto/inside-secure/safexcel_hash.c +24 -10
@@ -185,17 +185,31 @@ static int safexcel_ahash_send(struct crelse cache_len = queued - areq->nbytes; -/* -* If this is not the last request and the queued data does not fit -* into full blocks, cache it for the next send() call. -*/ - extra = queued & (crypto_ahash_blocksize (ahash) -1 ); -if (!req->last_req && extra) { -sg_pcopy_to_buffer (areq->src,sg_nents (areq->src), - req->cache_next, extra, areq->nbytes - extra); +if (!req->last_req) { +/* If this is not the last request and the queued data does not +* fit into full blocks, cache it for the next send() call. +*/ + extra = queued & (crypto_ahash_blocksize (ahash) -1 ); +if (!extra) +/* If this is not the last request and the queued data +* is a multiple of a block, cache the last one for now. +*/ + extra = queued -crypto_ahash_blocksize (ahash); - queued -= extra; - len -= extra; +if (extra) { +sg_pcopy_to_buffer (areq->src,sg_nents (areq->src), + req->cache_next, extra, + areq->nbytes - extra); + + queued -= extra; + len -= extra; + +if (!queued) { + *commands =0 ; + *results =0 ; +return 0 ; + } + } }spin_lock_bh (&priv->ring[ring].egress_lock);
Patches currently in stable-queue which might be from [email protected] are
queue-4.14/crypto-inside-secure-avoid-unmapping-dma-memory-that-was-not-mapped.patch queue-4.14/crypto-inside-secure-fix-hash-when-length-is-a-multiple-of-a-block.patch