Skip to contentSkip to conversation

nl80211: Fix external_auth check for offloaded authentication

PATCH New Jouni Malinen 1 participant 1 message Feb 2, 2018 802.11 (including cfg80211/NL80211)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nl80211: Fix external_auth check for offloaded authentication

From: Srinivas Dasari <[email protected]>

Unfortunately removal of the ext_feature flag in the last revision of the patch ended up negating the comparison and prevented the command from being processed (either nl80211_external_auth() or rdev_external_auth() returns -EOPNOTSUPP). Fix this by adding back the lost '!'.

Fixes 40cbfa90218b ("cfg80211/nl80211: Optional authentication offload to userspace")
---
 net/wireless/nl80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/wireless/nl80211.c +1 -1
index cc6ec5b..3b6dbc1 100644
@@ -12486,7 +12486,7 @@ static int nl80211_external_auth(struct sk_buff *skb, struct genl_info *info)
 	struct net_device *dev = info->user_ptr[1];
 	struct cfg80211_external_auth_params params;
 
-	if (rdev->ops->external_auth)
+	if (!rdev->ops->external_auth)
 		return -EOPNOTSUPP;
 
 	if (!info->attrs[NL80211_ATTR_SSID])
Signature · 1 line
2.7.4