FAILED: patch "[PATCH] fpga: region: release of_parse_phandle nodes after use" failed to apply to 4.14-stable tree
Subsystems (2)
[email protected]
maintainerThe patch below does not apply to the 4.14-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
0f5eb1545907edeea7672a9c1652c4231150ff22Mon Sep 17 00:00:00 2001
From: Ian Abbott <[email protected]>
Date: Wed, 15 Nov 2017 16:33:12 -0600
Subject: [PATCH] fpga: region: release of_parse_phandle nodes after use
Both fpga_region_get_manager() and fpga_region_get_bridges() call of_parse_phandle(), but nothing calls of_node_put() on the returned struct device_node pointers. Make sure to do that to stop their reference counters getting out of whack.
drivers/fpga/of-fpga-region.c +10 -3
@@ -73,6 +73,7 @@ static struct fpga_manager *of_fpga_region_get_mgr(struct device_node *np) mgr_node =of_parse_phandle (np,"fpga-mgr" ,0 );if (mgr_node) { mgr =of_fpga_mgr_get (mgr_node); +of_node_put (mgr_node);of_node_put (np);return mgr; }
@@ -120,10 +121,13 @@ static int of_fpga_region_get_bridges(struct fpga_region *region) parent_br = region_np->parent;/* If overlay has a list of bridges, use it. */ -if (of_parse_phandle (info->overlay,"fpga-bridges" ,0 )) + br =of_parse_phandle (info->overlay,"fpga-bridges" ,0 ); +if (br) { +of_node_put (br); np = info->overlay; -else + }else { np = region_np; + }for (i =0 ; ; i++) { br =of_parse_phandle (np,"fpga-bridges" , i);
@@ -131,12 +135,15 @@ static int of_fpga_region_get_bridges(struct fpga_region *region)break ;/* If parent bridge is in list, skip it. */ -if (br == parent_br) +if (br == parent_br) { +of_node_put (br);continue ; + }/* If node is a bridge, get it and add to list */ ret =of_fpga_bridge_get_to_list (br, info, ®ion->bridge_list); +of_node_put (br);/* If any of the bridges are in use, give up */ if (ret == -EBUSY ) {