Skip to contentSkip to conversation

Patch "test_firmware: fix missing unlock on error in config_num_requests_store()" has been added to the 4.14-stable tree

PATCH [email protected] 1 participant 1 message Feb 2, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

test_firmware: fix missing unlock on error in config_num_requests_store()

to the 4.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
test_firmware-fix-missing-unlock-on-error-in-config_num_requests_store.patch
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a5e1923356505e46476c2fb518559b7a4d9d25b1 Mon Sep 17 00:00:00 2001

From: Wei Yongjun <[email protected]>
Date: Thu, 11 Jan 2018 11:12:55 +0000
Subject: test_firmware: fix missing unlock on error in config_num_requests_store()

From: Wei Yongjun <[email protected]>

commit a5e1923356505e46476c2fb518559b7a4d9d25b1 upstream.

Add the missing unlock before return from function config_num_requests_store() in the error handling case.

Fixes c92316bf8e94 ("test_firmware: add batched firmware tests")
---
 lib/test_firmware.c |    1 +
 1 file changed, 1 insertion(+)
lib/test_firmware.c +1 -0
@@ -371,6 +371,7 @@ static ssize_t config_num_requests_store
 	if (test_fw_config->reqs) {
 		pr_err("Must call release_all_firmware prior to changing config\n");
 		rc = -EINVAL;
+		mutex_unlock(&test_fw_mutex);
 		goto out;
 	}
 	mutex_unlock(&test_fw_mutex);

Patches currently in stable-queue which might be from [email protected] are

queue-4.14/test_firmware-fix-missing-unlock-on-error-in-config_num_requests_store.patch queue-4.14/serial-8250_uniphier-fix-error-return-code-in-uniphier_uart_probe.patch