Skip to contentSkip to conversation

Patch "serial: 8250_of: fix return code when probe function fails to get reset" has been added to the 4.15-stable tree

PATCH [email protected] 1 participant 1 message Feb 2, 2018

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

serial: 8250_of: fix return code when probe function fails to get reset

to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
serial-8250_of-fix-return-code-when-probe-function-fails-to-get-reset.patch
and it can be found in the queue-4.15 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From b9820a31691b771db37afe2054dd3d3a680c1eed Mon Sep 17 00:00:00 2001

From: Masahiro Yamada <[email protected]>
Date: Wed, 27 Dec 2017 14:21:05 +0900
Subject: serial: 8250_of: fix return code when probe function fails to get reset

From: Masahiro Yamada <[email protected]>

commit b9820a31691b771db37afe2054dd3d3a680c1eed upstream.

The error pointer from devm_reset_control_get_optional_shared() is not propagated.

One of the most common problem scenarios is it returns -EPROBE_DEFER when the reset controller has not probed yet. In this case, the probe of the reset consumer should be deferred.

Fixes e2860e1f62f2 ("serial: 8250_of: Add reset support")
---
 drivers/tty/serial/8250/8250_of.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/tty/serial/8250/8250_of.c +4 -1
@@ -136,8 +136,11 @@ static int of_platform_serial_setup(stru
 	}
 
 	info->rst = devm_reset_control_get_optional_shared(&ofdev->dev, NULL);
-	if (IS_ERR(info->rst))
+	if (IS_ERR(info->rst)) {
+		ret = PTR_ERR(info->rst);
 		goto err_dispose;
+	}
+
 	ret = reset_control_deassert(info->rst);
 	if (ret)
 		goto err_dispose;

Patches currently in stable-queue which might be from [email protected] are

queue-4.15/serial-8250_of-fix-return-code-when-probe-function-fails-to-get-reset.patch queue-4.15/mtd-nand-denali_pci-add-missing-module_description-author-license.patch queue-4.15/serial-8250_uniphier-fix-error-return-code-in-uniphier_uart_probe.patch