Patch "staging: ccree: NULLify backup_info when unused" has been added to the 4.15-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
staging: ccree: NULLify backup_info when unused
to the 4.15-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
staging-ccree-nullify-backup_info-when-unused.patch
and it can be found in the queue-4.15 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
46df8824982e4fb0198776078d4a8c3e2d531464Mon Sep 17 00:00:00 2001
From: Gilad Ben-Yossef <[email protected]>
Date: Sun, 3 Dec 2017 13:58:19 +0000
Subject: staging: ccree: NULLify backup_info when unused
From: Gilad Ben-Yossef <[email protected]>
commit 46df8824982e4fb0198776078d4a8c3e2d531464 upstream.
backup_info field is only allocated for decrypt code path. The field was not nullified when not used causing a kfree in an error handling path to attempt to free random addresses as uncovered in stress testing.
--- drivers/staging/ccree/ssi_cipher.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/ccree/ssi_cipher.c +1 -0
@@ -908,6 +908,7 @@ static int ssi_ablkcipher_decrypt(structscatterwalk_map_and_copy (req_ctx->backup_info, req->src, (req->nbytes - ivsize), ivsize,0 ); req_ctx->is_giv = false; + req_ctx->backup_info =NULL ;return ssi_blkcipher_process (tfm, req_ctx, req->dst, req->src, req->nbytes, req->info, ivsize, (void *)req,DRV_CRYPTO_DIRECTION_DECRYPT ); }
Patches currently in stable-queue which might be from [email protected] are
queue-4.15/staging-ccree-fix-fips-event-irq-handling-build.patch queue-4.15/staging-ccree-nullify-backup_info-when-unused.patch