Skip to contentSkip to conversation

ima: force the re-evaluation of files on untrusted file systems

RFC PATCH In review Mimi Zohar 4 participants 8 messages Feb 5, 2018

Subsystems (5)
lore
Share & tools
lore

Mimi Zohar

author
#0 lore raw

RFC PATCH 1/1 ima: force the re-evaluation of files on untrusted file systems

On filesystems, such as fuse or remote filesystems, that we can not detect or rely on the filesystem to tell us when a file has changed, always re-measure, re-appraise, and/or re-audit the file.

---
Hi Miklos,

Was something like this what you had in mind?

Mimi

---
 security/integrity/ima/ima_main.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
security/integrity/ima/ima_main.c +10 -2
index 6d78cb26784d..a428bd75232e 100644
@@ -170,6 +170,7 @@ static int process_measurement(struct file *file, char *buf, loff_t size,
 			       int mask, enum ima_hooks func, int opened)
 {
 	struct inode *inode = file_inode(file);
+	struct dentry *dentry = file_dentry(file);
 	struct integrity_iint_cache *iint = NULL;
 	struct ima_template_desc *template_desc;
 	char *pathbuf = NULL;
@@ -228,9 +229,16 @@ static int process_measurement(struct file *file, char *buf, loff_t size,
 				 IMA_APPRAISE_SUBMASK | IMA_APPRAISED_SUBMASK |
 				 IMA_ACTION_FLAGS);
 
-	if (test_and_clear_bit(IMA_CHANGE_XATTR, &iint->atomic_flags))
-		/* reset all flags if ima_inode_setxattr was called */
+	/*
+	 * Re-measure, re-appraise, and/or re-audit a file, if the security
+	 * xattrs changed or if the file is on an untrusted file system
+	 * (eg. FUSE, remote filesystems).
+	 */
+	if (test_and_clear_bit(IMA_CHANGE_XATTR, &iint->atomic_flags) ||
+	    (dentry->d_op && dentry->d_op->d_revalidate)) {
 		iint->flags &= ~IMA_DONE_MASK;
+		iint->measured_pcrs = 0;
+	}
 
 	/* Determine if already appraised/measured based on bitmask
 	 * (IMA_MEASURE, IMA_MEASURED, IMA_XXXX_APPRAISE, IMA_XXXX_APPRAISED,
Signature · 6 lines
2.7.5

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 31 lines · Mimi Zohar

On filesystems, such as fuse or remote filesystems, that we can not detect or rely on the filesystem to tell us when a file has changed, always re-measure, re-appraise, and/or re-audit the file.

---
Hi Miklos,

Was something like this what you had in mind?

Mimi

---
 security/integrity/ima/ima_main.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
security/integrity/ima/ima_main.c +1 -0
index 6d78cb26784d..a428bd75232e 100644
@@ -170,6 +170,7 @@ static int process_measurement(struct file *file, char *buf, loff_t size,
                               int mask, enum ima_hooks func, int opened)
 {
        struct inode *inode = file_inode(file);
+       struct dentry *dentry = file_dentry(file);
        struct integrity_iint_cache *iint = NULL;
        struct ima_template_desc *template_desc;
        char *pathbuf = NULL;
@@ -228,9 +229,16 @@ static int process_measurement(struct file *file, char *buf, loff_t size,
                                 IMA_APPRAISE_SUBMASK | IMA_APPRAISED_SUBMASK |
                                 IMA_ACTION_FLAGS);

security/integrity/ima/ima_main.c static int process_measurement(struct file *file, char *buf, loff_t size, · line 238

Quoted 10 lines
security/integrity/ima/ima_main.c +7 -2
 
-       if (test_and_clear_bit(IMA_CHANGE_XATTR, &iint->atomic_flags))
-               /* reset all flags if ima_inode_setxattr was called */
+       /*
+        * Re-measure, re-appraise, and/or re-audit a file, if the security
+        * xattrs changed or if the file is on an untrusted file system
+        * (eg. FUSE, remote filesystems).
+        */
+       if (test_and_clear_bit(IMA_CHANGE_XATTR, &iint->atomic_flags) ||
+           (dentry->d_op && dentry->d_op->d_revalidate)) {

It seems dangerous to rely implicitly on "d_revalidate != NULL". vfat has a d_revalidate for handling 8.3 filenames but it's not a network filesystem.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 33 lines · Alban Crequy
Quoted 32 lines · Mimi Zohar

On filesystems, such as fuse or remote filesystems, that we can not detect or rely on the filesystem to tell us when a file has changed, always re-measure, re-appraise, and/or re-audit the file.

---
Hi Miklos,

Was something like this what you had in mind?

Mimi

---
 security/integrity/ima/ima_main.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)
security/integrity/ima/ima_main.c +1 -0
index 6d78cb26784d..a428bd75232e 100644
@@ -170,6 +170,7 @@ static int process_measurement(struct file *file, char *buf, loff_t size,
                               int mask, enum ima_hooks func, int opened)
 {
        struct inode *inode = file_inode(file);
+       struct dentry *dentry = file_dentry(file);
        struct integrity_iint_cache *iint = NULL;
        struct ima_template_desc *template_desc;
        char *pathbuf = NULL;
@@ -228,9 +229,16 @@ static int process_measurement(struct file *file, char *buf, loff_t size,
                                 IMA_APPRAISE_SUBMASK | IMA_APPRAISED_SUBMASK |
                                 IMA_ACTION_FLAGS);
 
Quoted 13 lines

security/integrity/ima/ima_main.c static int process_measurement(struct file *file, char *buf, loff_t size, · line 238

Quoted 9 lines
security/integrity/ima/ima_main.c +7 -2
-       if (test_and_clear_bit(IMA_CHANGE_XATTR, &iint->atomic_flags))
-               /* reset all flags if ima_inode_setxattr was called */
+       /*
+        * Re-measure, re-appraise, and/or re-audit a file, if the security
+        * xattrs changed or if the file is on an untrusted file system
+        * (eg. FUSE, remote filesystems).
+        */
+       if (test_and_clear_bit(IMA_CHANGE_XATTR, &iint->atomic_flags) ||
+           (dentry->d_op && dentry->d_op->d_revalidate)) {

It seems dangerous to rely implicitly on "d_revalidate != NULL". vfat has a d_revalidate for handling 8.3 filenames but it's not a network filesystem.

Files might be unnecessarily re-evaluated, impacting performance, but I'm not sure that it is dangerous. ?For example, local OCFS2 files are unnecessarily re-evaluated.

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#3 lore raw
In reply to Mimi Zohar
Quoted 3 lines · Mimi Zohar

On filesystems, such as fuse or remote filesystems, that we can not detect or rely on the filesystem to tell us when a file has changed, always re-measure, re-appraise, and/or re-audit the file.

Using the presence or absence of d_revalidate isn't definitive for uncacheable appraisals: all stacked filesystems have to implement d_revalidate just in case the underlying has it, but it doesn't mean their appraisals can't be cached if they're fully built on top of traditional filesystems (like they are in the Docker/OCI use case). ?I think the original flag approach is better. ?The only thing stackable filesystems argues for is that for them it should probably be a superblock flag so it can be per-mount point (depending on overlay composition).

d_revalidate() also strikes me as wrong from the semantic point of
view: it's about whether the path name to inode cache needs re- evaluating not whether the underlying inode could change arbitrarily. ?These are definitely related but not necessarily equivalent concepts.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 15 lines · James Bottomley
Quoted 3 lines · Mimi Zohar

On filesystems, such as fuse or remote filesystems, that we can not detect or rely on the filesystem to tell us when a file has changed, always re-measure, re-appraise, and/or re-audit the file.

Using the presence or absence of d_revalidate isn't definitive for uncacheable appraisals: all stacked filesystems have to implement d_revalidate just in case the underlying has it, but it doesn't mean their appraisals can't be cached if they're fully built on top of traditional filesystems (like they are in the Docker/OCI use case). I think the original flag approach is better. The only thing stackable filesystems argues for is that for them it should probably be a superblock flag so it can be per-mount point (depending on overlay composition).

Quoted 4 lines

d_revalidate() also strikes me as wrong from the semantic point of
view: it's about whether the path name to inode cache needs re- evaluating not whether the underlying inode could change arbitrarily.
These are definitely related but not necessarily equivalent concepts.

True. A more precise indication is whether cache pages have been
invalidated for a certain inode. Can we used that? I.e.
invalidate_inode_pages*() calls down into IMA or sets a flags or whatever to indicate that the file contents might have changed.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#5 lore raw
Quoted 22 lines · Miklos Szeredi
Quoted 15 lines · James Bottomley
Quoted 3 lines · Mimi Zohar

On filesystems, such as fuse or remote filesystems, that we can not detect or rely on the filesystem to tell us when a file has changed, always re-measure, re-appraise, and/or re-audit the file.

Using the presence or absence of d_revalidate isn't definitive for uncacheable appraisals: all stacked filesystems have to implement d_revalidate just in case the underlying has it, but it doesn't mean their appraisals can't be cached if they're fully built on top of traditional filesystems (like they are in the Docker/OCI use case). I think the original flag approach is better. The only thing stackable filesystems argues for is that for them it should probably be a superblock flag so it can be per-mount point (depending on overlay composition).

Quoted 4 lines

d_revalidate() also strikes me as wrong from the semantic point of
view: it's about whether the path name to inode cache needs re- evaluating not whether the underlying inode could change arbitrarily.
These are definitely related but not necessarily equivalent concepts.

Quoted 4 lines

True. A more precise indication is whether cache pages have been
invalidated for a certain inode. Can we used that? I.e.
invalidate_inode_pages*() calls down into IMA or sets a flags or whatever to indicate that the file contents might have changed.

I don't think that works for the FUSE use case.

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#6 lore raw
Quoted 23 lines · Mimi Zohar
Quoted 22 lines · Miklos Szeredi
Quoted 19 lines · James Bottomley
Quoted 3 lines · Mimi Zohar

On filesystems, such as fuse or remote filesystems, that we can not detect or rely on the filesystem to tell us when a file has changed, always re-measure, re-appraise, and/or re-audit the file.

Using the presence or absence of d_revalidate isn't definitive for uncacheable appraisals: all stacked filesystems have to implement d_revalidate just in case the underlying has it, but it doesn't mean their appraisals can't be cached if they're fully built on top of traditional filesystems (like they are in the Docker/OCI use case). I think the original flag approach is better. The only thing stackable filesystems argues for is that for them it should probably be a superblock flag so it can be per-mount point (depending on overlay composition).

d_revalidate() also strikes me as wrong from the semantic point of
view: it's about whether the path name to inode cache needs re- evaluating not whether the underlying inode could change arbitrarily.
These are definitely related but not necessarily equivalent concepts.

Quoted 6 lines
Quoted 4 lines

True. A more precise indication is whether cache pages have been
invalidated for a certain inode. Can we used that? I.e.
invalidate_inode_pages*() calls down into IMA or sets a flags or whatever to indicate that the file contents might have changed.

I don't think that works for the FUSE use case.

Okay, it's true that cache invalidation is just a hint about file contents changing. The file contents could change without cache invalidation if userspace filesystem is buggy or malicious.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#7 lore raw
Quoted 29 lines · Miklos Szeredi
Quoted 28 lines · Mimi Zohar
Quoted 26 lines · Miklos Szeredi
Quoted 15 lines · James Bottomley
Quoted 3 lines · Mimi Zohar

On filesystems, such as fuse or remote filesystems, that we can not detect or rely on the filesystem to tell us when a file has changed, always re-measure, re-appraise, and/or re-audit the file.

Using the presence or absence of d_revalidate isn't definitive for uncacheable appraisals: all stacked filesystems have to implement d_revalidate just in case the underlying has it, but it doesn't mean their appraisals can't be cached if they're fully built on top of traditional filesystems (like they are in the Docker/OCI use case). I think the original flag approach is better. The only thing stackable filesystems argues for is that for them it should probably be a superblock flag so it can be per-mount point (depending on overlay composition).

Quoted 4 lines

d_revalidate() also strikes me as wrong from the semantic point of
view: it's about whether the path name to inode cache needs re- evaluating not whether the underlying inode could change arbitrarily.
These are definitely related but not necessarily equivalent concepts.

True. A more precise indication is whether cache pages have been
invalidated for a certain inode. Can we used that? I.e.
invalidate_inode_pages*() calls down into IMA or sets a flags or whatever to indicate that the file contents might have changed.

Quoted 5 lines
Quoted 1 line

I don't think that works for the FUSE use case.

Okay, it's true that cache invalidation is just a hint about file contents changing. The file contents could change without cache invalidation if userspace filesystem is buggy or malicious.

Right, the untrusted, malicious userspace filesystem is the reason for Alban's patches. ?Can you review/ack those patches?

thanks,

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html