Skip to contentSkip to conversation

Broadwell-DE Implementation

PATCH New vnktux 3 participants 4 messages Jan 25, 2018 – Feb 5, 2018

Subsystems (2)
lore
Share & tools
lore

vnktux

author
#0 lore raw

PATCH 1/1 Broadwell-DE Implementation

Hi all,

This patch contain a working implementation of Broadwell-DE for U-Boot, and support memory down with external SPD binary file. However there is only one issue that I couldn't solve, the booting process takes 1 hour. When the FSP reach "DDRIO Initialization" it take a lot before the memory is initialized and you can reach the U-Boot shell. I would like a review of my implementation since I am out of options. I tried to Enable/Disable MRC Cache and ACPI Resume but the problem is still there.

Best regards,
Vincenzo Bove

---

arch/x86/Kconfig                                   |   29 +
arch/x86/cpu/Makefile                              |    1 +
arch/x86/cpu/broadwell-de/Kconfig                  |   70 +
arch/x86/cpu/broadwell-de/Makefile                 |   10 +
arch/x86/cpu/broadwell-de/acpi.c                   |  234 +++
arch/x86/cpu/broadwell-de/broadwell_de.c           |   38 +
arch/x86/cpu/broadwell-de/cpu.c                    |   98 +
arch/x86/cpu/broadwell-de/fsp_configs.c            |  292 +++
arch/x86/dts/Makefile                              |    1 +
arch/x86/dts/poseidon.dts                          |  210 ++
arch/x86/dts/u-boot.dtsi                           |    6 +
.../asm/arch-broadwell-de/acpi/global_nvs.asl      |   15 +
.../asm/arch-broadwell-de/acpi/irq_helper.h        |   36 +
.../asm/arch-broadwell-de/acpi/irqlinks.asl        |  454 +++++
.../asm/arch-broadwell-de/acpi/irqroute.asl        |   29 +
.../include/asm/arch-broadwell-de/acpi/irqroute.h  |   31 +
.../x86/include/asm/arch-broadwell-de/acpi/lpc.asl |   81 +
.../include/asm/arch-broadwell-de/acpi/pcie1.asl   |  455 +++++
.../asm/arch-broadwell-de/acpi/platform.asl        |   61 +
.../asm/arch-broadwell-de/acpi/southcluster.asl    |  339 ++++
arch/x86/include/asm/arch-broadwell-de/device.h    |  116 ++
.../asm/arch-broadwell-de/fsp/fsp_configs.h        |  134 ++
.../include/asm/arch-broadwell-de/fsp/fsp_vpd.h    |  116 ++
.../x86/include/asm/arch-broadwell-de/global_nvs.h |   21 +
arch/x86/include/asm/arch-broadwell-de/iomap.h     |   58 +
arch/x86/include/asm/arch-broadwell-de/irq.h       |   88 +
board/prodrive/Kconfig                             |   23 +
board/prodrive/poseidon/.gitignore                 |    5 +
board/prodrive/poseidon/Kconfig                    |   45 +
board/prodrive/poseidon/MAINTAINERS                |    6 +
board/prodrive/poseidon/Makefile                   |    8 +
board/prodrive/poseidon/acpi/mainboard.asl         |   11 +
board/prodrive/poseidon/dsdt.asl                   |  187 ++
board/prodrive/poseidon/poseidon.c                 |   18 +
configs/poseidon_defconfig                         |   70 +
include/configs/poseidon.h                         |   29 +
include/configs/x86-common.h                       |   17 +-
include/fdtdec.h                                   |    1 +
lib/fdtdec.c                                       |    1 +
tools/binman/etype/intel_spd.py                    |   14 +
49 files changed, 10260 insertions(+), 1 deletion(-)

create mode 100644 arch/x86/cpu/broadwell-de/Kconfig
create mode 100644 arch/x86/cpu/broadwell-de/Makefile
create mode 100644 arch/x86/cpu/broadwell-de/acpi.c
create mode 100644 arch/x86/cpu/broadwell-de/broadwell_de.c
create mode 100644 arch/x86/cpu/broadwell-de/cpu.c
create mode 100644 arch/x86/cpu/broadwell-de/fsp_configs.c
create mode 100644 arch/x86/dts/poseidon.dts
create mode 100644 arch/x86/include/asm/arch-broadwell-de/acpi/global_nvs.asl create mode 100644 arch/x86/include/asm/arch-broadwell-de/acpi/irq_helper.h create mode 100644 arch/x86/include/asm/arch-broadwell-de/acpi/irqlinks.asl create mode 100644 arch/x86/include/asm/arch-broadwell-de/acpi/irqroute.asl create mode 100644 arch/x86/include/asm/arch-broadwell-de/acpi/irqroute.h create mode 100644 arch/x86/include/asm/arch-broadwell-de/acpi/lpc.asl create mode 100644 arch/x86/include/asm/arch-broadwell-de/acpi/pcie1.asl create mode 100644 arch/x86/include/asm/arch-broadwell-de/acpi/platform.asl create mode 100644 arch/x86/include/asm/arch-broadwell-de/acpi/southcluster.asl create mode 100644 arch/x86/include/asm/arch-broadwell-de/device.h create mode 100644 arch/x86/include/asm/arch-broadwell-de/fsp/fsp_configs.h create mode 100644 arch/x86/include/asm/arch-broadwell-de/fsp/fsp_vpd.h create mode 100644 arch/x86/include/asm/arch-broadwell-de/global_nvs.h create mode 100644 arch/x86/include/asm/arch-broadwell-de/iomap.h create mode 100644 arch/x86/include/asm/arch-broadwell-de/irq.h create mode 100644 board/prodrive/Kconfig
create mode 100644 board/prodrive/poseidon/.gitignore
create mode 100644 board/prodrive/poseidon/Kconfig
create mode 100644 board/prodrive/poseidon/MAINTAINERS
create mode 100644 board/prodrive/poseidon/Makefile
create mode 100644 board/prodrive/poseidon/acpi/mainboard.asl create mode 100644 board/prodrive/poseidon/dsdt.asl
create mode 100644 board/prodrive/poseidon/poseidon.c
create mode 100644 configs/poseidon_defconfig
create mode 100644 include/configs/poseidon.h
create mode 100644 tools/binman/etype/intel_spd.py

arch/x86/Kconfig +0 -0
index 5c23b2c..57fdcd7 100644
@@ -78,6 +78,9 @@ config VENDOR_GOOGLE

config VENDOR_INTEL
bool "Intel"

+config VENDOR_PRODRIVE
+ bool "Prodrive"
+
endchoice

# subarchitectures-specific options below
@@ -105,11 +108,13 @@ source "board/efi/Kconfig"
source "board/emulation/Kconfig"
source "board/google/Kconfig"
source "board/intel/Kconfig"
+source "board/prodrive/Kconfig"
# platform-specific options below
source "arch/x86/cpu/baytrail/Kconfig"
source "arch/x86/cpu/braswell/Kconfig"
source "arch/x86/cpu/broadwell/Kconfig"
+source "arch/x86/cpu/broadwell-de/Kconfig"
source "arch/x86/cpu/coreboot/Kconfig"
source "arch/x86/cpu/ivybridge/Kconfig"
source "arch/x86/cpu/qemu/Kconfig"
@@ -766,6 +771,30 @@ config HIGH_TABLE_SIZE
  Increse it if the default size does not fit the board's needs.
  This is most likely due to a large ACPI DSDT table is used.

+config FSP_MEMORY_DOWN
+ bool "Platform has memory down"
+ help
+ Select this option if your platform has memory soldered on the motherboard and FSP need SPD file.
+
+config HAVE_SPD
+ bool "Add SPD file"
+ help
+ Select this option if you have a SPD binary file for your memorydown.
+
+config SPD_FILE
+ string "SPD image filename"
+ depends on HAVE_SPD
+ default "spd_ch0_dimm0.bin"
+ help
+ The filename of the ram SPD binary.
+
+config SPD_ADDR
+ hex "SPD image location"
+ depends on HAVE_SPD
+ default 0xffcb0000
+ help
+ The location of the SPD binary file.
+
source "arch/x86/lib/efi/Kconfig"

endmenu

arch/x86/cpu/Makefile +0 -0
index 94cdff1..1fb1c40 100644
@@ -29,6 +29,7 @@ obj-y += intel_common/

obj-$(CONFIG_INTEL_BAYTRAIL) += baytrail/ obj-$(CONFIG_INTEL_BRASWELL) += braswell/ obj-$(CONFIG_INTEL_BROADWELL) += broadwell/ +obj-$(CONFIG_INTEL_BROADWELL_DE) += broadwell-de/ obj-$(CONFIG_SYS_COREBOOT) += coreboot/ obj-$(CONFIG_EFI_APP) += efi/ obj-$(CONFIG_QEMU) += qemu/

arch/x86/cpu/broadwell-de/Kconfig new file +70 -0

70 lines not on this page · raw message

arch/x86/cpu/broadwell-de/Makefile new file +10 -0
new file mode 100644
index 0000000..0fa427e
@@ -0,0 +1,10 @@
+#
+# Copyright (C) 2017, Vincenzo Bove <[email protected]>
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y += cpu.o
+obj-y += fsp_configs.o
+obj-y += broadwell_de.o
+obj-$(CONFIG_GENERATE_ACPI_TABLE) += acpi.o
arch/x86/cpu/broadwell-de/acpi.c new file +234 -0

234 lines not on this page · raw message

arch/x86/cpu/broadwell-de/broadwell_de.c new file +38 -0
new file mode 100644
index 0000000..54afde7
@@ -0,0 +1,38 @@
+/*
+ * Copyright (C) 2017, Vincenzo Bove <[email protected]>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <common.h>
+#include <asm/mrccache.h>
+#include <asm/post.h>
+
+int arch_cpu_init(void)
+{
+ post_code(POST_CPU_INIT);
+
+ return x86_cpu_init_f();
+}
+
+int arch_misc_init(void)
+{
+#ifdef CONFIG_ENABLE_MRC_CACHE
+ /*
+ * We intend not to check any return value here, as even MRC cache
+ * is not saved successfully, it is not a severe error that will
+ * prevent system from continuing to boot.
+ */
+ mrccache_save();
+#endif
+
+ return 0;
+}
+
+
+
+void reset_cpu(ulong addr)
+{
+ /* cold reset */
+ x86_full_reset();
+}
arch/x86/cpu/broadwell-de/cpu.c new file +98 -0

98 lines not on this page · raw message

arch/x86/cpu/broadwell-de/fsp_configs.c new file +292 -0

292 lines not on this page · raw message

arch/x86/dts/Makefile +0 -0
index 6d0c4b6..e59f192 100644
@@ -15,6 +15,7 @@ dtb-y += bayleybay.dtb \

efi.dtb \
galileo.dtb \
minnowmax.dtb \
+ poseidon.dtb \
qemu-x86_i440fx.dtb \
qemu-x86_q35.dtb \
theadorable-x86-dfi-bt700.dtb \

arch/x86/dts/poseidon.dts new file +210 -0

210 lines not on this page · raw message

arch/x86/dts/u-boot.dtsi +0 -0
index 7e37d4f..486abe3 100644
@@ -67,6 +67,12 @@

pos = <CONFIG_VGA_BIOS_ADDR>;
};
#endif
+#ifdef CONFIG_HAVE_SPD
+ intel-spd {
+ filename = CONFIG_SPD_FILE;
+ pos = <CONFIG_SPD_ADDR>;
+ };
+#endif
#ifdef CONFIG_HAVE_VBT
intel-vbt {
filename = CONFIG_VBT_FILE;

arch/x86/include/asm/arch-broadwell-de/acpi/global_nvs.asl new file +15 -0
new file mode 100644
index 0000000..a28d4df
@@ -0,0 +1,15 @@
+/*
+ * Copyright (C) 2016 Bin Meng <[email protected]>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <asm/acpi/global_nvs.h>
+
+OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
+Field(GNVS, ByteAcc, NoLock, Preserve)
+{
+ Offset (0x00),
+ PCNT, 8, /* processor count */
+ IURE, 8, /* internal UART enabled */
+}
arch/x86/include/asm/arch-broadwell-de/acpi/irq_helper.h new file +36 -0
new file mode 100644
index 0000000..5bdddd7
@@ -0,0 +1,36 @@
+/*
+ * Copyright (C) 2017, Vincenzo Bove <[email protected]>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#undef PCI_DEV_PIRQ_ROUTES
+#undef ACPI_DEV_IRQ
+#undef PCI_DEV_PIRQ_ROUTE
+#undef PIRQ_PIC_ROUTES
+#undef PIRQ_PIC
+#undef IRQROUTE_H
+
+#if defined(PIC_MODE)
+
+#define ACPI_DEV_IRQ(dev_, pin_, pin_name_) \
+ { Package() { ## dev_ ## ffff, pin_, \_SB.PCI0.LPCB.LNK ## pin_name_, 0 } }
+
+#else /* defined(PIC_MODE) */
+
+#define ACPI_DEV_IRQ(dev_, pin_, pin_name_) \
+ { Package() { ## dev_ ## ffff, pin_, 0, PIRQ ## pin_name_ ## _APIC_IRQ } }
+
+#endif
+
+#define PCI_DEV_PIRQ_ROUTE(dev_, a_, b_, c_, d_) \
+ { ACPI_DEV_IRQ(dev_, 0, a_), \
+   ACPI_DEV_IRQ(dev_, 1, b_), \
+   ACPI_DEV_IRQ(dev_, 2, c_), \
+   ACPI_DEV_IRQ(dev_, 3, d_)  }
+
+/* Empty PIRQ_PIC definition. */
+#define PIRQ_PIC(pirq_, pic_irq_)
+
+///* Include the mainboard irq route definition */
+#include "irqroute.h"
arch/x86/include/asm/arch-broadwell-de/acpi/irqlinks.asl new file +454 -0

454 lines not on this page · raw message

arch/x86/include/asm/arch-broadwell-de/acpi/irqroute.asl new file +29 -0
new file mode 100644
index 0000000..39c7a19
@@ -0,0 +1,29 @@
+/*
+ * Copyright (C) 2017, Vincenzo Bove <[email protected]>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+/* PCI Interrupt Routing */
+Method(_PRT)
+{
+ /*
+ * PICM comes from _PIC, which returns the following:
+ * 0 - PIC mode
+ * 1 - APIC mode
+ * 2 - SAPIC mode
+ */
+ If (PICM) {
+ Return (Package() {
+ #undef PIC_MODE
+ #include "irq_helper.h"
+ PCI_DEV_PIRQ_ROUTES
+ })
+ } Else {
+ Return (Package() {
+ #define PIC_MODE
+ #include "irq_helper.h"
+ PCI_DEV_PIRQ_ROUTES
+ })
+ }
+}
arch/x86/include/asm/arch-broadwell-de/acpi/irqroute.h new file +31 -0
new file mode 100644
index 0000000..27701db
@@ -0,0 +1,31 @@
+/*
+ * Copyright (C) 2017, Vincenzo Bove <[email protected]>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#include <asm/arch/device.h>
+
+#define PCI_DEV_PIRQ_ROUTES \
+ PCI_DEV_PIRQ_ROUTE(XHCI_DEV,  A, B, C, D), \
+ PCI_DEV_PIRQ_ROUTE(ME_DEV,    A, B, C, D), \
+ PCI_DEV_PIRQ_ROUTE(GBE_DEV,   A, B, C, D), \
+ PCI_DEV_PIRQ_ROUTE(HDA_DEV,   A, B, C, D), \
+ PCI_DEV_PIRQ_ROUTE(PCIE_DEV,  A, B, C, D), \
+ PCI_DEV_PIRQ_ROUTE(EHCI1_DEV, A, B, C, D), \
+ PCI_DEV_PIRQ_ROUTE(SATA_DEV,  A, B, C, D)
+
+/*
+* Route each PIRQ[A-H] to a PIC IRQ[0-15]
+* Reserved: 0, 1, 2, 8, 13
+* ACPI/SCI: 9
+*/
+#define PIRQ_PIC_ROUTES \
+ PIRQ_PIC(A,  5), \
+ PIRQ_PIC(B,  6), \
+ PIRQ_PIC(C,  7), \
+ PIRQ_PIC(D, 10), \
+ PIRQ_PIC(E, 11), \
+ PIRQ_PIC(F, 12), \
+ PIRQ_PIC(G, 14), \
+ PIRQ_PIC(H, 15)
arch/x86/include/asm/arch-broadwell-de/acpi/lpc.asl new file +81 -0

81 lines not on this page · raw message

arch/x86/include/asm/arch-broadwell-de/acpi/pcie1.asl new file +455 -0

455 lines not on this page · raw message

arch/x86/include/asm/arch-broadwell-de/acpi/platform.asl new file +61 -0

61 lines not on this page · raw message

arch/x86/include/asm/arch-broadwell-de/acpi/southcluster.asl new file +339 -0

339 lines not on this page · raw message

arch/x86/include/asm/arch-broadwell-de/device.h new file +116 -0

116 lines not on this page · raw message

arch/x86/include/asm/arch-broadwell-de/fsp/fsp_configs.h new file +134 -0

134 lines not on this page · raw message

arch/x86/include/asm/arch-broadwell-de/fsp/fsp_vpd.h new file +116 -0

116 lines not on this page · raw message

arch/x86/include/asm/arch-broadwell-de/global_nvs.h new file +21 -0
new file mode 100644
index 0000000..5097cc1
@@ -0,0 +1,21 @@
+/*
+ * Copyright (C) 2016, Bin Meng <[email protected]>
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ */
+
+#ifndef _BROADWELL_DE_GLOBAL_NVS_H_
+#define _BROADWELL_DE_GLOBAL_NVS_H_
+
+struct __packed acpi_global_nvs {
+ u8 pcnt; /* processor count */
+ u8 iuart_en; /* internal UART enabled */
+
+ /*
+ * Add padding so sizeof(struct acpi_global_nvs) == 0x100.
+ * This must match the size defined in the global_nvs.asl.
+ */
+ u8 rsvd[254];
+};
+
+#endif /* _BROADWELL_DE_GLOBAL_NVS_H_ */
arch/x86/include/asm/arch-broadwell-de/iomap.h new file +58 -0

58 lines not on this page · raw message

arch/x86/include/asm/arch-broadwell-de/irq.h new file +88 -0

88 lines not on this page · raw message

board/prodrive/Kconfig new file +23 -0
new file mode 100644
index 0000000..4828b65
@@ -0,0 +1,23 @@
+#
+# Copyright (C) 2017, Vincenzo Bove <[email protected]>
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+if VENDOR_PRODRIVE
+
+choice
+ prompt "Mainboard model"
+ optional
+
+config TARGET_POSEIDON
+ bool "Poseidon"
[… more lines in the raw message]

Lines of this file are not shown. View the raw message.

board/prodrive/poseidon/.gitignore new file +5 -0
new file mode 100644
index 0000000..c782010

Lines of this file are not shown. View the raw message.

board/prodrive/poseidon/Kconfig new file +45 -0

45 lines not on this page · raw message

board/prodrive/poseidon/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000..c21f2e6

Lines of this file are not shown. View the raw message.

board/prodrive/poseidon/Makefile new file +8 -0
new file mode 100644
index 0000000..83fd499

Lines of this file are not shown. View the raw message.

board/prodrive/poseidon/acpi/mainboard.asl new file +11 -0
new file mode 100644
index 0000000..4cc8ad3

Lines of this file are not shown. View the raw message.

board/prodrive/poseidon/dsdt.asl new file +187 -0

187 lines not on this page · raw message

configs/poseidon_defconfig new file +70 -0

70 lines not on this page · raw message

include/configs/poseidon.h new file +29 -0
new file mode 100644
index 0000000..739ca8e

Lines of this file are not shown. View the raw message.

include/configs/x86-common.h +0 -0
index 994214e..e415f36 100644
@@ -19,16 +19,20 @@

The rest of this diff is not shown. View the raw message.

#define CONFIG_PHYSMEM
#define CONFIG_DISPLAY_BOARDINFO_LATE
#define CONFIG_LAST_STAGE_INIT
-#define CONFIG_NR_DRAM_BANKS 8
+#define CONFIG_NR_DRAM_BANKS 1

#define CONFIG_LMB
+#define CONFIG_LZO

#undef CONFIG_ZLIB
#undef CONFIG_GZIP
#define CONFIG_SYS_BOOTM_LEN (16 << 20)

/* SATA AHCI storage */
+
+#define CONFIG_SCSI_AHCI
#ifdef CONFIG_SCSI_AHCI
+#define CONFIG_LIBATA
#define CONFIG_LBA48
#define CONFIG_SYS_64BIT_LBA

@@ -58,6 +62,8 @@
#define CONFIG_CMDLINE_EDITING
#define CONFIG_AUTO_COMPLETE

+#define CONFIG_SUPPORT_VFAT
+ /*-----------------------------------------------------------------------
* Command line configuration.
*/
@@ -74,11 +80,19 @@
*/
#define CONFIG_SYS_LONGHELP
#define CONFIG_SYS_CBSIZE 512
+#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
+ sizeof(CONFIG_SYS_PROMPT) + \
+ 16)
+#define CONFIG_SYS_MAXARGS 16
+#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE

#define CONFIG_SYS_MEMTEST_START 0x00100000
#define CONFIG_SYS_MEMTEST_END 0x01000000
#define CONFIG_SYS_LOAD_ADDR 0x20000000

+/* Fat write configuration */
+#define CONFIG_FAT_WRITE
+ /*-----------------------------------------------------------------------
* CPU Features
*/
@@ -98,6 +112,7 @@ /*-----------------------------------------------------------------------
* Environment configuration
*/
+#define CONFIG_ENV_IS_IN_SPI_FLASH
#define CONFIG_ENV_SIZE 0x01000

/*-----------------------------------------------------------------------

include/fdtdec.h +0 -0
index 4afb9ac..ea8bff4 100644
@@ -150,6 +150,7 @@ enum fdt_compat_id {

COMPAT_INTEL_BAYTRAIL_FSP, /* Intel Bay Trail FSP */ COMPAT_INTEL_BAYTRAIL_FSP_MDP, /* Intel FSP memory-down params */ COMPAT_INTEL_IVYBRIDGE_FSP, /* Intel Ivy Bridge FSP */
+ COMPAT_INTEL_BROADWELL_DE_FSP, /* Intel Broadwell-DE FSP */ COMPAT_SUNXI_NAND, /* SUNXI NAND controller */ COMPAT_ALTERA_SOCFPGA_CLK, /* SoCFPGA Clock initialization */ COMPAT_ALTERA_SOCFPGA_PINCTRL_SINGLE, /* SoCFPGA pinctrl-single */

lib/fdtdec.c +0 -0
index df9d9ae..e1a2f17 100644
@@ -62,6 +62,7 @@ static const char * const compat_names[COMPAT_COUNT] = {

COMPAT(INTEL_BAYTRAIL_FSP, "intel,baytrail-fsp"), COMPAT(INTEL_BAYTRAIL_FSP_MDP, "intel,baytrail-fsp-mdp"), COMPAT(INTEL_IVYBRIDGE_FSP, "intel,ivybridge-fsp"),
+ COMPAT(INTEL_BROADWELL_DE_FSP, "intel,broadwell-de-fsp"), COMPAT(COMPAT_SUNXI_NAND, "allwinner,sun4i-a10-nand"), COMPAT(ALTERA_SOCFPGA_CLK, "altr,clk-mgr"), COMPAT(ALTERA_SOCFPGA_PINCTRL_SINGLE, "pinctrl-single"),

tools/binman/etype/intel_spd.py new file +14 -0
new file mode 100644
index 0000000..028c98f

Lines of this file are not shown. View the raw message.

The rest of this diff is not shown. View the raw message.

--
2.9.2.windows.1

Part of the diff is not shown here. View the raw message.

#1 lore raw

PATCH 1/1 Broadwell-DE Implementation

Hi Vincenzo,

Quoted 10 lines · vnktux

Hi all,

This patch contain a working implementation of Broadwell-DE for U-Boot, and support memory down with external SPD binary file. However there is only one issue that I couldn't solve, the booting process takes 1 hour. When the FSP reach "DDRIO Initialization" it take a lot before the memory is initialized and you can reach the U-Boot shell. I would like a review of my implementation since I am out of options. I tried to Enable/Disable MRC Cache and ACPI Resume but the problem is still there.

Quoted 5 lines

Best regards,
Vincenzo Bove

---

Please make sure you follow https://www.denx.de/wiki/U-Boot/Patches to send your patches. Thanks!

Regards,
Bin

#2 lore raw

PATCH 1/1 Broadwell-DE Implementation

In reply to vnktux

Hi Vincenzo,

Quoted 10 lines · vnktux

Hi all,

This patch contain a working implementation of Broadwell-DE for U- Boot, and support memory down with external SPD binary file. However there is only one issue that I couldn't solve, the booting process takes 1 hour. When the FSP reach "DDRIO Initialization" it take a lot before the memory is initialized and you can reach the U-Boot shell. I would like a review of my implementation since I am out of options. I tried to Enable/Disable MRC Cache and ACPI Resume but the problem is still there.

Thanks for the Broadwell-DE work.  It'd be nice to have a port!  I tried your code on one of our Broadwell-DE board this weekend and saw similar behavior to you with the slow boot time.  I believe this is related to cache configuration.  A modification like the following makes my board boot quickly (sub 10 seconds):

arch/x86/lib/fsp/fsp_car.S +0 -0
@@ -106,5 +106,5 @@ _dt_ucode_base_size:

 ucode_base:    /* Declared in micrcode.h */
        .long   0                       /* microcode base */ .long   0                       /* microcode size */ -       .long   CONFIG_SYS_MONITOR_BASE /* code region base */ -       .long   CONFIG_SYS_MONITOR_LEN  /* code region size */ +       .long   0xffffffff - 0x1000000 + 1      /* code region base */ +       .long   0x1000000                       /* code region size */

The above is just a proof of concept meant to show the problem area - a more elegant solution should likely be used.  The "code region" above is passed into the FSP, which I believe enables caching in that region. Increasing it from 1MB to 16MB (the size of my SPI flash) made the boot time more sane.

The latest patch series also seems to have whitespace issues so that it can't apply cleanly without modification.  As an example, arch/x86/dts/u-boot.dtsi has indentation that is not present in  https:
//patchwork.ozlabs.org/patch/866257/ which makes it not apply.  It'd be good to fix that on future submissions.

The patch series seemed to mostly work out of the box to get up to a command prompt, which is great!  It could boot a Linuz zImage as well. There seemed to be some rough edges (eg multi processor support), but I didn't kick the tires too much and assume those edges shouldn't be too bad to smooth out later.

Regards,
Peter

author
#3 lore raw

PATCH 1/1 Broadwell-DE Implementation

Hi Peter,

Thanks a lot, your help was really precious! I just tested your fix on two platforms, one with memory down and one with DIMM. U-Boot works on both of them and the booting time is around 17 seconds. Now I will try to fix some minor errors that U-Boot report on the shell and then I will definetly submit a new patch. (If I manage to understand how to properly submit one). Thanks again!

Best regards,
Vincenzo