ath9k: break out of irq handler after 5 jiffies
PATCH 1/1 ath9k: break out of irq handler after 5 jiffies
From: Ben Greear <[email protected]>
In case where the system is sluggish, we should probably break out early. Maybe this will fix issues where the OS thinks the IRQ handler is not responding and disables the IRQ because 'nobody cared'
--- drivers/net/wireless/ath/ath9k/recv.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/wireless/ath/ath9k/recv.c +4 -0
@@ -1084,6 +1084,7 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)dma_addr_t new_buf_addr;unsigned int budget =512 ;struct ieee80211_hdr *hdr; +unsigned long expires_jiffies = jiffies +5 ;if (edma) dma_type =DMA_BIDIRECTIONAL ;
@@ -1241,6 +1242,9 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)if (!budget--)break ; + +if (time_is_before_jiffies (expires_jiffies)) +break ; }while (1 );if (!(ah->imask &ATH9K_INT_RXEOL )) {
Signature · 1 line
2.4.11
Quoted 7 lines · On 2018-02-07 00:05, [email protected] wrote:
From: Ben Greear <[email protected]>
In case where the system is sluggish, we should probably break out early. Maybe this will fix issues where the OS thinks the IRQ handler is not responding and disables the IRQ because 'nobody cared'
Signed-off-by Ben Greear <[email protected]>
5 jiffies as a hardcoded value is a bad idea, since it produces different behavior based on CONFIG_HZ.
- Felix
Quoted 11 lines · Felix Fietkau
Quoted 7 lines · On 2018-02-07 00:05, [email protected] wrote:
From: Ben Greear <[email protected]>
In case where the system is sluggish, we should probably break out early. Maybe this will fix issues where the OS thinks the IRQ handler is not responding and disables the IRQ because 'nobody cared'
Signed-off-by Ben Greear <[email protected]>5 jiffies as a hardcoded value is a bad idea, since it produces different behavior based on
CONFIG_HZ.
Also, err, NAPI? Or is something else is going on here?
johannes
Quoted 4 lines · Johannes Berg
Quoted 3 lines · Felix Fietkau
Quoted 2 lines · On 2018-02-07 00:05, [email protected] wrote:
From: Ben Greear <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
In case where the system is sluggish, we should probably break out early. Maybe this will fix issues where the OS thinks the IRQ handler is not responding and disables the IRQ because 'nobody cared'
Signed-off-by Ben Greear <[email protected]>5 jiffies as a hardcoded value is a bad idea, since it produces different behavior based on
CONFIG_HZ.
I figured that was a benefit since it would run shorter duration on systems with a faster HZ clock.
Quoted 2 lines
Also, err, NAPI? Or is something else is going on here?
I don't really know, but part of my test was running traffic while creating 1200 stations, so likely there were lots of higher-level lock contention that slowed down sending pkts up the stack.
I got a bunch of errors about IRQs being ignored because nobody cared. I noticed that the ath9k loop could handle up to 500 or so frames, and that seemed like too many for my particular test case.
Once I put in this patch, I did not see the 'nobody cared' error again.
There could easily be a better fix. If you all want me to use a fixed time instead of HZ, then please suggest a value. I was testing with HZ of 1000, btw.
Thanks,
Ben
Quoted 3 lines
johannes
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com
Quoted 26 lines · Ben Greear
Quoted 4 lines · Johannes Berg
Quoted 3 lines · Felix Fietkau
Quoted 2 lines · On 2018-02-07 00:05, [email protected] wrote:
From: Ben Greear <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
In case where the system is sluggish, we should probably break out early. Maybe this will fix issues where the OS thinks the IRQ handler is not responding and disables the IRQ because 'nobody cared'
Signed-off-by Ben Greear <[email protected]>5 jiffies as a hardcoded value is a bad idea, since it produces different behavior based on
CONFIG_HZ.I figured that was a benefit since it would run shorter duration on systems with a faster HZ clock.
Quoted 2 lines
Also, err, NAPI? Or is something else is going on here?
I don't really know, but part of my test was running traffic while creating 1200 stations, so likely there were lots of higher-level lock contention that slowed down sending pkts up the stack.
Quoted 8 lines
I got a bunch of errors about IRQs being ignored because nobody cared. I noticed that the ath9k loop could handle up to 500 or so frames, and that seemed like too many for my particular test case.
Once I put in this patch, I did not see the 'nobody cared' error again.
There could easily be a better fix. If you all want me to use a fixed time instead of HZ, then please suggest a value. I was testing with HZ of 1000, btw.
Hello,
I don't mind changing this patch, but I could use some guidance as to what values you all want me to use.
Should I use a millisecond based clock instead of jiffies?
What time duration do you want if 5 Jiffies (or 5ms) is not desired?
Thanks,
Ben
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com
Quoted 42 lines · Ben Greear
Quoted 35 lines · Ben Greear
Quoted 4 lines · Johannes Berg
Quoted 3 lines · Felix Fietkau
Quoted 2 lines · On 2018-02-07 00:05, [email protected] wrote:
From: Ben Greear <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
In case where the system is sluggish, we should probably break out early. Maybe this will fix issues where the OS thinks the IRQ handler is not responding and disables the IRQ because 'nobody cared'
Signed-off-by Ben Greear <[email protected]>5 jiffies as a hardcoded value is a bad idea, since it produces different behavior based on
CONFIG_HZ.I figured that was a benefit since it would run shorter duration on systems with
a faster HZ clock.Quoted 2 lines
Also, err, NAPI? Or is something else is going on here?
I don't really know, but part of my test was running traffic while creating
1200 stations, so likely there were lots of higher-level lock contention that
slowed down sending pkts up the stack.I got a bunch of errors about IRQs being ignored because nobody cared. I noticed
that the ath9k loop could handle up to 500 or so frames, and that seemed like too
many for my particular test case.Quoted 5 lines
Once I put in this patch, I did not see the 'nobody cared' error again.
There could easily be a better fix. If you all want me to use a fixed time instead
of HZ, then please suggest a value. I was testing with HZ of 1000, btw.
Quoted 8 lines
Hello,
I don't mind changing this patch, but I could use some guidance as to what values you all want me to use.
Should I use a millisecond based clock instead of jiffies?
What time duration do you want if 5 Jiffies (or 5ms) is not desired?
Hi Ben,
Instead of using some time unit you could consider breaking out after handing 'x' number of frames and make 'x' configurable through debugfs.
Regards,
Arend
Quoted 48 lines · Arend van Spriel
Quoted 47 lines · Ben Greear
Quoted 35 lines · Ben Greear
Quoted 4 lines · Johannes Berg
Quoted 3 lines · Felix Fietkau
Quoted 2 lines · On 2018-02-07 00:05, [email protected] wrote:
From: Ben Greear <[email protected]>
Quoted 8 lines
Quoted 8 lines
Quoted 5 lines
In case where the system is sluggish, we should probably break out early. Maybe this will fix issues where the OS thinks the IRQ handler is not responding and disables the IRQ because 'nobody cared'
Signed-off-by Ben Greear <[email protected]>5 jiffies as a hardcoded value is a bad idea, since it produces different behavior based on
CONFIG_HZ.I figured that was a benefit since it would run shorter duration on systems with
a faster HZ clock.Quoted 2 lines
Also, err, NAPI? Or is something else is going on here?
I don't really know, but part of my test was running traffic while creating
1200 stations, so likely there were lots of higher-level lock contention that
slowed down sending pkts up the stack.I got a bunch of errors about IRQs being ignored because nobody cared. I noticed
that the ath9k loop could handle up to 500 or so frames, and that seemed like too
many for my particular test case.Quoted 5 lines
Once I put in this patch, I did not see the 'nobody cared' error again.
There could easily be a better fix. If you all want me to use a fixed time instead
of HZ, then please suggest a value. I was testing with HZ of 1000, btw.Hello,
I don't mind changing this patch, but I could use some guidance as to what values you all want me to use.
Quoted 7 lines
Quoted 3 lines
Should I use a millisecond based clock instead of jiffies?
What time duration do you want if 5 Jiffies (or 5ms) is not desired?
Hi Ben,
Instead of using some time unit you could consider breaking out after handing 'x' number of frames and make 'x' configurable through debugfs.
I don't see why you would care about number of pkts...it is just a proxy for time, right?
So, in that case, then using jiffies (or some other fast timer) seems the most useful.
Thanks,
Ben
Quoted 4 lines
Regards,
Arend
Signature · 2 lines
Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com